ChanServ changed the topic of #asahi-dev to: Asahi Linux: porting Linux to Apple Silicon macs | Non-development talk: #asahi | General development | GitHub: https://alx.sh/g | Wiki: https://alx.sh/w | Logs: https://alx.sh/l/asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
mushisaaa has quit [Quit: mushisaaa]
KxCORP589 has quit [Quit: Bye!]
KxCORP589 has joined #asahi-dev
john-cabaj has quit [Ping timeout: 480 seconds]
xal has quit []
xal has joined #asahi-dev
mushisaaa has joined #asahi-dev
mushisaaa has quit [Quit: mushisaaa]
mushisaaa has joined #asahi-dev
jeisom has quit [Ping timeout: 480 seconds]
DarkShadow44 has joined #asahi-dev
DarkShadow4444 has quit [Ping timeout: 480 seconds]
ddxtanx has quit [Quit: Konversation terminated!]
mushisaaa has quit [Quit: mushisaaa]
<chadmed> jannau: macsmc_hwmon_read_key is not valid c11, so idk if we can keep it
<chadmed> gcc doesnt complain but clang emits a warning
<chadmed> easiest way to make it shut up would be to go back to declaring all the key types we support at the top of the function, as annoying as that is
mushisaaa has joined #asahi-dev
<chadmed> if we're only needing to support 'flt ' and 'ioft' then its fine imo
mushisaaa has quit [Quit: mushisaaa]
mushisaaa has joined #asahi-dev
tristan2 has joined #asahi-dev
tristan2_ has quit [Ping timeout: 480 seconds]
mushisaaa has quit [Ping timeout: 480 seconds]
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
baozich has joined #asahi-dev
ghishadow has joined #asahi-dev
ghishadow has quit [Ping timeout: 480 seconds]
nicolas17 has quit [Ping timeout: 480 seconds]
milky has quit [Quit: Lost terminal]
systwi has quit [Ping timeout: 480 seconds]
systwi has joined #asahi-dev
<jannau> chadmed: about '_SMC_KEY("flt ")'? try https://gist.github.com/jannau/0c0b5d7b95ce00cd7c3a4f989ebccdd8 instead
<chadmed> nah its the fact that there is a declaration after a label (the label being the case statement)
<chadmed> thats only officially adopted for C23
pb17 has quit [Ping timeout: 480 seconds]
<jannau> ah, that should be fine. a way out of it would be to move the parsing to functions
<chadmed> yeah not a big deal just unsure how upstream will feel about it when we get to that stage
<leio> should be fine if it's at start of a block and you can start a block after case label
<leio> and that's what I see in the linked patch to be done before and after?
<jannau> I thought so too, that's why I wrote the misguided patch, but I guess goto and switch labels are special
<leio> I have fixed upstream clang compilation warnings in the same way successfully and without any further problems by gentoo clang users
<leio> (those that do these early testing with newer versions and warning options)
<leio> where can I see the code itself as opposed to a diff?
<jannau> gcc was erroring out about the not being able to reduce the case statements to integer constants after rebasing onto 6.8.6-3
<leio> and the warning?
<jannau> I haven't compiled with clang
<chadmed> the warning is just "you cant have a declaration after a label" and is turned on by -Wc2x-extensions
<chadmed> hold on let me clean up, commit and push
<leio> that feels false positive warning if triggered for new variable decls after a block start
<chadmed> could be but i dont think if (x) { int y; } was ever defined behaviour right
<leio> how did I change kernel compile to clang? :D
<chadmed> make LLVM=1 LLVM_IAS=1
<chadmed> note that youll probably get asked about some config items
<leio> meh, why not CC=clang, too obvious? :D
<leio> ooh, LTOing options
<leio> you run your kernel from clang builds?
<chadmed> yup, have for years even on amd64
<leio> no warnings here from touch drivers/hwmon/macsmc-hwmon.c && make LLVM=1 LLVM_IAS=1 -j25
<leio> no -Wc2x-extensions passed though
<leio> -Wall is there though
pb17 has joined #asahi-dev
<leio> Adding -Wc2x-extensions only adds a warning from include/linux/path.h code, nothing for macsmc-hwmon.c
<chadmed> drivers/hwmon/macsmc-hwmon.c:103:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
<chadmed> clang 18 btw
<leio> that diff doesn't match the code I'm looking at from jannau's branch
<leio> where there is a block after case label
<leio> case _SMC_KEY("flt "): {
<chadmed> oh duh put it in a block
<leio> line number is like 20 off as well
<chadmed> yeah of course it is i rewrote parts of the driver and this version has no fan support because im not up to that yet
<chadmed> i still dont think we should allow the setting of fan speeds even behind a parameter btw
<chadmed> look at how many people ignored the repeated warnings about prematurely enabling their speakers
<chadmed> we cannot guarantee that messing with the fan settings is safe yet so we should not allow it to be done in production systems at all until we can
<jannau> I'm not proposing to merge that version. there is a legitimate development use for fan speed control. It makes CPU core temp key mapping easier
<chadmed> +1
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
ddxtanx has joined #asahi-dev
jeisom has joined #asahi-dev
kaazoo has joined #asahi-dev
buroa2 has quit [Quit: The Lounge - https://thelounge.chat]
buroa2 has joined #asahi-dev
MrKai774 has joined #asahi-dev
kaazoo has quit [Quit: Leaving.]
MrKai77 has quit [Ping timeout: 480 seconds]
MrKai774 is now known as MrKai77
kaazoo has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
baozich1 has joined #asahi-dev
baozich has quit [Ping timeout: 480 seconds]
baozich1 is now known as baozich
chadmed_ has joined #asahi-dev
pb17 has joined #asahi-dev
kaazoo has quit [Ping timeout: 480 seconds]
baozich1 has joined #asahi-dev
baozich has quit [Remote host closed the connection]
baozich1 is now known as baozich
kaazoo has joined #asahi-dev
baozich has quit [Ping timeout: 480 seconds]
kaazoo has quit [Quit: Leaving.]
linxz_ has joined #asahi-dev
linxz has quit [Ping timeout: 480 seconds]
linxz_ is now known as linxz
ghishadow has joined #asahi-dev
jeisom has quit [Remote host closed the connection]
jeisom has joined #asahi-dev
systwi has quit [Ping timeout: 480 seconds]
xcpy00 has quit [Quit: The Lounge - https://thelounge.chat]
systwi has joined #asahi-dev
wille-io has joined #asahi-dev
nicolas17 has joined #asahi-dev
glem3 has joined #asahi-dev
glem has quit [Ping timeout: 480 seconds]
glem3 is now known as glem
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
pbsds is now known as Guest2304
pbsds has joined #asahi-dev
Guest2304 has quit [Ping timeout: 480 seconds]
checkfoc_us has quit []
checkfoc_us has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
nela has quit [Quit: bye!]
nela has joined #asahi-dev
pb17 has joined #asahi-dev
hightower4 has joined #asahi-dev
hightower3 has quit [Ping timeout: 480 seconds]
mkurz has joined #asahi-dev
JayBeeFOSS has quit [Ping timeout: 480 seconds]
JayBeeFOSS has joined #asahi-dev
mkurz has quit [Quit: Konversation terminated!]
prime has quit [Ping timeout: 480 seconds]
prime has joined #asahi-dev
prime is now known as Guest2324
john-cabaj has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
roxfan2 has joined #asahi-dev
jeisom has quit [Remote host closed the connection]
pb17 has joined #asahi-dev
jeisom has joined #asahi-dev
roxfan has quit [Ping timeout: 480 seconds]
jeisom has quit [Read error: Connection reset by peer]
jeisom has joined #asahi-dev
WindowPain has joined #asahi-dev
WindowPa- has quit [Ping timeout: 480 seconds]
chadmed has quit [Quit: Konversation terminated!]
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
Simonx22 has quit [Remote host closed the connection]
chadmed has quit [Read error: Connection reset by peer]
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
chadmed has quit []
chadmed has joined #asahi-dev
maximbaz has quit [Quit: bye]
maximbaz has joined #asahi-dev
jeisom has quit [Remote host closed the connection]
jeisom has joined #asahi-dev
SalimTerryLi has quit [Ping timeout: 480 seconds]
Simonx22 has joined #asahi-dev
jeisom_ has joined #asahi-dev
jeisom has quit [Read error: Connection reset by peer]
SalimTerryLi has joined #asahi-dev
Simonx22 has quit []
Simonx22 has joined #asahi-dev
Simonx22 has quit []
Simonx22 has joined #asahi-dev
Simonx22 has quit []
Simonx22 has joined #asahi-dev
Simonx22 has quit []
Simonx22 has joined #asahi-dev
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
john-cabaj has quit [Ping timeout: 480 seconds]
schroes has quit [Read error: No route to host]
pb17 has quit [Ping timeout: 480 seconds]
pb17 has joined #asahi-dev
crabbedhaloablut has quit []
crabbedhaloablut has joined #asahi-dev
tobhe_ has quit [Remote host closed the connection]