23:33 <alyssa> Taking a look at the commits in corellium's repo versus my own branch (which has ~everyone's WIP merged together)

23:33 <alyssa> We have equivalents for ~28 commits from corellium's.

23:34 <alyssa> We have DCP (and I think USB hotplug?) support which is unique to our tree.

23:34 <alyssa> And we're missing equivalents for ~41 commits from corellium, covering:

23:34 <alyssa> clock gates, frequency scaling, SMC, SPI, macbook keyboard/mouse, wi-fi, SPMI, RTC, power-off, ATCPHY, and thunderbolt

23:35 <alyssa> the bulk of the diff is thunderbolt, tbh

23:35 <alyssa> I'm under the impression clock gates and freq scaling will be solved very soon

23:35 <alyssa> j_ey: has patches for SPI + keyboard/mouse as I understand, which I'm happy to cherry-pick but can't test mysel

23:35 <alyssa> sven: started stuff on SMC and ATCPHy as I understand

23:36 <alyssa> SPMI, RTC, and poweroff might be isolated enough to cherrypick from corellium's tree directly as a v1 (we've done this for e.g. pinctrl)

23:36 <j_ey> alyssa: spi+keyboard is corellium

23:36 <alyssa> j_ey: Ack.

23:37 <j_ey> alyssa: SPI keyboard parts is also a modification of a current applespi keyboard driver (mostly the same protocol as on the x86 macbooks)

23:37 <alyssa> j_ey: Still happy to cherry-pick if it's functional and picks cleanly.

23:38 <alyssa> anyway, parity with corellium would be nice.

23:38 <alyssa> or at least. corellium minus thunderbolt.

23:39 <alyssa> thunderbolt I imagine needs a lot more care when thinking about upstreaming and it's a lot of code so not something I'd like to just randomly cherrypick

23:40 <alyssa> okay, this is a better picture

23:40 <alyssa> 28 done, 17 nonthunderbolt missing, plus they have 24 commits for thunderbolt

23:40 <alyssa> ( https://rosenzweig.io/Corellium-patches.txt )

23:41 <j_ey> the main thing with smc is to actualyly hook other drivers up to it, like battery monitoring or whatever