08:01 <logicalerzor[m]> hello, ive been trying to write my first driver by mainlining a downstream driver, but i don’t know what ive been doing wrong... (full message at <https://matrix.org/oftc/media/v1/media/download/Aefxrcik0TJx8HrA0n-gr09vyCrWScUNB9MeWfKfQ-9T7lBnwxGnD6gE84dAECl2ELzNXt-z3fTrNiBDAbJL-sxCeSbN2ZNQAG1hdHJpeC5vcmcvS2VzcHBTUllUSWRSaFZ0dHhIWHB5VHpM>)

08:03 <phh> my personal way that not everyone agrees with, put a `printk("%s %s %d\n", __FILE__, __FUNCTION__, __LINE__);` almost everywhere in the driver to see what's up :-)

08:06 <phh> your downstream driver uses regulators lvs6 and l17, while your dts use l29 and l10

08:06 <macc24> why do you have output-enable on your interrupt gpio?

08:07 <phh> ah yeah nice catch

08:07 <macc24> you can also probably remove drive-strength, as it's an input pin

08:08 <macc24> oh and your sda and scl pins should be configured as outputs, not inputs, with pullups - if there's none on the board

08:09 <phh> and not as gpio function?

08:09 <macc24> they're using i2c-gpio for some reason, so it should be configured as a gpio

08:09 <phh> ah right

08:10 <logicalerzor[m]> oh i was using i2c-gpio because thats what downstream was doing

08:10 <phh> and open-drain outputs*

08:10 <logicalerzor[m]> i honestly dont have a lot of clues on what the meanings are in the dts i made

08:10 <logicalerzor[m]> thanks for both of your inputs ill try that

08:16 <logicalerzor[m]> <macc24> "why do you have output-enable on..." <- btw where can i find definitions for these? i thought i should have output-enable because the interrupt is outputting a signal

08:16 <logicalerzor[m]> seems like that was a bad guess tho

08:17 <macc24> logicalerzor[m]: they're in documentation

08:17 <macc24> output-enable is for making the pin an output from perspective of the soc

08:17 <logicalerzor[m]> oh gotcha thanks!

08:18 <macc24> https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/qcom%2Cmsm8960-pinctrl.yaml

08:19 <macc24> ok they are not described, just mentioned, https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/pinctrl/qcom%2Ctlmm-common.yaml#L75

14:18 <marc|gonzalez> lumag: I've posted my current code (for audio) in case someone feels generous, and spots an obvious mistake.

20:53 <logicalerzor[m]> <phh> "your downstream driver uses..." <- i think my board is great than rev6 and just having l29 seems to turn the leds on at half brightness

20:54 <logicalerzor[m]> i think my sda and scl lines are wrong as well as my interrupt line. cat /proc/interrupts doesn’t show the line going off. doing echo 1 > /sys/class/leds/tm2-touchkey/brightness returns -6

20:55 <logicalerzor[m]> > <@_oftc_phh:matrix.org> your downstream driver uses regulators lvs6 and l17, while your dts use l29 and l10

20:55 <logicalerzor[m]> * i think my board is greater than rev6 and just having l29 seems to turn the leds on at half brightness. anything else and the touchkey stays off

20:55 <logicalerzor[m]> or maybe my assumption that this driver would work is wrong… hm