10:46 <pac85> zmike: now that I have one prog per variant does screen->pipeline_libs still make sense? After all all variants are stored in the same prog which is never replaced.

12:39 <zmike> pac85: yes, that's for e.g. DOOM where the game compiles shaders in one context and uses them in another

13:10 <pac85> zmike: oh I see, but if I want to remove the hash set from prog to avoid doing two hashset lookups (first prog then lib) it will need changes. I guess the set has to stay then, but only actually have it in the non variant prog (so screen->pipeline_libs doesn't get loocked up for every variant), then add a field with a single lib that I use for the variants and for the uber shader?

13:11 <zmike> right, it only needs to have the precompile prog, no variants

13:12 <zmike> contexts can handle compiling their own optimized variants

13:12 <zmike> this only exists to handle precompile

13:22 <pac85> Oh right, so does this mean that each entry in screen->pipeline_libs will only stores one lib? I mean currently the variants end up in those sets but with my changes it would end up with just one element all the time right?

13:23 <zmike> yeah probably

13:23 <pac85> right, so then I can store the library in the set directly.

13:24 <pac85> thx

13:24 <pac85> BTW the game would be DOOM 2016 right?

13:24 <zmike> yeah that will make more sense when there's only one precompile shader

13:24 <zmike> yes doom 2016

13:24 <zmike> iirc it's even in the commit log that added it

13:24 <pac85> Mmm I'll take a look.