urja has quit [Read error: Connection reset by peer]
camus1 has quit [Read error: Connection reset by peer]
urja has joined #panfrost
camus has joined #panfrost
pbrobinson has quit [Ping timeout: 480 seconds]
pbrobinson has joined #panfrost
schlumpf7 has joined #panfrost
schlumpf7 has quit [Remote host closed the connection]
CME_ has quit [Ping timeout: 480 seconds]
CME has joined #panfrost
nashpa has joined #panfrost
dliviu has quit [Ping timeout: 480 seconds]
DVulgaris has quit [Ping timeout: 480 seconds]
DVulgaris has joined #panfrost
DVulgaris has quit [Ping timeout: 480 seconds]
Dr_Who has joined #panfrost
CME has quit [Ping timeout: 480 seconds]
CME has joined #panfrost
DVulgaris has joined #panfrost
hanetzer2 has joined #panfrost
hanetzer1 has quit [Ping timeout: 480 seconds]
CME_ has joined #panfrost
CME has quit [Ping timeout: 480 seconds]
atler has quit [Quit: atler]
<italove>
bbrezillon: alyssa: Do you know if/how pan_legalize_afbc_format is supposed to work when called through panfrost_blit? It seems that if we hit a case where AFBC needs to decompressed, pan_legalize_afbc_format will then call panfrost_blit recursively, meaning that the blitter state will fail to be restored properly, which will lead to a crash on
<italove>
util_blitter_blit_generic()
<italove>
not sure how to handle that
<robclark>
you should probably only AFBC for things you know how to blit.. I have same issue with UBWC
<italove>
couldn't we deepcopy the blitter_state and re-restore it later to workaround this? seems hackish but I don't see why it wouldn't work...
<robclark>
oh, maybe I misunderstood what the issue was.. I was thinking that you were hitting sw fallback which triggered transfer_map (which would do a blit to linearize turning into infinite recursion)
<alyssa>
italove: I guess the easy answer is "don't do that" ...
<alyssa>
I assume this is copy_image required?
<alyssa>
robclark: this is an AFBC->uncompressed blit to transition compressed resources, if you try to create a texture view with an incompatible format
<alyssa>
I guess my question is why u_blitter is using a texture view
<robclark>
yeah, ubwc has to do the same sorts of transitions.. but I guess we don't end up falling back to u_blitter for those
<alyssa>
italove: fwiw legalizing won't be necessary on valhall
<alyssa>
v9 adds the ability to do afbc texture views
<alyssa>
(compression quality will suck but it will /work/ which is the important part)
<alyssa>
a luxury I do not have on AGX :~)
atler has joined #panfrost
<italove>
alyssa: yeah it's for copy_image
<alyssa>
fun for the whole family
<italove>
ack on v9 texture views
* alyssa
is currently in copy_image hell, Vulkan edition
<alyssa>
surprisingly good way to teach myself Vulkan though so who's to say if it's so bad
rasterman has quit [Quit: Gettin' stinky!]
<italove>
hehe
<italove>
alyssa: unless I'm misunderstanding I don't think it matters that u_blitter is using sampler views, because using create_surface would lead to the same result anyway
<alyssa>
sure
pbrobinson has quit [Remote host closed the connection]