06:56 <wlb> wayland Merge request !308 closed (client: Use stderr instead of wl_log() for proxies warnings)

13:22 <wlb> wayland Issue #374 opened by Edgars Cīrulis (Edgars-Cirulis) Applications crashing on exit after updating Wayland package to 1.22.0-1 (arch linux) https://gitlab.freedesktop.org/wayland/wayland/-/issues/374

13:39 <kchibisov> it's sort of impressing how many clients decide to crash from the 'logger'…

13:41 <davidre> I think qt would not crash in the log handler

13:41 <davidre> Not sure why people say this

13:41 <psykose> i think the qt case is not an actual crash, but just looks annoying

13:45 <davidre> Calling crash in a log handler is an interesting decision at least

13:46 <kchibisov> Does libwayland define a log messages naming scheme? Like can client dicede whether something is 'warning:' or error.

13:48 <kchibisov> Given that there're multiple wrappers around libwayland it would be nice if such thing was defined, so the wrapper logger could properly pass the message to the right logger handler.

13:49 <davidre> If there is an error you know with wl_display_check_error

13:49 <davidre> And dispatch and friends return not 0

13:50 <kchibisov> I mean I don't decide about the crash based on error and such in the logger.

13:50 <kchibisov> I just to group logs from libwayland.

13:50 <kchibisov> I just want to*

13:52 <kchibisov> The thing is that I don't have access to wl_display inside the logger.

13:53 <kchibisov> I'd assume you've meant `wl_display_get_error`, which takes `wl_display` as an argument.

13:54 <davidre> Yes typing from my phone

13:58 <kchibisov> Though, given that some logs in libwayland has some description attached to them, it might not be that trivial.

14:00 <kchibisov> But commnly speaking it would be nice to have some sort of `enum LOG_TARGET { WARNING, DEBUG, ERROR }` passed to the handler or somehow encoded inside the message. As in `warning` has `warning:` prefix, same with `errors:` and everything else is `debug` messages to help you with errors.

14:01 <kchibisov> I think it was the first 'warning' added by libwayland, so it's not like the scheme can't be reliably applied now.

14:05 <zzag> kchibisov: in all fairness, there aren't actually that many clients that crash. it's just that xwayland and firefox/thunderbird affect a lot of folks :)

14:06 <kchibisov> zzag: yeah, that's true, it just managed to hit the most used ones.

14:10 <kchibisov> Though, distro packagers will likely revert their bump for now or patch it somehow.