13:22 <kusma> @zmike: 49efa73ba11c4cacaed0052b984e1fb884cf7600 broke zink+anv for me, crashing in an assert...

13:22 <kusma> glxgears: ../../../src/mesa/src/vulkan/runtime/vk_image.c:169: vk_common_GetImageDrmFormatModifierPropertiesEXT: Assertion `image->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT' failed.

13:24 <zmike> hm working fine here

13:25 <zmike> will try on another machine...

13:30 <kusma> if (screen->info.have_EXT_image_drm_format_modifier)

13:30 <kusma> screen->implicit_mod = DRM_FORMAT_MOD_INVALID;

13:30 <kusma> Should maybe that condition be negated?

13:30 <zmike> no, that's correct

13:30 <kusma> OK

13:31 <zmike> can you get me a backtrace?

13:31 <kusma> sure

13:33 <kusma> https://gitlab.freedesktop.org/-/snippets/6961

13:34 <zmike> huh.

13:35 <zmike> you running this in xorg or xwayland or wayland or what

13:35 <kusma> wayland, but probably throught xwayland; this is glxgears

13:47 <zmike> yeah I can't get it to assert here 🤔

13:48 <zmike> can you print image->tiling at the assert frame?

13:49 <zmike> I assume optimal

14:00 <zmike> hm I'd guess that somehow you have no available modifiers in your xwayland instance?

14:06 <kusma> VK_IMAGE_TILING_OPTIMAL

14:07 <zmike> hm ok, I think this needs a spec issue to relax a vuid

14:07 <zmike> but also it's very weird to me that you have no modifiers available

14:13 <zmike> kusma: https://gitlab.khronos.org/vulkan/vulkan/-/issues/3197 I think I should be able to get a resolution on this within the next week

14:13 <zmike> but I'd suggest you may want to investigate your system, since having zero modifiers available seems suspicious

14:14 <kusma> zmike: I'm not quite sure what that means... the zero comes from zink_resource_create_drawable(), which just passes zero in there...

14:15 <zmike> what zero?

14:15 <kusma> modifiers_count=0 passed to resource_create

14:15 <zmike> that's unrelated

14:15 <zmike> it's a swapchain image, so the modifiers aren't visible outside of that function

14:16 <kusma> Then I don't know what to investigate

14:16 <zmike> it's not a zink thing, it's a displayserver thing

14:16 <zmike> it seems your xwayland is not advertising any modifiers

14:17 <zmike> maybe it's very old?

14:17 <kusma> Not very old I think...

14:18 <kusma> 22.1.3-1

14:19 <zmike> hm I have 21.1.3 on one of my machines too

14:19 <zmike> though I guess if your system mesa is significantly older than what you're trying to run here then that may make a difference too?

14:22 <kusma> I'm using mesa from the main branch...

14:22 <zmike> bnieuwenhuizen might have some ideas here

14:22 <kusma> I'm on Debian Sid, so nothing should be particularly old, I think...

14:22 <bnieuwenhuizen> ?

14:23 <zmike> what could be some causes for having xwayland claim there are no modifiers available?

14:23 <kusma> But, I've got to run now, kiddo needs to be picked up from Kindergarten...

14:23 <bnieuwenhuizen> zmike: have an old GPU?

14:23 <zmike> possible I guess?

14:24 <bnieuwenhuizen> not sure what GPU kusma has

14:24 <kusma> 630, pretty old

14:25 <bnieuwenhuizen> if that is a Radeon 630 Mobile, yeah seems like GFX8 for which we don't have modifiers yet

14:26 <zmike> it's intel

14:26 <bnieuwenhuizen> oh

14:26 <bnieuwenhuizen> no idea then

14:26 <zmike> could be the same thing

15:15 <kusma> The GPU support modifiers

17:42 <zmike> kusma: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18148 should fix it

17:46 <kusma> Awesome, thanks!