00:23
pb17 has quit [Ping timeout: 480 seconds]
00:31
pb17 has joined #asahi-dev
00:45
mushisaaa has quit [Quit: mushisaaa]
01:00
KxCORP589 has quit [Quit: Bye!]
01:00
KxCORP589 has joined #asahi-dev
01:02
john-cabaj has quit [Ping timeout: 480 seconds]
01:05
xal has joined #asahi-dev
01:05
mushisaaa has joined #asahi-dev
01:13
mushisaaa has quit [Quit: mushisaaa]
01:19
mushisaaa has joined #asahi-dev
01:52
jeisom has quit [Ping timeout: 480 seconds]
02:04
DarkShadow44 has joined #asahi-dev
02:06
DarkShadow4444 has quit [Ping timeout: 480 seconds]
02:25
ddxtanx has quit [Quit: Konversation terminated!]
02:35
mushisaaa has quit [Quit: mushisaaa]
02:37
<
chadmed >
jannau: macsmc_hwmon_read_key is not valid c11, so idk if we can keep it
02:37
<
chadmed >
gcc doesnt complain but clang emits a warning
02:40
<
chadmed >
easiest way to make it shut up would be to go back to declaring all the key types we support at the top of the function, as annoying as that is
02:40
mushisaaa has joined #asahi-dev
02:41
<
chadmed >
if we're only needing to support 'flt ' and 'ioft' then its fine imo
03:26
mushisaaa has quit [Quit: mushisaaa]
03:28
mushisaaa has joined #asahi-dev
03:30
tristan2 has joined #asahi-dev
03:32
tristan2_ has quit [Ping timeout: 480 seconds]
03:36
mushisaaa has quit [Ping timeout: 480 seconds]
03:38
pb17 has quit [Ping timeout: 480 seconds]
03:46
pb17 has joined #asahi-dev
03:54
baozich has joined #asahi-dev
03:57
ghishadow has joined #asahi-dev
04:28
ghishadow has quit [Ping timeout: 480 seconds]
04:45
nicolas17 has quit [Ping timeout: 480 seconds]
04:50
milky has quit [Quit: Lost terminal]
05:24
systwi has quit [Ping timeout: 480 seconds]
05:24
systwi has joined #asahi-dev
05:31
<
chadmed >
nah its the fact that there is a declaration after a label (the label being the case statement)
05:31
<
chadmed >
thats only officially adopted for C23
05:36
pb17 has quit [Ping timeout: 480 seconds]
05:44
<
jannau >
ah, that should be fine. a way out of it would be to move the parsing to functions
05:53
<
chadmed >
yeah not a big deal just unsure how upstream will feel about it when we get to that stage
05:57
<
leio >
should be fine if it's at start of a block and you can start a block after case label
05:57
<
leio >
and that's what I see in the linked patch to be done before and after?
06:04
<
jannau >
I thought so too, that's why I wrote the misguided patch, but I guess goto and switch labels are special
06:05
<
leio >
I have fixed upstream clang compilation warnings in the same way successfully and without any further problems by gentoo clang users
06:06
<
leio >
(those that do these early testing with newer versions and warning options)
06:07
<
leio >
where can I see the code itself as opposed to a diff?
06:10
<
jannau >
gcc was erroring out about the not being able to reduce the case statements to integer constants after rebasing onto 6.8.6-3
06:10
<
leio >
and the warning?
06:11
<
jannau >
I haven't compiled with clang
06:14
<
chadmed >
the warning is just "you cant have a declaration after a label" and is turned on by -Wc2x-extensions
06:14
<
chadmed >
hold on let me clean up, commit and push
06:14
<
leio >
that feels false positive warning if triggered for new variable decls after a block start
06:16
<
chadmed >
could be but i dont think if (x) { int y; } was ever defined behaviour right
06:17
<
leio >
how did I change kernel compile to clang? :D
06:17
<
chadmed >
make LLVM=1 LLVM_IAS=1
06:18
<
chadmed >
note that youll probably get asked about some config items
06:19
<
leio >
meh, why not CC=clang, too obvious? :D
06:19
<
leio >
ooh, LTOing options
06:19
<
leio >
you run your kernel from clang builds?
06:19
<
chadmed >
yup, have for years even on amd64
06:23
<
leio >
no warnings here from touch drivers/hwmon/macsmc-hwmon.c && make LLVM=1 LLVM_IAS=1 -j25
06:24
<
leio >
no -Wc2x-extensions passed though
06:24
<
leio >
-Wall is there though
06:26
pb17 has joined #asahi-dev
06:27
<
leio >
Adding -Wc2x-extensions only adds a warning from include/linux/path.h code, nothing for macsmc-hwmon.c
06:40
<
chadmed >
drivers/hwmon/macsmc-hwmon.c:103:3: warning: label followed by a declaration is a C23 extension [-Wc23-extensions]
06:41
<
chadmed >
clang 18 btw
06:41
<
leio >
that diff doesn't match the code I'm looking at from jannau's branch
06:41
<
leio >
where there is a block after case label
06:42
<
leio >
case _SMC_KEY("flt "): {
06:42
<
chadmed >
oh duh put it in a block
06:43
<
leio >
line number is like 20 off as well
06:43
<
chadmed >
yeah of course it is i rewrote parts of the driver and this version has no fan support because im not up to that yet
06:46
<
chadmed >
i still dont think we should allow the setting of fan speeds even behind a parameter btw
06:46
<
chadmed >
look at how many people ignored the repeated warnings about prematurely enabling their speakers
06:46
<
chadmed >
we cannot guarantee that messing with the fan settings is safe yet so we should not allow it to be done in production systems at all until we can
07:01
<
jannau >
I'm not proposing to merge that version. there is a legitimate development use for fan speed control. It makes CPU core temp key mapping easier
08:31
pb17 has quit [Ping timeout: 480 seconds]
09:02
pb17 has joined #asahi-dev
09:46
ddxtanx has joined #asahi-dev
09:51
jeisom has joined #asahi-dev
10:02
kaazoo has joined #asahi-dev
10:07
buroa2 has joined #asahi-dev
10:08
MrKai774 has joined #asahi-dev
10:10
kaazoo has quit [Quit: Leaving.]
10:12
MrKai77 has quit [Ping timeout: 480 seconds]
10:12
MrKai774 is now known as MrKai77
10:46
kaazoo has joined #asahi-dev
11:05
pb17 has quit [Ping timeout: 480 seconds]
11:13
baozich1 has joined #asahi-dev
11:18
baozich has quit [Ping timeout: 480 seconds]
11:18
baozich1 is now known as baozich
11:22
chadmed_ has joined #asahi-dev
11:32
pb17 has joined #asahi-dev
11:49
kaazoo has quit [Ping timeout: 480 seconds]
11:53
baozich1 has joined #asahi-dev
11:54
baozich has quit [Remote host closed the connection]
11:54
baozich1 is now known as baozich
11:55
kaazoo has joined #asahi-dev
12:05
baozich has quit [Ping timeout: 480 seconds]
12:12
kaazoo has quit [Quit: Leaving.]
12:15
linxz_ has joined #asahi-dev
12:19
linxz has quit [Ping timeout: 480 seconds]
12:19
linxz_ is now known as linxz
12:30
ghishadow has joined #asahi-dev
12:31
jeisom has quit [Remote host closed the connection]
12:32
jeisom has joined #asahi-dev
12:38
systwi has quit [Ping timeout: 480 seconds]
12:40
systwi has joined #asahi-dev
12:44
wille-io has joined #asahi-dev
12:48
nicolas17 has joined #asahi-dev
12:55
glem3 has joined #asahi-dev
13:00
glem has quit [Ping timeout: 480 seconds]
13:00
glem3 is now known as glem
13:21
pb17 has quit [Ping timeout: 480 seconds]
13:23
pb17 has joined #asahi-dev
14:11
pbsds is now known as Guest2304
14:11
pbsds has joined #asahi-dev
14:15
Guest2304 has quit [Ping timeout: 480 seconds]
14:50
checkfoc_us has quit []
14:52
checkfoc_us has joined #asahi-dev
15:09
pb17 has quit [Ping timeout: 480 seconds]
15:17
pb17 has joined #asahi-dev
16:46
pb17 has quit [Ping timeout: 480 seconds]
17:03
nela has quit [Quit: bye!]
17:04
nela has joined #asahi-dev
17:05
pb17 has joined #asahi-dev
17:09
hightower4 has joined #asahi-dev
17:16
hightower3 has quit [Ping timeout: 480 seconds]
17:16
mkurz has joined #asahi-dev
17:19
JayBeeFOSS has quit [Ping timeout: 480 seconds]
17:20
JayBeeFOSS has joined #asahi-dev
17:38
mkurz has quit [Quit: Konversation terminated!]
18:20
prime has quit [Ping timeout: 480 seconds]
18:23
prime has joined #asahi-dev
18:23
prime is now known as Guest2324
18:41
john-cabaj has joined #asahi-dev
19:02
pb17 has quit [Ping timeout: 480 seconds]
19:13
roxfan2 has joined #asahi-dev
19:15
jeisom has quit [Remote host closed the connection]
19:15
pb17 has joined #asahi-dev
19:17
jeisom has joined #asahi-dev
19:19
roxfan has quit [Ping timeout: 480 seconds]
19:19
jeisom has quit [Read error: Connection reset by peer]
19:19
jeisom has joined #asahi-dev
19:50
WindowPain has joined #asahi-dev
19:55
WindowPa- has quit [Ping timeout: 480 seconds]
19:58
chadmed has quit [Quit: Konversation terminated!]
19:58
chadmed has joined #asahi-dev
19:58
chadmed has quit []
19:58
chadmed has joined #asahi-dev
19:59
chadmed has quit []
19:59
chadmed has joined #asahi-dev
19:59
Simonx22 has quit [Remote host closed the connection]
19:59
chadmed has quit [Read error: Connection reset by peer]
19:59
chadmed has joined #asahi-dev
19:59
chadmed has quit []
20:00
chadmed has joined #asahi-dev
20:01
chadmed has quit []
20:01
chadmed has joined #asahi-dev
20:02
chadmed has quit []
20:02
chadmed has joined #asahi-dev
20:03
chadmed has quit []
20:03
chadmed has joined #asahi-dev
20:04
chadmed has quit []
20:05
chadmed has joined #asahi-dev
20:07
chadmed has quit []
20:07
chadmed has joined #asahi-dev
20:07
maximbaz has quit [Quit: bye]
20:07
maximbaz has joined #asahi-dev
20:07
jeisom has quit [Remote host closed the connection]
20:09
jeisom has joined #asahi-dev
20:09
SalimTerryLi has quit [Ping timeout: 480 seconds]
20:10
Simonx22 has joined #asahi-dev
20:15
jeisom_ has joined #asahi-dev
20:15
jeisom has quit [Read error: Connection reset by peer]
20:18
SalimTerryLi has joined #asahi-dev
20:25
Simonx22 has quit []
20:27
Simonx22 has joined #asahi-dev
20:28
Simonx22 has quit []
20:28
Simonx22 has joined #asahi-dev
20:36
Simonx22 has quit []
20:36
Simonx22 has joined #asahi-dev
20:38
Simonx22 has quit []
20:40
Simonx22 has joined #asahi-dev
20:56
pb17 has quit [Ping timeout: 480 seconds]
21:18
pb17 has joined #asahi-dev
22:10
john-cabaj has quit [Ping timeout: 480 seconds]
22:29
schroes has quit [Read error: No route to host]
23:07
pb17 has quit [Ping timeout: 480 seconds]
23:15
pb17 has joined #asahi-dev
23:19
crabbedhaloablut has quit []
23:21
crabbedhaloablut has joined #asahi-dev
23:34
tobhe_ has quit [Remote host closed the connection]