<tzimmermann>
javierm, it's not you; it's the old code
<tzimmermann>
nomodeset is badly named and inconsistently used
<tzimmermann>
thanks for trying to fix that
pcercuei has joined #dri-devel
<javierm>
tzimmermann: no worries, I don't mind to iterate as many times as needed
<javierm>
tzimmermann: thanks a lot for your feedback and patience
<danvet>
mripard, drm_encoder->crtc is also a bit dangerous to check
<danvet>
or did you shuffle the code to move the update of that pointer under your encoder->mutex too?
<danvet>
ah later patch fixes that
JohnnyonFlame has quit [Ping timeout: 480 seconds]
<danvet>
mripard, with the caveat that I'm massively behind on anything dri-devel, not really awake yet (coffee broken?) and distracted with other stuff
<danvet>
a-b: me on the series
<danvet>
lgtm
<danvet>
it is annoying that we don't have a better answer than this for drivers
<danvet>
especially since with hdmi/dp having multiple interfaces is very common
<danvet>
but I also really don't have any good ideas for how to fix this in some kind of helpers
camus has joined #dri-devel
camus1 has quit [Ping timeout: 480 seconds]
mclasen has joined #dri-devel
<javierm>
tzimmermann: so I think that we should keep the nomodeset check function boolean and just make it a getter, i.e: drm_get_modeset()
<javierm>
tzimmermann: and make drm_driver_check() to return -ENODEV if nomodeset
<tzimmermann>
javierm, ok
<tzimmermann>
i'd call the public function just drm_check_available() because the driver argument got lost now
<javierm>
tzimmermann: sounds good to me
flacks has quit [Quit: Quitter]
flacks has joined #dri-devel
rpigott has quit [Remote host closed the connection]
rpigott has joined #dri-devel
rpigott has quit [Remote host closed the connection]
rpigott has joined #dri-devel
<danvet>
airlied, there seems to be some conflict going on with MODULE_IMPORT_NS(DMA_BUF); between us and gregkh's tree
<danvet>
tzimmermann merged a fix, but maybe something to point out to linus in case it fails to merge
camus1 has quit [Read error: Connection reset by peer]
ppascher has joined #dri-devel
<jani>
danvet: ^^
<jani>
danvet: apparently caused by 0d979509539e ("drm/ttm: remove ttm_bo_vm_insert_huge()") you pushed
tarceri has quit [Read error: Connection reset by peer]
tarceri has joined #dri-devel
macromorgan is now known as Guest5003
Guest4750 has quit [Read error: Connection reset by peer]
macromorgan has joined #dri-devel
camus has quit []
dreda has quit []
dreda has joined #dri-devel
alatiera has joined #dri-devel
X-Scale` has joined #dri-devel
X-Scale has quit [Ping timeout: 480 seconds]
[X-Scale] has joined #dri-devel
<jekstrand>
dj-death, bnieuwenhuizen: This is your semi-regular reminder to look at my vk-common-sync MR. :-P
X-Scale` has quit [Ping timeout: 480 seconds]
<dj-death>
jekstrand: yeah sorry :(
<dj-death>
jekstrand: I was going to fix anv using the same behavior you have in that MR first
<jekstrand>
dj-death: Yeah, we probably should do *something* to close the ANV bugs for now.
<jekstrand>
I don't know if we need a complete fix but if we can, that'd be good.
<dj-death>
yeah, I think I just needed the wait_for_available that you used
fxkamd has joined #dri-devel
<zmike>
mareko: partial_velem_mask is always guaranteed to be a contiguous bitset? the docs are ambiguous here, stating that they're bound contiguously, not that the bits are contiguous
JohnnyonFlame has joined #dri-devel
tarceri has quit [Remote host closed the connection]
mattrope has joined #dri-devel
tarceri has joined #dri-devel
oneforall2 has quit [Read error: Connection reset by peer]
<mareko>
zmike: no
<mareko>
zmike: it's either equal to full_velem_mask, in which case you bind velem as-is, or it's a strict subset of full_velem_mask, which disables vertex elements as if they weren't there
<zmike>
got it
fxkamd has quit []
<danvet>
jani, uh crap, will take a look
<danvet>
uh we have a pile of topic branches that never got cleaned up
<danvet>
Lyude, jani ^^
<danvet>
not sure who all else
<danvet>
maybe need to just ditch them all?
camus has joined #dri-devel
<mareko>
zmike: full_velem_mask can also have holes, it's really VERT_ATTRIB_BIT mask
<zmike>
👍
<zmike>
I think I have a rough impl for zink, but then I got waylaid because I have to do primconvert too
<zmike>
what a disaster
dsrt^ has quit [Ping timeout: 480 seconds]
<danvet>
airlied, mripard the pmd removal patch from ttm from jason gunthorpe in drm-misc-next-fixes will cause some compile file in i915-ttm
<mareko>
if you want to emulate prims, a mesh shader would probably work best
<danvet>
so beware when merging and rebuild drm-tip
<zmike>
yeah, that's what I've been considering lately
<zmike>
but actually being able to use those in drivers is a long ways off
<zmike>
might also solve my alignment problems
tzimmermann has quit [Quit: Leaving]
<zmike>
in the meanwhile though, onwards with the gross hacks
<mareko>
🤮
<zmike>
you haven't even seen how awful this code is
<zmike>
save your vomit
<zmike>
you'll need it
<mareko>
ok I'll hold it in my mouth
<zmike>
there we go
<danvet>
jani, should be sorted, apologies for the mess
hansg has quit [Remote host closed the connection]
hansg has joined #dri-devel
jkrzyszt has quit [Ping timeout: 480 seconds]
sdutt has joined #dri-devel
alatiera1 has joined #dri-devel
hansg has quit [Remote host closed the connection]
ybogdano has joined #dri-devel
hansg has joined #dri-devel
alatiera has quit [Ping timeout: 480 seconds]
hansg has quit [Read error: Connection reset by peer]
hansg has joined #dri-devel
<airlied>
danvet: i already sent that MAINTAINERS patch to Linus
<danvet>
airlied, hah well I applied it once more
<danvet>
hwentlan_, [PATCH v2] drm/dp: Fix aux->transfer NULL pointer dereference on drm_dp_dpcd_access <- this thread needs a bit more clue from amd's side, jani seems to be talking to a wall :-/
tarceri has quit [Read error: Connection reset by peer]
tarceri has joined #dri-devel
gouchi has joined #dri-devel
ybogdano has quit [Ping timeout: 480 seconds]
<jani>
danvet: indeed. you get my point though?
<danvet>
jani, 100%
<danvet>
the fix is not a fix
<zmike>
imirkin: heroic
<imirkin>
that's my middle name =]
<zmike>
sure seems that way
<jani>
danvet: *phew* I was starting to question myself there a bit ;D
<Lyude>
jani: have been in many discussions similar to this thread as of late :s, I've been having to try to set my foot down with folks figuring out the root cause of issues they're sending patches for as well…
ybogdano has joined #dri-devel
<jani>
Lyude: occasionally they slip through, and then years later you try to figure out why some check is there, or why some other mysterious bug surfaced
<Lyude>
yeah…
* Lyude
glad to know she isn't the only one though, lol
<jani>
absolutely not :)
<Lyude>
also, is checkpatch just broken now?
<Lyude>
like, the checkpatch bot
<jani>
Lyude: why, something specific?
<Lyude>
jani: for a while now on/off I keep seeing the bot just fail all of my patches with all of the errors being filled with "+drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:315:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB""
<jani>
Lyude: ah, sparse. dunno what gives there.
<jani>
Lyude: but I don't think we stop at static checks if the patch applies and builds
<danvet>
Lyude, maybe it needs the gcc __packed__ annotation instead of what they're doing now
<danvet>
also maybe s/_Static_assert/BUILD_BUG_ON/ or so
* danvet
no idea
<jani>
danvet: s/_Static_assert/static_assert/g at a minimum
<jani>
#pragma pack(push, 1) // PF2VF / VF2PF data areas are byte packed
<imirkin>
except seems like it got messed up somehow
<imirkin>
normally you do like #define a(s) #s ; #define b(s) a(s)
<imirkin>
or something
<imirkin>
and that somehow helps things
<jani>
imirkin: normally you use the stuff already available in kernel ;)
<imirkin>
like if you're appending stuff
<imirkin>
ah yes.
<imirkin>
i thought you were asking about the pattern
<jani>
nah
<jani>
now going for real, have a nice w/e everyone
tomeu7 has joined #dri-devel
tonyk2 has joined #dri-devel
fahien3 has joined #dri-devel
<imirkin>
oh right. the thing i was thinking of is if you want to concatenate two tokens, if you just do a ## b, you can run into some trouble, and a second level of macro indirection cures all.
opotin2 has joined #dri-devel
mstoeckl has quit [Remote host closed the connection]
mstoeckl has joined #dri-devel
iokill_ has joined #dri-devel
fahien has quit [Read error: Connection reset by peer]
tomeu has quit [Write error: connection closed]
opotin has quit [Read error: Connection reset by peer]
tonyk has quit [Read error: Connection reset by peer]
iokill has quit [Read error: Connection reset by peer]
ybogdano has quit [Ping timeout: 480 seconds]
nchery has quit [Ping timeout: 480 seconds]
dsrt^ has joined #dri-devel
mriesch has quit [Read error: Connection reset by peer]
mriesch has joined #dri-devel
opotin23 has joined #dri-devel
italove3 has joined #dri-devel
opotin2 has quit [Read error: Connection reset by peer]
fahien3 has quit [Remote host closed the connection]
italove has quit [Read error: Connection reset by peer]
fahien3 has joined #dri-devel
lemonzest has quit [Quit: WeeChat 3.2]
<Lyude>
jani: yeah…, what you just experienced is what happens to me every time I try digging into that driver :P
ybogdano has joined #dri-devel
nchery has joined #dri-devel
illwieckz has quit [Read error: Connection reset by peer]
ybogdano has quit [Ping timeout: 480 seconds]
sravn has quit [Ping timeout: 480 seconds]
sravn has joined #dri-devel
tonyk2 is now known as tonyk
nchery has quit [Remote host closed the connection]
nchery has joined #dri-devel
dottedmag has quit [Quit: QUIT]
calebccff_ has joined #dri-devel
CME_ has joined #dri-devel
lanodan_ has joined #dri-devel
pinchart1 has joined #dri-devel
CME has quit [Read error: Connection reset by peer]
italove3 has quit [Read error: Connection reset by peer]
calebccff has quit [Read error: Connection reset by peer]
italove3 has joined #dri-devel
alatiera12 has joined #dri-devel
lanodan has quit [Read error: Connection reset by peer]
pinchartl has quit [Remote host closed the connection]
Terman has quit [Remote host closed the connection]
Terman has joined #dri-devel
vsyrjala has quit [Remote host closed the connection]
vsyrjala has joined #dri-devel
gawin has quit [Remote host closed the connection]
alatiera12 has quit [reticulum.oftc.net liquid.oftc.net]
italove3 has quit [reticulum.oftc.net liquid.oftc.net]
sravn has quit [reticulum.oftc.net liquid.oftc.net]
mriesch has quit [reticulum.oftc.net liquid.oftc.net]
alatiera1 has quit [reticulum.oftc.net liquid.oftc.net]
Surkow|laptop has quit [reticulum.oftc.net liquid.oftc.net]
Akari has quit [reticulum.oftc.net liquid.oftc.net]
agx has quit [reticulum.oftc.net liquid.oftc.net]
moony has quit [reticulum.oftc.net liquid.oftc.net]
lplc has quit [reticulum.oftc.net liquid.oftc.net]
halfline has quit [reticulum.oftc.net liquid.oftc.net]
ced117 has quit [reticulum.oftc.net liquid.oftc.net]
kgz has quit [reticulum.oftc.net liquid.oftc.net]
Prf_Jakob has quit [reticulum.oftc.net liquid.oftc.net]
crabbedhaloablut has quit [reticulum.oftc.net liquid.oftc.net]
yshui` has quit [reticulum.oftc.net liquid.oftc.net]
YaLTeR[m] has quit [reticulum.oftc.net liquid.oftc.net]
reactormonk[m] has quit [reticulum.oftc.net liquid.oftc.net]
pmoreau has quit [reticulum.oftc.net liquid.oftc.net]
Vin[m] has quit [reticulum.oftc.net liquid.oftc.net]
zzoon[m] has quit [reticulum.oftc.net liquid.oftc.net]
gnustomp[m] has quit [reticulum.oftc.net liquid.oftc.net]
gagallo7[m] has quit [reticulum.oftc.net liquid.oftc.net]
Anson[m] has quit [reticulum.oftc.net liquid.oftc.net]
cwfitzgerald[m] has quit [reticulum.oftc.net liquid.oftc.net]
atulu[m] has quit [reticulum.oftc.net liquid.oftc.net]
chivay has quit [reticulum.oftc.net liquid.oftc.net]
nielsdg has quit [reticulum.oftc.net liquid.oftc.net]
danylo has quit [reticulum.oftc.net liquid.oftc.net]
xerpi[m] has quit [reticulum.oftc.net liquid.oftc.net]
tintou has quit [reticulum.oftc.net liquid.oftc.net]
jenatali has quit [reticulum.oftc.net liquid.oftc.net]
mal has quit [reticulum.oftc.net liquid.oftc.net]
Namarrgon has quit [reticulum.oftc.net liquid.oftc.net]
dj-death has quit [reticulum.oftc.net liquid.oftc.net]
javierm has quit [reticulum.oftc.net liquid.oftc.net]
padovan has quit [reticulum.oftc.net liquid.oftc.net]
mwalle has quit [reticulum.oftc.net liquid.oftc.net]
Adrinael has quit [reticulum.oftc.net liquid.oftc.net]
markus has quit [reticulum.oftc.net liquid.oftc.net]
Stary has quit [reticulum.oftc.net liquid.oftc.net]
evadot has quit [reticulum.oftc.net liquid.oftc.net]
hatrix has quit [reticulum.oftc.net liquid.oftc.net]
Koniiiik has quit [reticulum.oftc.net liquid.oftc.net]
sigmaris has quit [reticulum.oftc.net liquid.oftc.net]
baryluk has quit [reticulum.oftc.net liquid.oftc.net]
adavy has quit [reticulum.oftc.net liquid.oftc.net]
ickle has quit [reticulum.oftc.net liquid.oftc.net]
pH5 has quit [reticulum.oftc.net liquid.oftc.net]
dottedmag has joined #dri-devel
ybogdano has joined #dri-devel
alatiera12 has joined #dri-devel
sravn has joined #dri-devel
Akari has joined #dri-devel
italove3 has joined #dri-devel
crabbedhaloablut has joined #dri-devel
YaLTeR[m] has joined #dri-devel
kgz has joined #dri-devel
pmoreau has joined #dri-devel
reactormonk[m] has joined #dri-devel
nielsdg has joined #dri-devel
Vin[m] has joined #dri-devel
zzoon[m] has joined #dri-devel
gnustomp[m] has joined #dri-devel
gagallo7[m] has joined #dri-devel
danylo has joined #dri-devel
cwfitzgerald[m] has joined #dri-devel
Anson[m] has joined #dri-devel
chivay has joined #dri-devel
atulu[m] has joined #dri-devel
mal has joined #dri-devel
jenatali has joined #dri-devel
Namarrgon has joined #dri-devel
gawin has joined #dri-devel
dj-death has joined #dri-devel
javierm has joined #dri-devel
mwalle has joined #dri-devel
padovan has joined #dri-devel
Adrinael has joined #dri-devel
markus has joined #dri-devel
Stary has joined #dri-devel
evadot has joined #dri-devel
pH5 has joined #dri-devel
adavy has joined #dri-devel
Koniiiik has joined #dri-devel
ickle has joined #dri-devel
baryluk has joined #dri-devel
sigmaris has joined #dri-devel
hatrix has joined #dri-devel
agx has joined #dri-devel
moony has joined #dri-devel
ced117 has joined #dri-devel
Prf_Jakob has joined #dri-devel
tintou has joined #dri-devel
alatiera1 has joined #dri-devel
Surkow|laptop has joined #dri-devel
yshui` has joined #dri-devel
lplc has joined #dri-devel
xerpi[m] has joined #dri-devel
halfline has joined #dri-devel
mriesch has joined #dri-devel
alatiera1 has quit [Ping timeout: 481 seconds]
nchery has quit [Remote host closed the connection]
gawin has quit []
haasn` has joined #dri-devel
haasn has quit [Ping timeout: 480 seconds]
hansg has quit [Quit: Leaving]
camus has quit []
danvet has quit [Ping timeout: 480 seconds]
Duke`` has quit [Ping timeout: 480 seconds]
ybogdano has quit [Read error: Connection reset by peer]
tarceri has quit [Read error: Connection reset by peer]
tarceri has joined #dri-devel
gouchi has quit [Remote host closed the connection]
mriesch has quit [Remote host closed the connection]
ybogdano has joined #dri-devel
mriesch has joined #dri-devel
ybogdano has quit [Read error: Connection reset by peer]
illwieckz has joined #dri-devel
agners has joined #dri-devel
agners has quit [Quit: WeeChat 3.3]
illwieckz has quit []
ybogdano has joined #dri-devel
pnowack has quit [Quit: pnowack]
illwieckz has joined #dri-devel
agners has joined #dri-devel
CME_ has quit []
tursulin has quit [Read error: Connection reset by peer]