<bamse>
right, but they do that on all the platforms
<konradybcio>
Good point
<bamse>
and i'm told by the linaro people working on this that it's not supposed to be done like that
<bamse>
might be that there's reasons to do it downstream...not sure
<konradybcio>
I can fix that in the next revision
<konradybcio>
Still gotta address Luca's pinctrl review
cmeerw_ has joined #linux-msm
Daanct12 has quit [Remote host closed the connection]
Daanct12 has joined #linux-msm
<Marijn[m]>
<konradybcio> "I think that's because I forgot..." <- Iirc that option doesn't exist, `--thread` is enabled by default and `--[no-]chain-reply-to` disabled by default making it so that every mail is sent `In-reply-to` (which caused recent weirdness around short series sent without cover letter, as everything is `In-reply-to` patch 1/x)
<Marijn[m]>
However I still intended to ask about a similar issue, maybe bamse knows: there's `--cc-cover` and `--to-cover` to send everything to the same to/cc as the cover letter (first patch), but is there also an inverse? When using `--cc-cmd` every patch but the cover letter (which isn't technically a patch anyway) gets the emails added, is there a way to collect this back into the cover-letter first?
<Marijn[m]>
The only solution I've seen so far is to use `--cc-cmd get_maintainer.pl yoursendfolder/*`, but that's pretty slow if you have many patches with `Fixes:` and really only need to run it once, since it's still executed for every patch
marvin24 has joined #linux-msm
marvin24_ has quit [Ping timeout: 480 seconds]
<calebccff>
hi, for some reason my kernel modules no longer have aliases since upgrading to 5.14 does anyone know how those are built?
pevik has quit [Ping timeout: 480 seconds]
cmeerw_ has quit [Ping timeout: 480 seconds]
ahalaney has quit [Remote host closed the connection]
<bamse>
Marijn[m]: my suggestion is that you drop all the magic stuff from send-email, use format-patch to spit patches into a directory per series, edit the patches and the coverletter (format-patch --cover-letter) add recipients to all the patches and then git sende-mail the directory
<bamse>
Marijn[m]: that gives you better control over the recipients and you can run e.g. checkpatch on the patch files
<Marijn[m]>
bamse that's exactly the workflow I use, minus the "add recipients" part. Though for now I generally use get_maintainer on the patch directory as a whole, add everyone as cc to the cover letter, and send with --cc-cover so that everyone who receives the cover letter also receives all the patches. That's probably not desired so --to/cc-cover should likely be dropped
<Marijn[m]>
I'm just looking for a convenient replacement of running get_maintainer over every patch individually, and collect everyone for just the cover letter. I assume there's already scripts in place that insert cc:/to: into patches, I just haven't looked for it
<bamse>
Marijn[m]: e.g. when i send series that are mixed dt and driver patches, i To: Rob Herring only on those that i actually need his review on and Cc him on the rest
<bamse>
Marijn[m]: same goes if the series goes across multiple subsystems
<bamse>
and yes, something that does a better job applying recipients across a series of patches would be nice
<bamse>
in particular things such as if you get review feedback on vN and want to Cc said person on N+1 you have to do that manually
<Marijn[m]>
bamse till now I've never addressed a maintainer directly, always the phone-devel list and everyone else on the side in cc. Seems to have worked thus far but might be nicer to use to: directly (maybe that's why the leds pattern repeat patch got ignored...), will update my workflow there. Maybe --to-cmd can be used as long as get_maintainer can be told to only spit out maintainer(s)
<Marijn[m]>
bamse as for applying these by hand to the cover letter, we need something better. For now I'm pasting emails from get_maintainer and using block-insert to prepend Cc:.... 😅
<steev>
sounds like it's time to send a patch to git :P
<Marijn[m]>
And yes, going back through mailboxes and old patches to pick up earlier cover letters (merge them with the current one from format-patch --cover-letter), rb/ab/tb, and ccs is a hassle. But I think send-mail picks those up from the body already?
<Marijn[m]>
steev yes, in particular it'd be nice if format-patch can take care of this, so that all auditing is left to the text editor and send-mail becomes an argument-less call
<bamse>
Marijn[m]: many people have their mail setup to filter out anything that doesn't have "To: me"...
<Marijn[m]>
(besides the glob to select a bunch of patches)
<bamse>
Marijn[m]: even with that i get too many emails...
<Marijn[m]>
Painful... Especially when interesting patches slip through
<Marijn[m]>
It's why I'm not subscribed to any of the lists but merely glance over the patchwork/lore pages - to see the patches without all the underlying discussion
<Marijn[m]>
bamse: I'll resend leds tomorrow, that ought to help - and update the rest of our team to take this into account too
<steev>
bamse: ah crud, should i have To'd you on the patch? i cc'd everyone on the v2