00:02 <Marijn[m]> calebccff: looks good on first sight... My next step would be to dump downstream PPS but I think you already confirmed that it works without the reset... So maybe some command for your panel is missing, a sleep or the ordering is wrong. But it still looks very much like dsc-related corruption

00:02 <calebccff> Marijn[m]: haven't confirmed sending the PPS without reset, i'll try that (I suspect PPS)

00:03 <Marijn[m]> jstultz: definitely, I wouldn't want to add something that's genetically usable by other platforms... But then not make them use it

00:04 <Marijn[m]> jstultz: not sure if I have the time to drive this effort though... But if we do there are more targets like the evdev vibrator hal

00:05 <Marijn[m]> calebccff: cool, meanwhile I'll have to catch up with sleep for real 😫

00:08 <calebccff> Marijn[m]: o/

00:44 <calebccff> downstream has a suuuuper handy thing in debugfs where it will dump DCS "command sets" for you, and they all work except the one for the PPS buffer which causes a null pointer exception

07:43 <Marijn[m]> calebccff: Ah, I hadn't even spotted that yet, I just added a `print_hex_dump(KERN_ERR, "DSC params:", DUMP_PREFIX_NONE, 16, 1, buf + 7, 128, false);` to the end of `dsi_dsc_create_pps_buf_cmd()` in our downstream dsi-staging / `techpack/display` clone