<JoelSelvaraj[m]>
bamse: I am not sure you received my comment on the Xiaomi Poco F1 EBBG support patch, bcoz the patch didnt quite land correctly in the mailing list. When u have time, kindly let me know which approach is preferable. I will rework and send v2 based on it. Here is the link to my comment/reply: https://patchwork.kernel.org/comment/24937828/
<bamse>
JoelSelvaraj[m]: it's not awesome, but i am okay with you renaming the dts as well; so i think option 2 + a rename
<bamse>
JoelSelvaraj[m]: the main ask is to rename dts -> dtsi and add introduce a dts that includes the dtsi
<bamse>
JoelSelvaraj[m]: perhaps you can do that first, then have a commit that renames the dts and then add the new board?
<bamse>
JoelSelvaraj[m]: that way when people question where the file went there's a single commit explaining why you renamed the dts
<JoelSelvaraj[m]>
bamse: maybe i will rename sdm845-xiaomi-beryllium.dts to sdm845-xiaomi-beryllium-tianma.dts. instead of dtsi directly. explain the renaming, adjust the makefile. Then in separate commits, i ll move the common bits to a new dtsi and introduce ebbg variant support. Sounds fine?
<bamse>
JoelSelvaraj[m]: that sounds fine with me
<bamse>
JoelSelvaraj[m]: i hope that git will interpret the move of the common pieces as a rename still, as that makes it easier to review
<bamse>
and shows that it really was just a move
<bamse>
but do that and we'll see how it turns out
<JoelSelvaraj[m]>
bamse: since the tianma dts will retain the touchscreen and display bits, i dont think it will be considered a rename? mostly it will would like a bunch of stuffs removed from tianma dts and a new dtsi file with those removed content? in that case it will be little hard to review. bcoz i would have to also generalize the display node.... but its not huge discrepancy. i will be adding a label for the display node and remove the
<JoelSelvaraj[m]>
compatible property. Anyways, i ll send a v2 and we will see how it looks and we can improve upon that.
<bamse>
ahh okay
pespin has quit [Remote host closed the connection]
<Marijn[m]>
Joel Selvaraj: Is the panel also using a resistor (something something adc) to identify itself? We need that on Sony devices as well, maybe better to just get it over with if mangling the dts to come with this is such a nontrivial/undesirable situation
<Marijn[m]>
s/come/cope
flto_ has joined #linux-msm
flto has quit [Ping timeout: 480 seconds]
flto_ has quit []
flto has joined #linux-msm
<Mis012[m]>
Marijn: imho there should be a framework akin to the mux one, where one of several nodes is considered "active" based on external signal
<Mis012[m]>
so ADC, a group of gpios used to read a binary number...
<Mis012[m]>
technically there should be an API for managing overlays in the kernel if that turns out to be the sanest option