08:39 <gediz0x539> megi: hi, is it still necessary to append "fw_devlink=permissive" to bootargs after applying "of: property: fw_devlink: Support allwinner,sram links" patch on 5.13?

11:05 <hlauer> I have a small patch to A20 i2c controller at https://bitbucket.org/hlauer/kernel/src/master/patches/i2c-buslock.patchl,

11:07 <hlauer> which will dump the register contaning the state of SCL/SDA when i2c is locked. Any suggestions for ifdefs needed to include into kernel code?

11:08 <apritzel> hlauer: ifdefs? for what? #ifdef's in C files are highly frowned upon in Linux

11:11 <hlauer> I have no idea if the original hardware have this register. What's the preferred way then?

11:13 <apritzel> but then an ifdef won't solve this, because the same driver can run on Allwinner and the original Marvell controller

11:17 <megi> gediz0x539: you don't need to apply anything anymore

11:21 <apritzel> hlauer: I guess this should go through mv64xxx_i2c_regs_sun4i then?

11:23 <apritzel> hlauer: you could try to contact the driver maintainer or people with access to Armada datasheets, to find the LCR register there

12:55 <gediz0x539> megi: since 5.14?

13:57 <hlauer> apritzel: will look into mv64xxx_i2c_regs_sun4i then. Thanks for the hint

14:18 <apritzel> hlauer: it's a bit nasty for this kind of debug patch to add more code to filter for Allwinner vs. Marvell, so if you can find the LCR register address in the Armadas, that would be much cleaner

16:08 <MoeIcenowy> apritzel: BTW I have some leaked document of the original IP core

16:08 <MoeIcenowy> the register map of Allwinner one is the original

16:08 <MoeIcenowy> and the Marvell one is shuffled

16:11 <apritzel> lol

16:12 <apritzel> MoeIcenowy: can you check where the LCR register is for Marvell? it's 0x20 for Allwinner, apparently

16:12 <MoeIcenowy> I have no Marvell manual

16:13 <MoeIcenowy> but I think Marvell document should be somewhere

16:35 <apritzel> mripard: I guess Bootlin guys have Marvell Armada manuals? To check the I2C controller register map? Can you name a contact to ask about this?

16:36 <mripard> I think there was a few links to datasheet in the kernel doc?

16:37 <mripard> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/arm/marvell.rst

16:38 <mripard> otherwise paul might help, but he doesn't seem to be around since the Freenode Exodus

16:43 <apritzel> mripard: ah, many thanks! did

16:43 <apritzel> didn't know they were available, I was somehow under the impression that Marvell SoC docs were hard to come by ...

18:45 <megi> gediz0x539: 5.13

21:38 <apritzel> hlauer: I scanned most of the Marvell documents mripard linked above, but none of them mention an LCR register :-(

22:39 <hlauer> apritzel,mripard: Many thanks for looking. So LCR (meaning somthing like LineControlRegister) is probably A20 specific

22:49 <apritzel> looks like it, but it's probably Allwinner specific, not only A20 (I see it on later SoCs as well)