07:35
<
lanik123[m] >
s/qcom/Qcom/, s/on/in/
13:36
f_ has quit [Ping timeout: 480 seconds]
15:54
f_ has joined #msm8937-mainline
21:40
<
lanik123[m] >
Display is now working on santoni
22:01
<
jojo_autoboy[m] >
why fork?
22:01
<
barni2000[m] >
sound should not be so hard
22:02
<
barni2000[m] >
because our kernel is not in sync with msm8916 completely
22:02
<
jojo_autoboy[m] >
well does that affect the panel drivers at least>
22:02
<
hacker420[m] >
I don't think forking makes much sense
22:02
<
jojo_autoboy[m] >
s/>/?/
22:02
<
barni2000[m] >
and panel configs easier to maintain in this community
22:03
<
jojo_autoboy[m] >
ive used panel drivers generated from the 8916 tool on very much not 8916 devices with 0 issues
22:03
<
hacker420[m] >
except let's also not keep around pointless forks
22:03
<
barni2000[m] >
fork, delete every msm8916 device and add ours
22:03
<
hacker420[m] >
but why
22:03
<
jojo_autoboy[m] >
for panel drivers that doesn't make much sense
22:03
<
hacker420[m] >
what harm would we have in upstreaming the driver
22:03
<
jojo_autoboy[m] >
yeah
22:03
<
barni2000[m] >
because sometime you want to regenerate the panel drivers
22:04
<
barni2000[m] >
and don't want to add panels related to msm8916
22:04
<
hacker420[m] >
then just disable the ones you don't need?
22:04
<
jojo_autoboy[m] >
panel drivers aren't tied to soc
22:04
<
hacker420[m] >
exactly
22:04
<
barni2000[m] >
but there is a script which generate the panel drivers for the every device
22:04
<
jojo_autoboy[m] >
you can take a 8916 panel driver and use it on a non qcom
22:05
<
hacker420[m] >
barni2000[m]: yes and?
22:05
<
hacker420[m] >
it isn't tied to 8916
22:05
<
barni2000[m] >
almost every device has a different panel it related to the devices
22:05
<
hacker420[m] >
I don't see your point tbh
22:06
<
jojo_autoboy[m] >
panel drivers can be shared too
22:06
<
jojo_autoboy[m] >
barni2000[m]: gosh dang it
22:06
<
M0xCAFEBABE[m] >
hacker420[m]: +1, doesn't seem to have any valid reason to make a fork
22:06
<
hacker420[m] >
barni2000[m]: but why
22:07
<
hacker420[m] >
the drivers don't change between SoCs
22:07
<
barni2000[m] >
we don't fork the generator only the configs repo
22:07
<
barni2000[m] >
there are not too much common panel in use
22:07
<
lanik123[m] >
<barni2000[m]> "btw i think we should fork..." <- For what? Add our panels dtb into it and automate generation of panels?
22:08
<
barni2000[m] >
the repo contains every device dt
22:08
<
barni2000[m] >
* the repo contains dt of the devices
22:08
<
f_ >
Too much [m] matrix users
22:08
<
f_ >
Feels good to be the only one using IRC. -j
22:08
<
barni2000[m] >
lanik123[m]: yes, semi-automate
22:08
<
hacker420[m] >
f_: eh
22:09
<
hacker420[m] >
this isn't some competition
22:09
<
jojo_autoboy[m] >
perhaps we should like discuss this with whoever owns the 8916 repos on if non 8916 devices can be put in it too
22:09
<
f_ >
Danct12: Perhaps put that to the topic though?
22:09
<
hacker420[m] >
jojo_autoboy[m]: yeah
22:09
<
f_ >
hacker420[m]: I never said it was.
22:09
<
hacker420[m] >
poke minecrell[m]
22:10
<
jojo_autoboy[m] >
i say it should be a nice singular repo for any qcom device
22:10
<
barni2000[m] >
btw for msm8953 we should do some changes in panel-driver generator also but as you feel we could add the devices to the msm8916 repo also but i think it much cleaner keep it separately
22:10
<
f_ >
Danct12: Something like "| Bridged to #msm8937-mainline:kde.org" on IRC and "| Bridged to #msm8937-mainline on irc.oftc.net" should do.
22:10
<
hacker420[m] >
well the ideal solution would be to upstream them all
22:10
<
f_ >
^ hacker420[m]
22:10
<
jojo_autoboy[m] >
well yeah
22:10
<
barni2000[m] >
hacker420[m]: not a chance for them
22:11
<
hacker420[m] >
barni2000[m]: so what
22:11
<
barni2000[m] >
i wish for a generalized driver what can use some config
22:11
<
hacker420[m] >
will we just keep these rotting in a fork?
22:11
<
hacker420[m] >
this isn't sustainable long term
22:12
<
barni2000[m] >
the panel driver generator is a submodule and maintained by msm8916 so not a problem
22:12
<
jojo_autoboy[m] >
it's still kinda a gray area on if generated drivers can enter mainline
22:12
<
hacker420[m] >
jojo_autoboy[m]: yes
22:12
<
hacker420[m] >
this question would be better suited for mainline kernel maintainers
22:12
<
barni2000[m] >
they cannot be upstreamed because every driver needs a maintainer
22:13
<
barni2000[m] >
you don't want to maintain 100 panel drivers
22:13
<
hacker420[m] >
yeah felt something was off
22:13
<
f_[mtrx] >
Alright, thanks :)
22:13
<
hacker420[m] >
barni2000[m]: ofc
22:13
<
f_[mtrx] >
Just have to wait for Danct12 to do the same on IRC side.
22:13
<
hacker420[m] >
but you don't want these sitting in a fork either
22:14
<
barni2000[m] >
every community do the same
22:14
<
jojo_autoboy[m] >
or at least have one big singular fork instead of a bunch of soc specific ones
22:14
<
hacker420[m] >
ok but does it mean you have to replicate what they do?
22:14
<
hacker420[m] >
exactly
22:14
<
hacker420[m] >
have a SoC specific one
22:14
<
hacker420[m] >
not 2 billion ones for every SoC
22:14
<
f_[mtrx] >
hacker420 wish to also have an online chatlog link too?
22:14
<
barni2000[m] >
these stuff is not hard to maintain
22:14
<
hacker420[m] >
that turns into downstream mess really quick
22:15
<
barni2000[m] >
msm8953 has about 200-300 not upstreamed commit many of them cannot be upstreamed
22:16
<
hacker420[m] >
barni2000[m]: yes
22:16
<
hacker420[m] >
there are some things you can't upstream
22:16
<
barni2000[m] >
that is the sad reality
22:16
<
hacker420[m] >
doesn't mean we shouldn't strive to upstream what we can
22:16
<
f_[mtrx] >
Anyway, cool!
22:16
<
barni2000[m] >
we should upstream everything what we can and worth it
22:17
<
barni2000[m] >
panel drivers are not worth to upstream (yet)
22:17
<
f_ >
^ Danct12 Danct12[m]
22:17
<
hacker420[m] >
barni2000[m]: then at least let's have one panel driver fork
22:17
<
hacker420[m] >
not one for every SoC family
22:18
<
barni2000[m] >
as is said almost every soc forking the config repo
22:18
<
barni2000[m] >
s/is/I/
22:18
<
hacker420[m] >
well yes we know what IS happening
22:18
<
hacker420[m] >
question is why
22:19
<
barni2000[m] >
because they store the dts for the panels
22:19
<
jojo_autoboy[m] >
instead of following in their steps perhaps we should like fix this issue
22:19
<
hacker420[m] >
jojo_autoboy[m]: yes
22:19
<
jojo_autoboy[m] >
tbh already the panel driver generator being under the 8916 org is a bit meh
22:19
<
hacker420[m] >
the way it's done now just seems like a big mes
22:19
<
barni2000[m] >
other approach we should merger everything with msm8916-mainline
22:19
<
hacker420[m] >
s/mes/mess/
22:20
<
barni2000[m] >
kernel also
22:20
<
hacker420[m] >
thing is
22:20
<
hacker420[m] >
I feel there likely are too many quirks to do that cleanly
22:21
<
jojo_autoboy[m] >
i mean it worked with the 8939 but not sure if the 8937 is too different to be under the same thing
22:21
<
barni2000[m] >
these two repo worth to fork in our scope i think (panel-configs and ucm)
22:21
<
hacker420[m] >
Wait
22:21
<
hacker420[m] >
why UCM though
22:21
<
barni2000[m] >
lk2nd stuff could be upstreamed when the new is released
22:22
<
hacker420[m] >
they don't store blobs
22:22
<
barni2000[m] >
hacker420[m]: for the device specific configuration
22:22
<
hacker420[m] >
at least there was some point to keeping things separate when blobs are involved
22:22
<
hacker420[m] >
barni2000[m]: ok but then why keep every device specific config in specific SoC repos
22:23
<
barni2000[m] >
every device should have own config with shared HiFi.confs
22:23
<
barni2000[m] >
hacker420[m]: easier to maintain the ucm configurations together
22:24
<
barni2000[m] >
for msm8916 and msm8953 there is a soc package what is handles shared configs and ucm
22:27
<
hacker420[m] >
yes there I can understand separation
22:28
<
barni2000[m] >
btw ucm is related to the kernel
22:29
<
barni2000[m] >
in the past msm8916 do some downstream changes what needed some ucm changes but msm8953 kernel doesn't contained those changes and jack control was broken
22:29
<
barni2000[m] >
so ucm should be in sync whit our kernel
22:32
<
hacker420[m] >
lanik123: was panel tested on 8937?
22:34
<
hacker420[m] >
guess 8940 is close enough?
22:34
<
hacker420[m] >
should maybe test on cedric tomorror
22:34
<
hacker420[m] >
s/tomorror/tomorrow/
22:35
<
barni2000[m] >
difference is the modem and it uses higher clock afaik
22:35
<
lanik123[m] >
hacker420[m]: If 8940 works, then 8937 works too
22:35
<
hacker420[m] >
good
22:37
<
jojo_autoboy[m] >
i should try on my land
22:37
<
jojo_autoboy[m] >
oh gosh dang it it was already one
22:38
<
jojo_autoboy[m] >
s/one/done/
22:38
<
hacker420[m] >
lanik123[m]: so that land dts has a working panel?
22:38
<
jojo_autoboy[m] >
oh wait that's the old kernel
22:39
<
jojo_autoboy[m] >
i guess these dts should be upstreamed
22:39
<
lanik123[m] >
hacker420[m]: Depends on what panel you have
22:39
<
hacker420[m] >
well ofc it won't work with land's panel
22:39
<
jojo_autoboy[m] >
* be upstreamed to our fork
22:39
<
hacker420[m] >
I have a tianma panel
22:40
<
jojo_autoboy[m] >
hacker420[m]: what?
22:40
<
jojo_autoboy[m] >
why?
22:40
<
barni2000[m] >
hacker420[m]: lk2nd
22:40
<
hacker420[m] >
I meant on cedric
22:40
<
jojo_autoboy[m] >
ah
22:40
<
hacker420[m] >
barni2000[m]: hm?
22:40
<
barni2000[m] >
hacker420[m]: nvm
22:41
<
barni2000[m] >
i will check land with my dt
22:41
<
M0xCAFEBABE[m] >
* btw, for prada it's better to redo dts with my new downstream dts as reference, it's more correct, or lemme do it when I have time
22:42
<
jojo_autoboy[m] >
from what i can see land is very close to santoni (downstream calls it landtoni lol)
22:42
<
lanik123[m] >
hacker420[m]: lol, generate panel driver through panel generator with -r vsn -r vsp params
22:42
<
lanik123[m] >
lanik123[m]: It's not difficult
22:43
<
jojo_autoboy[m] >
there's support for the vsn/vsp regs now?
22:43
<
M0xCAFEBABE[m] >
jojo_autoboy[m]: it's the name which I gave to land&santoni back in 2021 XD, now I don't use it anymore, it's cringe
22:43
<
hacker420[m] >
lanik123[m]: yeah I know
22:43
<
jojo_autoboy[m] >
M0xCAFEBABE[m]: oh lmao
22:43
<
M0xCAFEBABE[m] >
M0xCAFEBABE[m]: because I used to unify those 2 devices
22:43
<
M0xCAFEBABE[m] >
* 2 devices (now all 7 devices)
22:43
<
lanik123[m] >
jojo_autoboy[m]: It always been
22:43
<
hacker420[m] >
how do I check if I need that, downstream?
22:43
<
hacker420[m] >
* &dsi_phy0 {
22:43
<
hacker420[m] >
qcom,dsi-phy-regulator-ldo-mode;
22:44
<
jojo_autoboy[m] >
M0xCAFEBABE[m]: ah so all of them are almost the same?
22:44
<
jojo_autoboy[m] >
such a xiaomi move
22:44
<
M0xCAFEBABE[m] >
jojo_autoboy[m]: * basically same, because they're designed by the same ODM
22:44
<
M0xCAFEBABE[m] >
s/*//
22:44
<
jojo_autoboy[m] >
reminds me of the miatoll situation
22:45
<
jojo_autoboy[m] >
difference is they are literally the same exact phone with like 5 diffrent names
22:45
<
jojo_autoboy[m] >
s/diffrent/different/
22:45
<
hacker420[m] >
wait where is that defined? `&mdss_dsi_active`
22:45
<
lanik123[m] >
hacker420[m]: If I'm not mistaken, all 8917/8937/8940 devices use this option
22:46
<
lanik123[m] >
lanik123[m]: It's specefied it mdss dts
22:46
<
hacker420[m] >
lanik123[m]: then why doesn't prada have it?
22:46
<
lanik123[m] >
s/it/in/
22:46
<
M0xCAFEBABE[m] >
jojo_autoboy[m]: wait, you were referring to 7 devices right? 3 different ODMs then
22:47
<
lanik123[m] >
hacker420[m]: Good question)))))))))
22:47
<
M0xCAFEBABE[m] >
M0xCAFEBABE[m]: ugg/ugglite: Longcheer, prada: FIH, rest: Wingtech
22:47
<
jojo_autoboy[m] >
oh
22:48
<
M0xCAFEBABE[m] >
M0xCAFEBABE[m]: one more thing, apparently devices from the same ODM shares the same BSP, only except for land
22:48
<
barni2000[m] >
yes but riva and rolex using different fg and charging ic, land santoni using pmi8950-charger
22:48
<
M0xCAFEBABE[m] >
* more thing, in mi8937 devices, apparently devices
22:48
<
jojo_autoboy[m] >
fun
22:49
<
barni2000[m] >
land and santoni are easy to support other will have issues
22:49
<
barni2000[m] >
s/other/others/
22:49
<
jojo_autoboy[m] >
oh nvm
22:49
<
jojo_autoboy[m] >
nice
22:50
<
barni2000[m] >
btw riva is wingtech ugglite is longcheer but they are very similar
22:51
<
M0xCAFEBABE[m] >
barni2000[m]: well, I'd rather say ugg&ugglite are similar
22:51
<
barni2000[m] >
M0xCAFEBABE[m]: yes i know
22:51
<
barni2000[m] >
i have both of them
22:51
<
M0xCAFEBABE[m] >
the only similar part between ugglite&riva is the SoC and charging chips (charging chips are the same for ugg too)
22:51
<
barni2000[m] >
M0xCAFEBABE[m]: and led
22:52
<
M0xCAFEBABE[m] >
barni2000[m]: aw2013 is veryyyyyy common on ximi msm8937/53 devices
22:52
<
lanik123[m] >
lanik123[m]: I do not recommend specify driver for the wled and specifying regulators in the DTS now. This causes mdp delayed probe
22:54
<
lanik123[m] >
lanik123[m]: This is how node for panel should look like
22:54
<
barni2000[m] >
btw you can try dpu
22:54
<
lanik123[m] >
barni2000[m]: No no no no
22:54
<
lanik123[m] >
lanik123[m]: Forget about it
22:54
<
lanik123[m] >
It cursed
22:55
<
barni2000[m] >
mdp5 is cursed
22:55
<
barni2000[m] >
dpu is maintained
22:55
<
hacker420[m] >
lanik123[m]: alright
22:55
<
barni2000[m] >
but there is no upstream support yet for msm8917/msm8937
22:56
<
lanik123[m] >
barni2000[m]: mdp4 is cursed, mdp5 beautiful compared to him
22:56
<
hacker420[m] >
lanik123[m]: you know what I feel will be more cursed
22:56
<
hacker420[m] >
the sensorhub shit lenovorola used
22:56
<
hacker420[m] >
wonder if potter has the same thing
22:57
<
barni2000[m] >
lanik123[m]: i have tested dpu on msm8953 it works much better for me
22:57
<
barni2000[m] >
it solves many display issue
22:57
<
barni2000[m] >
* it has solved many display issue
22:58
<
lanik123[m] >
barni2000[m]: Hmmm, If dpu supports 8953 then it's not a big problem to add 8917 and 8937
22:59
<
barni2000[m] >
linaro guys are working on it
22:59
<
lanik123[m] >
barni2000[m]: Wow
22:59
<
barni2000[m] >
but it has some dependency on other patchsets and it not upstreamd yet because of cmd panels
23:00
<
hacker420[m] >
lanik123[m]: it already has 8937
23:00
<
hacker420[m] >
very nice
23:01
<
barni2000[m] >
yes, i think we could help with the testing if they resending the patches in the future
23:06
<
hacker420[m] >
that looks right?
23:07
<
hacker420[m] >
what do I put in the panel compatibles
23:07
<
hacker420[m] >
leave them as is?
23:07
<
hacker420[m] >
or just remember to put that in dts
23:09
<
hacker420[m] >
lanik123[m]: so put this in
23:09
<
hacker420[m] >
<lanik123[m]> "It's specefied it mdss dts..." <- I don't have a mdss dts in downstream
23:10
<
lanik123[m] >
Lol what
23:10
<
lanik123[m] >
hacker420[m]: So it's not need for you
23:11
<
barni2000[m] >
at msm8953 we add device name also as a prefix for the generated panels
23:12
<
barni2000[m] >
[boe_hx8394f_720p_video]="xiaomi,onclite-hx8394f" second part will be the compatible btw
23:15
<
barni2000[m] >
i wonder is montana using the same panel what cedric?
23:18
<
barni2000[m] >
#include "dsi-panel-mot-tianma-521-1080p-video.dtsi"
23:18
<
barni2000[m] >
#include "dsi-panel-mot-inx-521-1080p-video.dtsi"
23:19
<
barni2000[m] >
it seems not
23:19
<
barni2000[m] >
#include "dsi-panel-mot-tianma-497-1080p-video.dtsi"
23:19
<
barni2000[m] >
#include "dsi-panel-mot-inx-497-1080p-video.dtsi"
23:28
<
hacker420[m] >
Error: ../arch/arm64/boot/dts/qcom/msm8937-motorola-cedric.dts:27.2-17 syntax error
23:28
<
hacker420[m] >
FATAL ERROR: Unable to parse input tree
23:29
<
hacker420[m] >
fuck I hate how unhelpful the dts parser is when you have a syntax error
23:30
<
hacker420[m] >
OT: amazing thing to queue up on yt right as I started messing with the DTS
23:41
<
barni2000[m] >
in the line 27
23:41
<
barni2000[m] >
or before
23:47
<
hacker420[m] >
hm let me make it more similar to land's dts formatting
23:54
<
hacker420[m] >
what
23:57
<
hacker420[m] >
Ah wait
23:57
<
hacker420[m] >
put in .c instead of .o in makefile
23:58
<
barni2000[m] >
the panel driver generator makes a commit if you execute from the kernel repo root
23:58
<
barni2000[m] >
and it modifies everything afaik