03:58 <hays> hello all. just joining to keep track how things are going. interested to be an early tester. posted more about myself in #dri-devel

14:52 <alyssa> q4a: The set of allowed swizzles on Valhall are defined for each source in valhall/ISA.xml

14:52 <alyssa> Looking at the XML of FMA_RSCALE.f32, no swizzle is allowed for any source

14:53 <alyssa> So the last source there needs to load a full 32-bit value as-is

14:53 <alyssa> the `bi_byte(..., 0)` is not encodable;

14:58 <alyssa> va_lower_constants handles these details for small constants -- it will only try to use a given swizzle [ like "replicate byte 0" aka bi_byte(..., 0) ] if the specific source in the specific instruction actually supports that specific swizzle

14:59 <alyssa> The sources are 32-bit data paths internally, there aren't special 8-bit or 16-bit sources

15:02 <q4a> Thx. I read `va_lower_constants.c` and test it a bit: `bi_imm_u8(24)` lowering to bi_byte(va_lut(14), 0)