17:24 <bamse> steev: pushed my c630 branch to github, wip/c630-next-20210923

17:25 <steev> oh spiffy

17:25 <steev> shawnguo0: ^^ new shinies

17:25 <bamse> steev: same old, just polished it a little bit ;)

17:26 <steev> ah i think it's fb67e1848c87b5f3baeda8d3e03c92d996fabcd6 we were missing

17:27 <steev> hm

17:27 <steev> now i'm curious if that happens in windows as well

17:27 <steev> e.g. if the display turns off does the camera also

18:00 <steev> https://github.com/aarch64-laptops/linux/commit/5ba59b7426438e5fd307b12c44da2d727e1ec115

18:00 <steev> bamse: what about/of the other misc patches that aarch64-laptops applies that haven't gone upstream at all? I'm thinking of (mainly)- https://github.com/aarch64-laptops/linux/commit/fa88cef6a020cb45103418f432a845964e2ea761 https://github.com/aarch64-laptops/linux/commit/0f2466b947f8a1f7b7e975a22daee6a51fab8ae4 https://github.com/aarch64-laptops/linux/commit/e2ccb79c7095f8ca406788c5792bbb19986e4208

19:14 <bamse> steev: it would be really nice to know what windows does wrt the camera

19:15 <bamse> steev: because the way i have it wired up now, the backlight controls what i thought was the backlight regulator...but that seems to also power the camera

19:16 <bamse> steev: regarding your 4 patches...i was in favor of picking up Shawn's gpio rename, but i think the others objected...

19:16 <bamse> steev: i think you should drop it from your pile either way, it doesn't carry any functional "value"

19:17 <bamse> steev: the "max-brightness" was used when the bridge was the backlight, but now it just exposes a pwm_chip, and we have the separate pwm-backlight node...so that patch doesn't do anything anymore, so please drop it

19:19 <bamse> steev: i don't have the vcca/vcc regulator patch in my tree...it might be the correct thing to have, i'll have to see what the schematics says (and figured out it that's applicable)

19:20 <bamse> steev: the last one is reasonable, but i don't think the commit message iscorrect...perhaps you have some more patches related to regulators or handover from the bootloader?

19:21 <robclark> AFAIU camera regulator or enabling gpio w/ backlight isn't that crazy.. it's a thing hw designers will do when they run out of gpio's (since why would you have the camera on without the screen on)

19:22 <broonie> Or sometimes it saves adding more regulators to share so why not?

19:22 <bamse> broonie: they have enough to get a discount already ;)

19:23 <bamse> robclark: agreed, but i'll double check my findings when i try to figure out the purpose of the additional regulators that i apparently lost from my initial patchsets

19:24 <broonie> Also saves the routing of supplies/signals too, might be an issue if going over the hinge or whatever.

21:58 <robclark> bamse, dianders: btw, have you noticed this bridge vs i2c splat on shutdown?

21:58 <robclark> https://www.irccloud.com/pastebin/buUuj53t/

22:00 <bamse> robclark: i have not, but it sounds similar to what was discussed in a i2c/shutdown thread earlier this year

22:00 <bamse> robclark: iirc sboyd was looking at it...or at least reviewing some patches related to it

22:00 <robclark> actually, does console-ramoops work on the windows laptops? I guess it might be kinda hard for you to notice otherwise

22:01 <bamse> robclark: ahh right, i don't have uart on that one...then i don't know

22:01 <bamse> robclark: i should however see if ramoops does work, because that would be really convenient

22:01 <robclark> if a kernel splats in the woods...

22:01 <robclark> yeah