10:37 <marcan> ah, cool

10:38 <marcan> also I just pushed a change to the firmware extractor to also copy txcap_blob files; they are not used yet but will be soon

10:38 <marcan> not entirely sure what they do, but it sounds important :p

10:38 <marcan> also, we need to forward the wifi calibration blob from ADT to DT; I just realized what that is, it's the calibration that's in SROM on x86 machines, so again presumably it matters

10:43 <marcan> heh, I just found this in that broadcom android driver

10:43 <marcan> extern int dhdpcie_get_fwpath_otp(dhd_bus_t *bus, char *fw_path, char *nv_path,

10:43 <marcan> char *clm_path, char *txcap_path);

10:43 <marcan> that's not actually defined nor used

10:43 <marcan> there's also references to txcap which are stubbed out

10:43 <marcan> ... this clearly was intended to do things the Apple Way at some point, then they censored it before releasing...

11:00 <kettenis> might be worth pushing what you have forward first, to get an idea how the driver maintainers like this apple-specific way of handling firmware...

11:12 <marcan> kettenis: the txcap stuff needs a minor refactor of one patch and isn't much on top; the calibration isn't much more either

11:12 <marcan> might as well add those two patches to the initial submission

11:19 <kettenis> heh, if you've already figured out how it works...

11:28 <kettenis> btw, related to the SMC, we need to figure out how power down actually works on these machines

11:29 <kettenis> the corellium code scribbless some seemingly random bits into the SPMI PMU

11:29 <kettenis> this makes no sense to me

17:41 <marcan> kettenis: pushed wifi/take5 with the TxCap and calibration blob stuff (goes along with a m1n1 patch and a firmware extractor patch)

17:42 <marcan> the T2 folks have managed to test take4 on all the chips I added support for, so I think this is reasonably in shape for an upstream RFC

17:44 <marcan> (well, needs DT bindings as usual :p)

17:45 <marcan> I called the props apple,module-instance; apple,antenna-sku; brcm,cal-blob (the idea being that the cal blob isn't really apple-specific in nature, though chances are only they use that mechanism, while the other two are related to the funky Apple firmware selection and are definitely Apple-specific)