ndut2 has quit [Read error: Connection reset by peer]
Telvana has quit [Read error: Connection reset by peer]
Telvana has joined #asahi-dev
ndut2 has joined #asahi-dev
ndut2 was kicked from #asahi-dev by ChanServ [You are not permitted on this channel]
ndut2 has quit [autokilled: This host violated network policy and has been banned. Mail support@oftc.net if you think this is in error. (2022-02-27 01:46:25)]
sirn- has joined #asahi-dev
sirn has quit [Read error: Connection reset by peer]
sirn- is now known as sirn
phiologe has joined #asahi-dev
PhilippvK has quit [Ping timeout: 480 seconds]
Rabbitz has joined #asahi-dev
kov has quit [Quit: Coyote finally caught me]
kov has joined #asahi-dev
* Rabbitz
hi anyone wanna code something together ? may be we can meet at channnel #rabbithacker
Rabbitz has quit [autokilled: This host violated network policy and has been banned. Mail support@oftc.net if you think this is in error. (2022-02-27 04:38:09)]
bisko has quit [Read error: Connection reset by peer]
NekomimiScience has quit [Server closed connection]
NekomimiScience has joined #asahi-dev
___nick___ has joined #asahi-dev
___nick___ has quit []
___nick___ has joined #asahi-dev
tpw_rules has quit [Server closed connection]
tpw_rules has joined #asahi-dev
the_lanetly_052 has quit [Ping timeout: 480 seconds]
cyrozap has quit [Server closed connection]
cyrozap has joined #asahi-dev
Lightsword has quit [Server closed connection]
Lightsword has joined #asahi-dev
rcombs has quit [Server closed connection]
rcombs has joined #asahi-dev
Method has quit [Server closed connection]
Method has joined #asahi-dev
krbtgt has quit [Server closed connection]
krbtgt has joined #asahi-dev
<marcan>
sven: what do you think about sending out a fixes patch to future-proof the disp0 DART stuff?
<marcan>
today, without a binding change, we could have the driver check the streams and refuse to probe if any are enabled (even in bypass), which honestly would qualify as a firmware bug in my book (does u-boot clear them?)
<kettenis>
The only thing u-boot does is place some of the DARTs in bypass mode.
<kettenis>
It probably should undo that, but it currently doesn't.
<marcan>
we could only bail if any streams are in non-bypass mode
<marcan>
under the argument that a bootloader smart enough to use non-bypass mode really should be cleaning up after itself
<marcan>
maybe just warn for bypass mode
<sven>
I think bailing when the TCR is set to translate is a good idea
<sven>
and a dev_warn for anything in bypass mode is probably useful too
<marcan>
firmware bug really
<sven>
yeah
<kettenis>
thanks ;)
<marcan>
wanna send the patch or should I?
<sven>
it should hand over the darts in a sane state ;)
<sven>
feel free to send something
<marcan>
ok
<kettenis>
note that this means that 5.17 will still break
<sven>
I don’t even remember what iboot does to the DARTs
<sven>
i think it hands over some in bypass mode
<kettenis>
(and 5.18 if the change doesn't make it into that)
<marcan>
I'll send it as stable
<marcan>
so it should be backported
<kettenis>
The alternative solution is to change the compatible for these display DARTs to something like apple,t8103-disp-dart
<kettenis>
and have the driver key off that
<marcan>
yeah, but... ew
<marcan>
I think we should have a property like apple,dart-handoff to tell the driver handoff is expected
<marcan>
so it still complains for darts that shouldn't handoff
<marcan>
but in the meantime, we should just bail if TCRs are set
bisko has quit [Read error: Connection reset by peer]
bisko has joined #asahi-dev
<kettenis>
note that robh has indicated a few times that using different compatibles is generally preferred over boolean properties like that
<kettenis>
(not that I necessarily agree with that)
<marcan>
for stuff that isn't a hardware difference like this?
<kettenis>
maybe not in that case
<kettenis>
FWIW, I'd like to see a property that indicates that mappings need to be preserved
<kettenis>
but I'll see if I can do the TCR check on OpenBSD as well
<alyssa>
wouldn't we all?
<jannau>
kettenis: I'm not sure we want to preserve all mappings. Thierry Reding proposed in https://lore.kernel.org/linux-iommu/YgPsVAsEcUYKHNIj@orome/ to add "mapped-devices" as a link back to the device. Used to read the pre-mapped regions from the device
<kettenis>
I guess that would work; the presence of the mapped-devices property would then indicate that we don't want to do a full reset of the DART I presume?
<kettenis>
But I suspect this will still take a bit of time to be worked into a formal binding...
<kettenis>
Guess the TCR check will buy us some time for that
<jannau>
that would be enough although I parse already the preserved mappings in dcp_probe
<sven>
marcan: when you’re working on that tcr patch feel free to also send one to merge the dart entries to the rest in MAINTAINERS
<marcan>
ah, sure
<sven>
I thought we already did that but apparently we just forgot :D
jbowen has quit [Server closed connection]
jbowen has joined #asahi-dev
bisko has quit [Read error: Connection reset by peer]
bisko has joined #asahi-dev
King_InuYasha has quit [Server closed connection]
King_InuYasha has joined #asahi-dev
<kettenis>
hmm, on the j274, 4 out of the 8 DARTs that are currently in the device tree have the translate enable bit set (for all of the streams)
<kettenis>
so adding a simple TCR check is not going to fly unless we have m1n1 sanitize the DARTs
nafod has quit [Server closed connection]
nafod has joined #asahi-dev
<sven>
what if we change that to “tcr translate enabled and any ttbr has the valid bit set”?
bisko has quit [Read error: Connection reset by peer]
bisko has joined #asahi-dev
<kettenis>
sven: that seems to work
<kettenis>
and verified that adding the nodes for disp_dart and dcp_dart has the expected effect
<kettenis>
apldart0 at simplebus0: translating
<kettenis>
apldart1 at simplebus0: locked
gladiac is now known as Guest718
gladiac has joined #asahi-dev
Guest718 has quit [Ping timeout: 480 seconds]
jkkm has quit [Server closed connection]
jkkm has joined #asahi-dev
<sven>
nice!
<sven>
so I guess it’s either that or clean up all darts in m1n1