ChanServ changed the topic of #dri-devel to: <ajax> nothing involved with X should ever be unable to find a bar
jsa has quit [Ping timeout: 480 seconds]
co1umbarius has joined #dri-devel
columbarius has quit [Ping timeout: 480 seconds]
rossy has quit [Remote host closed the connection]
rossy has joined #dri-devel
DragoonAethis has quit [Quit: hej-hej!]
DragoonAethis has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
flynnjiang has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
platypus has joined #dri-devel
flynnjiang1 has joined #dri-devel
mbrost_ has joined #dri-devel
flynnjiang has quit [Ping timeout: 480 seconds]
treasuryx has joined #dri-devel
treasuryx has quit [Read error: Connection reset by peer]
treasuryx has joined #dri-devel
Kayden has quit [Quit: restart nm]
platypus has quit [Remote host closed the connection]
Namarrgon has quit [Ping timeout: 480 seconds]
alane has quit []
alane has joined #dri-devel
Kayden has joined #dri-devel
yyds has joined #dri-devel
Namarrgon has joined #dri-devel
mbrost has joined #dri-devel
flynnjiang1 has quit [Remote host closed the connection]
mbrost_ has quit [Ping timeout: 480 seconds]
Calandracas_ has quit [Remote host closed the connection]
yyds has quit [Remote host closed the connection]
yyds has joined #dri-devel
kts has joined #dri-devel
Mangix has quit [Read error: Connection reset by peer]
Mangix has joined #dri-devel
valpackett has joined #dri-devel
epoch101 has quit [Quit: WeeChat 4.2.2]
epoch101 has joined #dri-devel
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
sassefa has joined #dri-devel
glennk has joined #dri-devel
<treasuryx>
<treasuryx> so it's quite simple for Bitcoin you generate random numbers and ask for collision from in format own generated number with blocks nodes in the Blockchain to see if servers rng did good job, that means only if collision is detected you need a new number, otherwise the occupancy does never matter. the rng technically would never fail if they were cheating like you in life, if
<treasuryx>
someday soon your balls will <treasuryx> be removed however. so you are pushing number of generated hashes to comparison through multibank accesses the single threaded mode already accommodates block size length of this you can not push to several blocks at the same time that way you would cause your own numbers to collide and .... validating yourself is not very intelligent thing to do, as
<treasuryx>
they were as <treasuryx> big as trash as you however. But you have to collect the response all the time, it's rpc but not internet in cpuminer so it is the bottleneck, can be recoded however number of threads in too aggressive modes, would cause random runaheads and you'd have no way of telling what to discard, remember that you are butchers not programmers you are alien butcher staff.
<treasuryx>
you give work to yourself where as you <treasuryx> never used rng in the first place so your numbers do not collide anyways. so even Bitcoin miner does not take advantage of multiple threads it's too simple model for it. vulkan compute shaders hence, pointless.
<MrCooper>
luc: it limits how many frames the CPU can run ahead of the GPU
jkrzyszt has joined #dri-devel
warpme has quit []
<luc>
MrCooper: if vblank is enabled, does it imply to throttling?
itoral has quit [Read error: Connection reset by peer]
<MrCooper>
not directly
<MrCooper>
with the same number of colour buffers in the rotation, sync-to-vblank makes the underlying issue worse, since it results in higher input→output latency
simon-perretta-img has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
<luc>
MrCooper: IIUC, it means even if vblank is enabled, we still have to do throttling for lower latency, doesn't it?
<MrCooper>
right
<luc>
thanks a lot
<MrCooper>
no worries
rasterman has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
warpme has joined #dri-devel
simon-perretta-img has joined #dri-devel
flynnjiang has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
warpme has quit []
flynnjiang has quit [Remote host closed the connection]
kts has joined #dri-devel
coldfeet has joined #dri-devel
simon-perretta-img has quit [Read error: Connection reset by peer]
simon-perretta-img has joined #dri-devel
pa has joined #dri-devel
f_ has joined #dri-devel
vliaskov has joined #dri-devel
vliaskov has quit [Remote host closed the connection]
vliaskov has joined #dri-devel
coldfeet has quit [Remote host closed the connection]
simon-perretta-img has quit [Read error: Connection reset by peer]
<sima>
pinchartl, did you look at the bridge hotplug proposal already?
<sima>
well especially the hotunplug part ...
<pinchartl>
sima: notyet. I suppose I should ? :-)
Calandracas has joined #dri-devel
heat has quit [Remote host closed the connection]
heat has joined #dri-devel
<pinchartl>
sima: what's your opinion on making connectors more dynamic, and allowing them to be created and removed at runtime ?
<emersion>
they already are
<emersion>
for DP-MST
<pinchartl>
indeed
guludo has joined #dri-devel
warpme has quit []
warpme has joined #dri-devel
jsa has quit [Ping timeout: 480 seconds]
Haaninjo has joined #dri-devel
simon-perretta-img has quit [Read error: No route to host]
simon-perretta-img has joined #dri-devel
treasuryx has quit [Remote host closed the connection]
jsa has joined #dri-devel
treasuryx has joined #dri-devel
<sima>
pinchartl, yeah that's my main take on this too, we should tie bridge hotplug a lot more to the connector
<sima>
since hotplug for that is already solved
<sima>
but it means that "who creates the connector" becomes even more fun for bridges ...
<pinchartl>
if we want bridges to become hot-pluggable resources, we need a way to signal bridges being removed, and we need drivers to react to that correctly
simon-perretta-img has quit [Ping timeout: 480 seconds]
<pinchartl>
we may need a complete redesign of the bridge attach/detach API
epoch101 has joined #dri-devel
warpme has quit []
simon-perretta-img has joined #dri-devel
heat has quit [Remote host closed the connection]
<mripard>
plus all the use after free issues I'm sure it would entail :)
heat has joined #dri-devel
<pinchartl>
mripard: yes, those come as an added bonus of course
<pinchartl>
you get them for free
simon-perretta-img has quit [Ping timeout: 480 seconds]
simon-perretta-img has joined #dri-devel
i-garrison has quit [Ping timeout: 480 seconds]
<sima>
pinchartl, yeah I think I'll just put that part as an open into my mail
<sima>
the patch set has a hotplug bridge to absorb some of the fun, but I think that needs to be lifted into shared code or it wont work all that well
<sima>
I'll focus more on the lifetime/locking fun
treasuryx has quit [Remote host closed the connection]
<pinchartl>
the "hotplug bridge" seems a bit of a hack :-S
fireburn has joined #dri-devel
simon-perretta-img has quit [Ping timeout: 480 seconds]
heat has quit [Remote host closed the connection]
heat has joined #dri-devel
simon-perretta-img has joined #dri-devel
<karolherbst>
mareko: I'm hitting the assert you added in 0e546fb6833dd178bb9f7889c82ae38e14dd868d sometimes when calling into clear_buffer
Mangix has quit [Read error: Connection reset by peer]
Mangix has joined #dri-devel
u-amarsh04 has quit []
fireburn has quit []
mbrost has joined #dri-devel
u-amarsh04 has joined #dri-devel
lstrano has joined #dri-devel
mbrost has quit [Read error: Connection reset by peer]
mbrost has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
tzimmermann has quit [Quit: Leaving]
sassefa has joined #dri-devel
sassefa has quit []
lynxeye has quit [Quit: Leaving.]
jsa has joined #dri-devel
Celmor[m] has joined #dri-devel
Wallbraker has joined #dri-devel
AlaaEmad[m] has joined #dri-devel
ajhalaney[m] has joined #dri-devel
Alex[m]12345678910111213 has joined #dri-devel
arisu has joined #dri-devel
anarsoul[m] has joined #dri-devel
AndreyKonovalov[m] has joined #dri-devel
Andy[m] has joined #dri-devel
aradhya7[m] has joined #dri-devel
Pierce[m] has joined #dri-devel
aura[m] has joined #dri-devel
bubblethink[m] has joined #dri-devel
bylaws1 has joined #dri-devel
chema has joined #dri-devel
cleverca22[m] has joined #dri-devel
cmeissl[m] has joined #dri-devel
Coelacanthus[m]1 has joined #dri-devel
alanc has quit [Remote host closed the connection]
colinmarc has joined #dri-devel
Eighth_Doctor has joined #dri-devel
alanc has joined #dri-devel
QiuWenbo[m] has joined #dri-devel
cwfitzgerald[m] has joined #dri-devel
dafna33[m] has joined #dri-devel
daissi has joined #dri-devel
daniliberman[m] has joined #dri-devel
dcbaker has joined #dri-devel
DemiMarie has joined #dri-devel
devarsht[m] has joined #dri-devel
devnull[m] has joined #dri-devel
Anson[m] has joined #dri-devel
dhirschfeld2[m] has joined #dri-devel
<DavidHeidelberg>
karolherbst: heya! I think about the freedreno+rusticl could be merged (at least for LLM it works), but I would maybe guard it somehow to prevent people accidentally using it ?
DrNick has joined #dri-devel
doras has joined #dri-devel
doraskayo has joined #dri-devel
danylo1 has joined #dri-devel
<DavidHeidelberg>
lumag: what do you think ^ ?
EricCurtin[m] has joined #dri-devel
egalli has joined #dri-devel
ella-0[m] has joined #dri-devel
Ella[m] has joined #dri-devel
eballetbo has joined #dri-devel
enunes[m] has joined #dri-devel
AlexisHernndezGuzmn[m] has joined #dri-devel
exp80[m] has joined #dri-devel
fililip[m] has joined #dri-devel
fkassabri[m] has joined #dri-devel
FL4SHK[m] has joined #dri-devel
FloGrauper[m] has joined #dri-devel
gallo[m] has joined #dri-devel
gdevi has joined #dri-devel
gegoxaren[m] has joined #dri-devel
general_j[m] has joined #dri-devel
gnustomp[m] has joined #dri-devel
Guest6572 has joined #dri-devel
Armote[m] has joined #dri-devel
MotiH[m] has joined #dri-devel
halfline[m] has joined #dri-devel
Harvey[m] has joined #dri-devel
hax0kartik[m] has joined #dri-devel
Hazematman has joined #dri-devel
hch12907 has joined #dri-devel
healfdanex[m] has joined #dri-devel
heftig has joined #dri-devel
Guest6410 has joined #dri-devel
Hi-Angel has joined #dri-devel
<karolherbst>
DavidHeidelberg: I mean.. there is still the env variable
zzoon[m] has joined #dri-devel
<karolherbst>
soo... nobody will use it unless they really want to anyway
ids1024[m] has joined #dri-devel
isinyaaa[m] has joined #dri-devel
jasuarez has joined #dri-devel
jenatali has joined #dri-devel
joantolo[m] has joined #dri-devel
JosExpsito[m] has joined #dri-devel
jtatz[m] has joined #dri-devel
K0bin[m] has joined #dri-devel
kallisti5[m] has joined #dri-devel
madhavpcm has joined #dri-devel
kerel has joined #dri-devel
kelbaz[m] has joined #dri-devel
koki23[m] has joined #dri-devel
kunal10710[m] has joined #dri-devel
kunal_10185[m] has joined #dri-devel
KunalAgarwal[m][m] has joined #dri-devel
kusma has joined #dri-devel
Labnan[m] has joined #dri-devel
LaughingMan[m] has joined #dri-devel
m00nlit[m] has joined #dri-devel
mairacanal[m] has joined #dri-devel
MarkCollins[m] has joined #dri-devel
marmarek[m] has joined #dri-devel
martix778777[m] has joined #dri-devel
masush5[m] has joined #dri-devel
matrix638[m] has joined #dri-devel
MayeulC has joined #dri-devel
Mershl[m] has joined #dri-devel
michael5050[m] has joined #dri-devel
jsa has quit [Ping timeout: 480 seconds]
Mis012[m] has joined #dri-devel
moben[m] has joined #dri-devel
Guest6573 has joined #dri-devel
msizanoen[m] has joined #dri-devel
Vin[m] has joined #dri-devel
naheemsays[m] has joined #dri-devel
neobrain[m] has joined #dri-devel
swivel has joined #dri-devel
Newbyte has joined #dri-devel
nick1343[m] has joined #dri-devel
nicofee[m] has joined #dri-devel
nielsdg has joined #dri-devel
nyorain[m] has joined #dri-devel
oeuaoeuoeu[m] has joined #dri-devel
ofirbitt[m] has joined #dri-devel
ohadsharabi[m] has joined #dri-devel
onox[m] has joined #dri-devel
orowith2os[m] has joined #dri-devel
pac85[m] has joined #dri-devel
swivel_ has quit [Ping timeout: 480 seconds]
pankart[m] has joined #dri-devel
<DavidHeidelberg>
right :)
pedrohlc[m] has joined #dri-devel
PiGLDN[m] has joined #dri-devel
Guest6632 has joined #dri-devel
pushqrdx[m] has joined #dri-devel
q4a has joined #dri-devel
Quinten[m] has joined #dri-devel
valida-69[m] has joined #dri-devel
raambm[m] has joined #dri-devel
ramacassis[m] has joined #dri-devel
ram15[m] has joined #dri-devel
reactormonk[m] has joined #dri-devel
robertmader[m] has joined #dri-devel
samueldr has joined #dri-devel
dabrain34[m] has joined #dri-devel
siddh has joined #dri-devel
sigmoidfunc[m] has joined #dri-devel
SintayewGashaw[m] has joined #dri-devel
sergi has joined #dri-devel
Sumera[m] has joined #dri-devel
gouchi has joined #dri-devel
swick[m] has joined #dri-devel
sythemeta847[m] has joined #dri-devel
knr has joined #dri-devel
T_UNIX has joined #dri-devel
tak2hu[m] has joined #dri-devel
talcohen[m] has joined #dri-devel
Targetball[m] has joined #dri-devel
i-garrison has joined #dri-devel
tayloralgo1[m] has joined #dri-devel
terribletea[m] has joined #dri-devel
tintou has joined #dri-devel
underpantsgnome[m] has joined #dri-devel
tleydxdy has joined #dri-devel
tomeu has joined #dri-devel
Tooniis[m] has joined #dri-devel
kos_tom has joined #dri-devel
treeq[m] has joined #dri-devel
ttayar[m] has joined #dri-devel
tuxayo has joined #dri-devel
uis[m] has joined #dri-devel
undvasistas[m] has joined #dri-devel
Soroush has joined #dri-devel
valentine has joined #dri-devel
Vanfanel has joined #dri-devel
vdavid003[m] has joined #dri-devel
viciouss[m] has joined #dri-devel
vidal72[m] has joined #dri-devel
MatrixTravelerbot[m] has joined #dri-devel
Weiss-Fder[m] has joined #dri-devel
wv[m] has joined #dri-devel
x512[m] has joined #dri-devel
xeld[m] has joined #dri-devel
dlx[m] has joined #dri-devel
xerpi[m] has joined #dri-devel
YaLTeR[m] has joined #dri-devel
YHNdnzj[moz] has joined #dri-devel
yshui` has joined #dri-devel
zamundaaa[m] has joined #dri-devel
znullptr[m] has joined #dri-devel
zzxyb[m] has joined #dri-devel
jsa has joined #dri-devel
Kayden has quit [Quit: -> JF]
frieder has quit [Remote host closed the connection]
<JoshuaAshton>
pinchartl, sima: FWIW, there are still weird issues with unavoidable EINVALs with MST hotplugging due to connectors being removed/added kernel side. It broke a lot of userspace assumptions.
<emersion>
i think we fixed these?
<JoshuaAshton>
Link?
<JoshuaAshton>
I remember seeing those in Gamescope still with our dock that transitions from SST to MST when > 1 connector, definitely hit an EINVAL at some point there occasionally
<JoshuaAshton>
I am thinking about where you get a New Device event thing from polling, then go to set up the connector, query it, then by the time you want to use it it's been removed
<emersion>
t should be in the unregistered state
<emersion>
iit*
<emersion>
hm
<emersion>
maybe that only happens when the connector has been enabled?
<emersion>
would need to check the kernel source again
<JoshuaAshton>
It's very difficult to see in like typical cable plug scenarios, but a Dock initializing as SST then doing a MST transition very shortly after triggers it pretty reliably fwir
rsalvaterra has quit [Remote host closed the connection]
rsalvaterra has joined #dri-devel
<JoshuaAshton>
You could probably reproduce it synthetically in your app by just adding a big sleep after you query the connectors and unplugging the cable in that time
<JoshuaAshton>
(on an MST dock)
ced117 has joined #dri-devel
<sima>
JoshuaAshton, so as long as you don't include the connector, you shouldn't get EINVAL due to hotunplug
<sima>
at least we've tried to fix all these
<sima>
if you do include it, it's kinda unavoidable by design, because userspace doesn't hold a connector reference
<JoshuaAshton>
yeah
<sima>
so between you getting the connector stuff and then trying a modeset it might be gone again
<sima>
if you want to fix that, we could add userspace refcounting
<sima>
like a special GETCONNECTOR ioctl flag that opens a reference
<sima>
and you need to promise to close that with some new ioctl again
<JoshuaAshton>
Sounds good to me -- but also migggghtttt be abusable?
<JoshuaAshton>
I guess there is nothing stopping a userspace from being naughty and leaking connectors kernel side then
<sima>
you'd still get an EINVAL though if it's gone, but at least there's a guarantee that the connector id won't be reused by something else
<sima>
JoshuaAshton, you need to physically replug to actually leak anything
<JoshuaAshton>
Sure
<sima>
and we'd drop the refcount on close(drmfd)
<JoshuaAshton>
ye
gouchi has quit [Remote host closed the connection]
<sima>
so it's kinda meh
<sima>
but also, it's not really giving you the "no EINVAL" guarantee, since if the thing is gone it's kinda hard to modeset on it
<sima>
I guess we could allow that, but might be somewhat funky and timeout prone ...
gouchi has joined #dri-devel
<sima>
(only on these special refcounted drm connectors)
<emersion>
another way would be a "i've seen this hotplug event" kind of IOCTL from userspace
<JoshuaAshton>
Yeah, makes sense when you can't modeset on it anyway really
<sima>
JoshuaAshton, so anyway, if it's a big issue we can certainly adjust the uapi
<emersion>
or, if you just want a workaround, wat 30s and then delete the connector
<emersion>
wait*
YunseongKim has quit [Remote host closed the connection]
<sima>
but kinda another point in making hotpluggable bridges work like dp mst connectors, defo don't want to flavours of all these sharp uapi corners
<sima>
emersion, there's kinda the hotplug sequence counter for that
<emersion>
yea
<sima>
I guess we could pass that sequence counter in as part of the atomic commit
<emersion>
not exposed to userspace
<sima>
and if they mismatch, give you a special errno
<emersion>
… maybe
<sima>
well would be a good reason to do that
<sima>
but fundamentally there's just a race there
luc has quit [Remote host closed the connection]
ungeskriptet has quit [Quit: Ping timeout (120 seconds)]
jeeeun841351908155 has joined #dri-devel
gpiccoli has quit [Remote host closed the connection]
ungeskriptet has joined #dri-devel
<sima>
and I think the current uapi that guarantees (or well tries to, we still find bugs&corners) that you wont get a hotunplug EINVAL as long as you don't include connector properties in your atomic commit is probably the best we can do
cyrinux30 has joined #dri-devel
chamlis_ has joined #dri-devel
chamlis has quit [Read error: Connection reset by peer]
mainiomano_ has joined #dri-devel
cmarcelo_ has joined #dri-devel
pitust_ has joined #dri-devel
rasterman has quit [Quit: Gettin' stinky!]
rsalvaterra_ has joined #dri-devel
qyliss has quit [Remote host closed the connection]
jkrzyszt_ has joined #dri-devel
vliaskov__ has joined #dri-devel
danilo has joined #dri-devel
mainiomano has quit [Read error: Connection reset by peer]
ifreund has quit [Read error: Connection reset by peer]
cmarcelo has quit [Read error: Connection reset by peer]
krei-se- has joined #dri-devel
rsalvaterra has quit [Remote host closed the connection]
rpigott has quit [Write error: connection closed]
pitust has quit [Write error: connection closed]
vliaskov_ has quit [Remote host closed the connection]
jkrzyszt has quit [Read error: Connection reset by peer]
alarumbe has quit [Remote host closed the connection]
dakr has quit [Remote host closed the connection]
romangg has quit []
klounge19 has quit []
krei-se has quit [Read error: Connection reset by peer]
nowrep has quit [Remote host closed the connection]
<emersion>
the timer workaround thing would solve it
mort_ has quit [Quit: Ping timeout (120 seconds)]
yang3_ has joined #dri-devel
alarumbe has joined #dri-devel
klounge19 has joined #dri-devel
qyliss has joined #dri-devel
fab has quit [Remote host closed the connection]
mort_ has joined #dri-devel
<emersion>
it's not _great_, but we've been doing that for Wayland globals (which are Hard to fix for reasons) and it works very well
Mangix has quit [Read error: Connection reset by peer]
vup2 has quit [Remote host closed the connection]
jeeeun84135190815 has quit [Ping timeout: 480 seconds]
Mangix has joined #dri-devel
dos11 has quit [Read error: Connection reset by peer]
cyrinux3 has quit [Ping timeout: 480 seconds]
HdkR has quit [Remote host closed the connection]
HdkR has joined #dri-devel
yang3 has quit [Ping timeout: 600 seconds]
tyalie has joined #dri-devel
kaiwenjon has quit [Quit: WeeChat 3.8]
coldfeet has quit [Remote host closed the connection]
kugel has quit [Remote host closed the connection]
kugel has joined #dri-devel
dok has quit [Remote host closed the connection]
dok has joined #dri-devel
nowrep has joined #dri-devel
Thymo has joined #dri-devel
ungeskriptet has joined #dri-devel
gouchi has quit [Ping timeout: 480 seconds]
rsalvaterra_ has quit []
gouchi has joined #dri-devel
rsalvaterra has joined #dri-devel
gpiccoli has joined #dri-devel
romangg has joined #dri-devel
iive has joined #dri-devel
<sima>
emersion, the timer would need to be on the connector status change to unplugged itself
<sima>
which kinda opens a can of worms if we do this across all drivers
coldfeet has joined #dri-devel
<emersion>
not sure i understand
<sima>
since delaying the connector deletion only delays reallocating the kms id of that connector
<sima>
you still get EINVAL the moment it's unplugged (if it's included in a modeset/atomic ioctl call)
<emersion>
hm yeah
<sima>
so also a bit a question of what's the real issue, just connector id confusion, or also the EINVAL
Kayden has joined #dri-devel
<sima>
emersion, hence why I'm leaning towards exposing the hotplug seqno and passing that as an argument to atomic and then failing with a special E_OUT_OF_DATE errno or so
<emersion>
yeah that sounds better
<sima>
and then just leaving it to userspace how it wants to recover
<sima>
EIDRM sounds neat for this :-)
<emersion>
it could generalize to other state that needs sync as well
<sima>
yeah could do it in general for IMMUTABLE properties that the kernel sets
<sima>
if the value you supply doens't match you get the special errno back
<sima>
but the hotplug seqno should cover it all pretty well, including the connector id confusion case
<emersion>
well
<emersion>
connector confusion would happen anyways
<emersion>
you can GETCONNECTOR and then get the wrong thing back
<sima>
well would need it there too
<sima>
hm the epoch counter is per connector
<emersion>
but that wouldn't generalize
<emersion>
GETPROPERTY etc
<emersion>
eh
<sima>
so you actually cannot use that to avoid confusion, we'd need to make the epoch counter at least device global
<emersion>
i think the epoch counter is per-connector for a good reason?
<emersion>
hm
<emersion>
i think to detect when a connector changed?
<sima>
yeah it needs to be per-connector
<sima>
but we'd need a global timeline
<emersion>
so would need a new but similar thing
<emersion>
right
<sima>
so that when a connector is unplugged and a new one is replugged, it has a higher epoch counter
<sima>
well it's not yet exposed, so doesn't matter
<emersion>
right
<emersion>
indeed
<sima>
and even if it is, it would just mean the epoch increments a bit faster, when it does
<sima>
which userspace already needs to cope with anyway
<emersion>
yea
<sima>
emersion, so thinking some more for the GET* one, if you just wrap it in GETPROP calls for the epoch, that should be enough?
<sima>
like you get the connector id from the uevent, so you can just go right ahead and grab the epoch of that
<sima>
and then do whatever you feel like, and then recheck the epoch
<sima>
so we'd also need to make sure that we send out the connector id everywhere
<emersion>
that sounds a bit cumbersome for userspace i must admit
<emersion>
do a bunch of things, then check the epoch, f it changed rollback all these things…
chamlis_ has quit [Remote host closed the connection]
chamlis has joined #dri-devel
<emersion>
would be nicer to have -ETRYAGAIN
<emersion>
a "ACK epoch" mechanism would allow for that
<sima>
uh there's still a lot of places which don't even send out the connector id :-/
<emersion>
yeah, and we can't send the connector ID always
<emersion>
when you unplug a dock there might be 2 connectors involved
<sima>
well I mean a lot of places that could but don't
<sima>
emersion, well those could just send 2 events
<emersion>
i tried to fix at least some of them
<emersion>
sima, amdgpu groups these
<emersion>
well, it's nicer to have a single uevent for a single logical change
<emersion>
user-space only needs to rescan once
<sima>
well most should go out through dp mst helpers, which atm just batches them because it doesn't bother
<emersion>
i reall thought i fixed that…
<sima>
wouldn't be too hard to keep track of the impacted connector, and if there's more than one, clear that and send the big event
<emersion>
yeah i implemented something like this
<sima>
emersion, I think on the big driver the usual connector events are fixed, but not dp mst stuff
<sima>
I think at least, from a few quick greps
jkrzyszt_ has quit [Remote host closed the connection]
<emersion>
hm i fixed drivers but not DP-MST it seems
<ernstp>
hi kisak! looked like spirv-llvm-translator wanted gcc-13 though? and got some test failures when building with gcc-9 instead..
<ernstp>
was trying with -16 though. perhaps -15 would work better...
Duke`` has quit [Ping timeout: 480 seconds]
gouchi has quit [Remote host closed the connection]
<pinchartl>
emersion: sima: I like the seqno idea
<pinchartl>
regarding reuse of the connector id, I wonder if we could avoid reusing ids. that won't work if we consider transient objects like frame buffers, but for objects that have a longer life span, could we just increase the id ?
<pinchartl>
that brings other issues obviously
<pinchartl>
we'll have a wraparound at some point
<pinchartl>
but maybe we don't need to care about >2G plugs/unplugs ?
<kisak>
spirv-llvm-translator-## should be the same number as the llvm build you're using with mesa.
mbrost has quit [Ping timeout: 480 seconds]
mbrost has joined #dri-devel
<emersion>
imho warparound is fine
<emersion>
hm
<emersion>
would need to make sure to skip already allocated IDs though
<pinchartl>
that may lead to log(n) operations
<pinchartl>
sorry, O(n)
<pinchartl>
too late to type
<pinchartl>
or think :)
Haaninjo has quit [Quit: Ex-Chat]
kaiwenjon has joined #dri-devel
Kayden has joined #dri-devel
sukuna has joined #dri-devel
guludo has quit [Quit: WeeChat 4.2.2]
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
sukuna has quit [Remote host closed the connection]
sukuna has joined #dri-devel
sukuna has quit [Remote host closed the connection]
heat has quit [Remote host closed the connection]
glennk has quit [Ping timeout: 480 seconds]
vliaskov__ has quit [Ping timeout: 480 seconds]
vliaskov__ has joined #dri-devel
simon-perretta-img has quit [Read error: No route to host]
simon-perretta-img has joined #dri-devel
<DemiMarie>
not if one uses a range tracking data structure that makes this fast
vliaskov__ has quit [Remote host closed the connection]
bolson has quit [Remote host closed the connection]
bolson has joined #dri-devel
pcercuei has quit [Quit: dodo]
kaiwenjon has quit [Remote host closed the connection]