pevik has quit [Remote host closed the connection]
pevik has joined #linux-msm
pevik_ has quit [Remote host closed the connection]
pevik_ has joined #linux-msm
pevik has quit [Ping timeout: 480 seconds]
Danct12 has quit [Remote host closed the connection]
<ichernev[m]>
sboyd: any comments on the v4 sm6115 gcc patchset: https://lkml.org/lkml/2021/8/5/765? I'm waiting to submit my DT patches ;-)
cmeerw has joined #linux-msm
svarbanov has quit [Ping timeout: 480 seconds]
svarbanov has joined #linux-msm
<lumag>
bamse, minecrell : if I remember correctly what somebody (ndec?) has told me, the 1034.2.1 was released separately to us under redistribution-permitted license, but we never got 1036 under such license. I think we'd better send 1034 ATM and check whether we can get permission for the 1036.
Danct12 has joined #linux-msm
<minecrell>
lumag: Ah, thanks for clarifying! If you have permission for the 1034 it's indeed better to send that first. As far as I noticed FastRPC is the only advantage of 1036 so it's not really worth delaying all other firmware only because of that
cmeerw has quit [Ping timeout: 480 seconds]
<Marijn[m]>
lumag: Bamse and me were discussing the removal of global clock name dependencies (`.parent_names = .. "xo"`) from DSI PHY PLLs, in favour of `.fw_name = "xo"` and specifying this in the DT. It's problematic on many platforms which don't define their xo to be named exactly "xo" (xo_board or bi_tcxo nowadays) and we have a hacky `fixed_factor` clock in gcc just to provide a global clock with the `"xo"` name. We'll switch the driver to use
<Marijn[m]>
`.fw_name` and update DT to provide this clock. Do you by any chance have changes in progress that change clock handling one way or another, that might conflict?
<bamse>
minecrell: afaict there are a couple of platforms that rely on "xo" and don't have a "xo" clock...so it would be good to fix that up
<bamse>
not minecrell, Marijn[m]
<Marijn[m]>
lumag: In addition I can't help but notice that these drivers are repeatedly `snprintf`-ing the names of the clocks for use as parent(s); any thoughts on adding a few more helper functions to `clk-provider.h` and switch them all over to using `hw` pointers too like the `*cc` drivers?
<Marijn[m]>
bamse: Correct, there are quite a few (clock-controller) drivers still relying on a global "xo" clock (grep for `{ "xo"` or `.name = "xo"`), should probably be fixed in a large cleanup-spree but it's a lot of work :(
<Marijn[m]>
bamse: We even came across a driver (`hfpll.c`) that doesn't use parent names at all but `.index = 0` :P
<Marijn[m]>
Works, but we might want to be more explicit since the DT for this driver (qcs404 and the dt-bindings) already explicitly specify the `"xo"` clock name for that...
<bamse>
Marijn[m]: doesn't .index=0 mean "the first clock specified in the dt node"?
<Marijn[m]>
bamse: Pretty sure, yes
<bamse>
Marijn[m]: that's perfectly fine, if there's a single clock for a device clk_get(dev, NULL) is preferable
<Marijn[m]>
Afaik it even makes `clock-names = "whatever"` obsolete