15:02 <Tooniis[m]> lumag_: this commit broke display for me on msm8996 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6874f48bb8b050b695698f1145e6846ba08baa75

15:02 <Tooniis[m]> to fix it i had to move iommus and interconnects to the mdss node in dts

15:03 <Tooniis[m]> do you have a patch doing that which perhaps didnt get applied? or should i send one?

15:06 <Tooniis[m]> also maybe its better to add some fallback code to maintain compatibility with old device trees?

15:19 <mal> what kind of error did you see in logs?

15:22 <Tooniis[m]> [ 66.369185] arm-smmu d00000.iommu: TLB sync timed out -- SMMU may be deadlocked

15:26 <Tooniis[m]> speaking about interconnects, the msm8996 icc driver patches were applied a while ago, but it seems that the dts patch was left out

15:26 <Tooniis[m]> https://lore.kernel.org/linux-arm-msm/20211021132329.234942-1-y.oudjana@protonmail.com/T/#mbd817c4c212d38a423e63e5c3649929949f79612

17:36 <steev> i'm guessing yassine didn't send a new dts patch with georgi's requested changes

18:51 <Tooniis[m]> which changes? Georgi only commented on the driver patch

18:52 <Tooniis[m]> (btw im yassine, if that isnt clear)

20:02 <lumag_> Tooniis[m], hi Yassine, thanks for your patches for the modem and icc.

20:02 <lumag_> I have been testing this patch on db820c.

20:03 <lumag_> It is really strange if the patch broke things for you. Do you use the mdp5 driver or the hacked version of dpu1?

20:05 <lumag_> I think, I know, what is the issue with interconnects. Other devices have mdp-mem path in the mdss node, while in your patch it was a part of mdp node.

20:06 <lumag_> Regarding iommu, I'm not sure. Can you please check if https://patchwork.freedesktop.org/series/103409/ makes things different for you?

20:11 <CosmicPenguin> :q

20:11 <CosmicPenguin> oops, sorry

20:11 <lumag_> Tooniis[m], However the mdp5 driver makes sure to check both mdp and mdss devices for the iommu.