07:29 <aka_[m]> krzk: with this commit

07:29 <aka_[m]> Do we still need to add compatibles to YAML and have compatible in dts with soc then generic or just we can skip it?

07:29 <aka_[m]> https://lore.kernel.org/lkml/CAD=FV=WdH0FLfQ-MMwkrHfo3xTjg8M2vxV5iO-CEpCDWG8NKKw@mail.gmail.com/

07:42 <aka_[m]> How do i know if i have to add compatible for MDSS specific SMMU impl?

07:44 <aka_[m]> https://lore.kernel.org/linux-arm-kernel/d271c47a-4c57-030c-7511-4daa7e167bd3@somainline.org/T/

11:42 <mal> has anyone had issues with iommu on 5.19? I had to patch iommu.c to get it to work again, my patched qcom_iommu used to work in 5.18 but unrelated changes in 5.19 in this part https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iommu/iommu.c#n2092 causes issues, I have to add checks that default_domain and blocking_domain are valid before comparing those to domain value

14:08 <lumag> ichernev[m], aka_[m]: yes, a quirk is fine for now. However I'd prefer if we can sort this out properly. I mean, tested on 660, etc.

14:09 <lumag> Regarding the downstream. I trust it up to some degree. It is not uncommon that they add code that works only for the models supported by this particular kernel set.

18:49 <aka_[m]> <mal> "has anyone had issues with iommu..." <- maybe this is related?

18:49 <aka_[m]> https://patchwork.kernel.org/project/linux-arm-msm/patch/20220815181437.28127-2-nicolinc@nvidia.com/

19:16 <mal> aka_[m]: not sure, I think don't see that error in log, the issue I see if before it even reaches the actual qcom_iommu code

19:17 <mal> aka_[m]: you can see here https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iommu/iommu.c#n2092 that the attach_device call happens after the problematic if condition

19:19 <mal> aka_[m]: I get that EBUSY error because group->default_domain and group->blocking_domain are both 0, for comparison that function in 5.18 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iommu/iommu.c?h=v5.18#n2119 check that group->default_domain is non-null