<rmilecki>
ValueError: invalid literal for int() with base 10: ''
<rmilecki>
aparcar: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=524cbcf6f5b07f3d9ee45e445da12760947e232e ("build: store SOURCE_DATE_EPOCH in JSON info files")
<rmilecki>
it seems that for 19.07 you wanted to force that value to be int
<rmilecki>
in master we don't have that int() and that makes it "work" for me
<aparcar[m]>
rmilecki: so it break 19.07?
<rmilecki>
aparcar[m]: kind of, just imagebuilder for people without SOURCE_DATE_EPOCH env set
<aparcar[m]>
strange... I think I backported the related fix
<rmilecki>
aparcar[m]: from commit description (" [store source_date_epoch as integer]") it thought you added that int() on purpose just for 19.07
<rmilecki>
let me double check master
<aparcar[m]>
no should be the case everywhere
<rmilecki>
aparcar[m]: ah, you included a later change in that commit! i see now
hanetzer4 has joined #openwrt-devel
<rmilecki>
https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=2120cad38d6f78cc1b727459eeedb6ed9a14edbe ("build: store source_date_epoch as integer")
<aparcar[m]>
mhh but when it breaks your stuff... bad
<rmilecki>
i'm verifying with master snapshots
<rmilecki>
ok, it doesn't happen with openwrt-imagebuilder-bcm53xx-generic.Linux-x86_64.tar.xz
<rmilecki>
let me investigate further
<aparcar[m]>
maybe the variable is not exported within the 19.07 imagebuidler?
<rmilecki>
i think so
<rmilecki>
verifying it
Danct12 has joined #openwrt-devel
<rmilecki>
aparcar[m]: json_add_image_info.py is called from include/image.mk and gets SOURCE_DATE_EPOCH passed
<rmilecki>
SOURCE_DATE_EPOCH is set and exported by toplevel.mk
<rmilecki>
it seems that for some reason toplevel.mk doesn't get used in 19.07 when building images
<aparcar[m]>
snap. sorry for the inconvenience
<rmilecki>
any idea where toplevel.mk gets included by other scripts?
<rmilecki>
maybe it needs to be there before generating imagebuilder image though
<rmilecki>
i'll try to test
<rmilecki>
i need to build 19.07 with imagebuilder image
<rmilecki>
will take me a moment
<Tapper>
Is not 19.07 end of life?
<rmilecki>
may be
<rmilecki>
Tapper: i'm debugging another thing and I need to compare some old releases
Danct12 has quit [Quit: WeeChat 3.8]
Ryncewynd has joined #openwrt-devel
<kabel>
does netifd set ethtool autonegotiation on an interface? if I do ifdown wan && ethtool -s eth2 autoneg off && ifup wan the autonegotiation is enabled after the last command
<kabel>
but if I replace the last command with just ifconfig eth2 up the autonegotiation is kept disabled
<rmilecki>
aparcar[m]: oh, because of sorting directories in downloads.openwrt.org i didn't realize we had 19.07.10 release
<rmilecki>
aparcar[m]: i've just tried 19.07.10 imagebuilderand it works fine!
<Borromini>
Tapper: it is, but plenty of SDKs based on it probably.
aparcar[m] has quit [Quit: Bridge terminating on SIGTERM]
JulianGro[m] has quit [Quit: Bridge terminating on SIGTERM]
evils[m] has quit [Quit: Bridge terminating on SIGTERM]
fpsusername[m] has quit [Quit: Bridge terminating on SIGTERM]
znullptr[m] has quit []
will[m] has quit [Quit: Bridge terminating on SIGTERM]
JuniorJPDJ has quit []
oliv3r[m] has quit []
vulpes2[m] has quit [Quit: Bridge terminating on SIGTERM]
lipnitsk has quit [Quit: Bridge terminating on SIGTERM]
decke[m] has quit [Quit: Bridge terminating on SIGTERM]
nick[m]12 has quit [Quit: Bridge terminating on SIGTERM]
domon has quit []
hauke[m] has quit [Quit: Bridge terminating on SIGTERM]
gnustomp[m] has quit []
hexagonwin[m] has quit [Write error: connection closed]
whatevs111[m] has quit [Write error: connection closed]
olmari has quit [Write error: connection closed]
MatMaul[m] has quit [Write error: connection closed]
fieryeagle954[m] has quit [Write error: connection closed]
schmars[m] has quit [Write error: connection closed]
bluse-blue[m] has quit [Write error: connection closed]
barhom has quit [Write error: connection closed]
skorpy[m] has quit [Write error: connection closed]
pavlix has quit [Write error: connection closed]
John[m]1234567 has quit [Quit: Bridge terminating on SIGTERM]
dangole_ has joined #openwrt-devel
<rmilecki>
oh, now it seems openwrt-imagebuilder-19.07.9-bcm53xx.Linux-x86_64.tar.xz works on another machine
<rmilecki>
gremlins
<rmilecki>
ah, it's my local build of 19.07.9 imagebuilder that works
<rmilecki>
official one still doesn't
<rmilecki>
it's undebuggable :D
aparcar[m] has joined #openwrt-devel
<rmilecki>
ok, it has been fixed by the https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=5ecc7ead48783136569a541d59398e08767fd8bc ("imagebuilder: fix partition signature")
<rmilecki>
end of debugging
<rmilecki>
v19.07.9 is broken
<rmilecki>
v19.07.10 is good
karlp has quit [Quit: WeeChat 3.5]
karlp has joined #openwrt-devel
karlp has quit [Quit: WeeChat 3.5]
danitool has joined #openwrt-devel
karlp has joined #openwrt-devel
valku has joined #openwrt-devel
schwicht has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
tidalf has quit [Remote host closed the connection]
tidalf has joined #openwrt-devel
schwicht has quit [Ping timeout: 480 seconds]
schwicht has joined #openwrt-devel
madwoota has quit [Ping timeout: 480 seconds]
raenye has joined #openwrt-devel
<raenye>
Hello. Do I need to actively do something to have my pull requests reviewed?
<raenye>
I have one for a new device and one for a cosmetic luci fix
madwoota has joined #openwrt-devel
MaxS0niX has joined #openwrt-devel
MaxSoniX has quit [Ping timeout: 480 seconds]
cbeznea has quit [Quit: Leaving.]
raenye has quit [Remote host closed the connection]
minimal has joined #openwrt-devel
Daaanct12 has quit [Remote host closed the connection]
Daaanct12 has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Daaanct12 has quit [Remote host closed the connection]
Daaanct12 has joined #openwrt-devel
floof58 is now known as Guest10874
floof58 has joined #openwrt-devel
Guest10874 has quit [Ping timeout: 480 seconds]
tidalf_ has joined #openwrt-devel
tidalf__ has joined #openwrt-devel
schwicht has joined #openwrt-devel
tidalf has quit [Ping timeout: 480 seconds]
scomp has quit [Quit: Connection closed for inactivity]
<hurricos>
it doesn't even have a microcontroller inline :rofl:
<hurricos>
totally different architecture, different endopint PSE (BCM59121->BCM59103)
<hgl>
I saw multiple blocked PRs adding files in /lib/upgrade/ignore.d, is this a new feature? I couldn't find the code responsible for reading content in that dir. Anyone knows where it lives?
gladiac has quit [Quit: k thx bye]
<hurricos>
IT JUST WORKS :D
<hurricos>
AHH. I love open-source.
<jakllsch>
heh
<hurricos>
I mean, I shouldn't be surprised that C code is portable
<hurricos>
now I want to see if any of the folks on techinfodepot have found other places these PSE chips are used ...
Borromini has quit [Ping timeout: 480 seconds]
hanetzer has joined #openwrt-devel
philipp64 has joined #openwrt-devel
hanetzer4 has quit [Ping timeout: 480 seconds]
gladiac has joined #openwrt-devel
Paradox17 has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
schwicht has joined #openwrt-devel
Paradox17 has quit [Remote host closed the connection]
Gramdalf has joined #openwrt-devel
<mrnuke>
hurricos: You are surprised that it works? I find your lack of faith disturbing :p
<mrnuke>
hurricos: You know, I still need to go into realtek-poe and add those debug info that I've been talking about over the last year
Gramdalf has quit [Quit: Page closed]
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
Movedtomkg20001mkg20001io[m] has joined #openwrt-devel
mkg20001 has joined #openwrt-devel
nick[m]1234 has joined #openwrt-devel
oliv3r[m] has joined #openwrt-devel
olmari has joined #openwrt-devel
pavlix has joined #openwrt-devel
schmars[m] has joined #openwrt-devel
skorpy[m] has joined #openwrt-devel
tohojo has joined #openwrt-devel
MatrixTravelerbot[m]1 has joined #openwrt-devel
vulpes2[m] has joined #openwrt-devel
whatevs111[m] has joined #openwrt-devel
will[m] has joined #openwrt-devel
znullptr[m] has joined #openwrt-devel
<hurricos>
mrnuke: it's been in production for us for a year without issue, so IMO it's good enough ;^)
<hurricos>
I was only surprised that the protocol works on a completely different setup without error
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
dangole_ has quit [Ping timeout: 480 seconds]
schwicht has joined #openwrt-devel
minimal has quit [Quit: Leaving]
dangole has joined #openwrt-devel
dangole_ has joined #openwrt-devel
dangole has quit [Ping timeout: 480 seconds]
MaxS0niX has quit [Quit: Konversation terminated!]
cbeznea has joined #openwrt-devel
danitool has quit [Ping timeout: 480 seconds]
gladiac has quit [Quit: k thx bye]
Borromini has joined #openwrt-devel
Ryncewynd has quit [Quit: Leaving]
<oliv3r[m]>
I once saw in the kernel, a structure being initialized with a nother structure. e.g. something like this static const struct _t a = { .val = 1 }; static const struct _t b = a ={ .key = 2 }; Obviously this is wrong, but I can't recall where I saw it to see if I even remember it correctly. E.g. initialize a value (struct) from an existing struct, and initializing more :) if that makes sense
<oliv3r[m]>
e.g. i just want to have a base struct, that contains common values, and then 'copy' that into multiple new structs, with additional data ...
Lynx- has joined #openwrt-devel
tidalf__ has quit [Remote host closed the connection]
tidalf has joined #openwrt-devel
<philipp64>
nbd: how married are we to the tabbing in libubox's jshn for the indent? could we live with two spaces per indent-level instead?
<nbd>
why?
<nbd>
indentation with spaces makes no sense to me at all
<f00b4r0>
^. amen :)
* mrnuke
will try to stay out of any indentation discussion, but two spaces? really? :(
Borromini has quit [Ping timeout: 480 seconds]
<mrnuke>
hurricos: Do you remember what platform(s) use the PSE connected via I2C instead of UART?
<olmari>
I bet spaces became into intendation world at some stage wehre someone wasn't happy how tabs were represented too wide or too narrow ;D
<olmari>
"an space is an space"... until someone invented variable-width font :D
<f00b4r0>
I suspect it has more to do with punched cards. See e.g. COBOL
danitool has joined #openwrt-devel
bluew has joined #openwrt-devel
G10h4ck_ has quit [Read error: No route to host]
G10h4ck_ has joined #openwrt-devel
Lynx- has quit [Quit: Going offline, see ya! (www.adiirc.com)]
Borromini has joined #openwrt-devel
cbeznea has quit [Quit: Leaving.]
robimarko has quit [Quit: Leaving]
MatrixTravelerbot[m]1 has quit []
G10h4ck has joined #openwrt-devel
G10h4ck_ has quit [Ping timeout: 480 seconds]
Q__ has quit [Quit: Client limit exceeded: 20000]
magnusk[m] has quit [Quit: Client limit exceeded: 20000]
aparcar[m] has quit [Quit: Client limit exceeded: 20000]
Borromini has quit [Quit: Lost terminal]
fakuivan has quit [Remote host closed the connection]
fakuivan has joined #openwrt-devel
tidalf_ has joined #openwrt-devel
schwicht has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
<philipp64>
nbd: if it's machine generated, it seems like you want to support arbitrarily deep nesting and still be readable, whereas things fall off the screen quickly with tabbing and an 80 column monitor. Okay, what width would you like?