#panfrost on 2023-05-18 — irc logs at oftc.irclog.whitequark.org

2023-04-06 13:40 alyssa changed the topic of #panfrost to: Panfrost - FLOSS Mali Midgard + Bifrost + Valhall - Logs https://oftc.irclog.whitequark.org/panfrost

00:18 kinkinkijkin has joined #panfrost

02:27 Danct12 is now known as Guest508

02:27 Danct12 has joined #panfrost

03:41 Leopold_ has quit [Remote host closed the connection]

03:49 Leopold_ has joined #panfrost

03:56 kinkinkijkin has quit [Quit: Leaving]

04:35 Danct12 has quit [Read error: Connection reset by peer]

05:19 Danct12 has joined #panfrost

06:05 rasterman has joined #panfrost

06:29 Danct12 is now known as Guest517

06:29 Danct12 has joined #panfrost

06:30 Guest517 has quit [Ping timeout: 480 seconds]

06:51 Danct12 has quit [Ping timeout: 480 seconds]

07:26 <q4a> bbrezillon: can you check last 3 commits in https://gitlab.freedesktop.org/q4a/mesa/-/commits/v10-cleanup ? It's simple merging and moving functions. I can continue doing something like that or may be you clarify which parts bother you and what you would like to see?

07:29 <q4a> Another interesting thing - how long UNUSED vars should live in code? `struct pipe_rasterizer_state *rast = &ctx->rasterizer->base;` was marked as UNUSED 1 year ago: https://gitlab.freedesktop.org/bbrezillon/mesa/-/commit/26d339ef8ac7338a39aa5908d2dd38950933a474

07:29 <q4a> Should somebody delete it?

07:50 Danct12 has joined #panfrost

08:00 Danct12 has quit [Ping timeout: 480 seconds]

08:22 atler is now known as Guest529

08:22 atler has joined #panfrost

08:24 Guest529 has quit [Ping timeout: 480 seconds]

08:30 Danct12 has joined #panfrost

08:40 Danct12 is now known as Guest530

08:40 Danct12 has joined #panfrost

08:42 Guest530 has quit [Ping timeout: 480 seconds]

08:50 Danct12 is now known as Guest531

08:50 Danct12 has joined #panfrost

08:51 Guest531 has quit [Ping timeout: 480 seconds]

08:55 Danct12 is now known as Guest533

08:55 Danct12 has joined #panfrost

09:00 Guest533 has quit [Ping timeout: 480 seconds]

09:16 Danct12 has quit [Ping timeout: 480 seconds]

09:35 Danct12 has joined #panfrost

09:47 Danct12 is now known as Guest538

09:47 Danct12 has joined #panfrost

09:48 Guest538 has quit [Ping timeout: 480 seconds]

10:04 Danct12 has quit [Remote host closed the connection]

10:16 <bbrezillon> q4a: you mean move the declaration to the PAN_ARCH <= 8 section and drop the unused? Sure, why not.

10:20 Danct12 has joined #panfrost

10:31 Danct12 is now known as Guest541

10:31 Danct12 has joined #panfrost

10:32 Leopold_ has quit [Remote host closed the connection]

10:32 Leopold_ has joined #panfrost

10:33 Guest541 has quit [Ping timeout: 480 seconds]

11:10 <q4a> Thanks, I'll move it. Another simple question: should I remove vars or add UNUSED if they are not used at all? Like dev in panfrost_emit_heap_set: https://gitlab.freedesktop.org/bbrezillon/mesa/-/blob/0f30350291a1a640bd786f8bea35e363d4ef0a1e/src/gallium/drivers/panfrost/pan_cmdstream.c#L2689

11:47 MajorBiscuit has joined #panfrost

11:57 Major_Biscuit has joined #panfrost

12:01 MajorBiscuit has quit [Quit: WeeChat 3.6]

12:07 stepri01 has quit [Remote host closed the connection]

12:15 stepri01 has joined #panfrost

12:34 Danct12 has quit [Quit: WeeChat 3.8]

13:00 nick_ has joined #panfrost

13:32 nick_ has quit [Remote host closed the connection]

13:48 rasterman has quit [Quit: Gettin' stinky!]

16:26 rasterman has joined #panfrost

17:18 Major_Biscuit has quit []

18:06 atler has quit [Quit: atler]

21:03 rasterman has quit [Quit: Gettin' stinky!]