<alyssa>
mupuf: What I landed was the results of running clang-format over every file in panfrost/asahisuch that a lint would pass if you ran it.
kimbro has quit [Ping timeout: 480 seconds]
<alyssa>
I didn't actually touch CI or add pre-commit hooks or anything, I planned to wait until folks were back in the office to have that discussion (and if people were on board, see if DavidHeidelberg[m] was interested in doing something for all the clang-format/rustfmt 'd code)
Mangix has quit [Read error: Connection reset by peer]
Mangix has joined #dri-devel
dviola has quit [Quit: WeeChat 3.7.1]
Danct12 has quit [Quit: Quitting]
YuGiOhJCJ has joined #dri-devel
Danct12 has joined #dri-devel
RhineDevil has joined #dri-devel
kimbro has quit [Ping timeout: 480 seconds]
RhineDevil^ has quit [Ping timeout: 480 seconds]
<hays>
Frogging101: disagree--it is helpful to have coding standards that are reasonable. arguing over which indenting style is better i will agree is bikeshedding though. but its important to have something in place
<Frogging101>
ah, my use of the term bike shedding wasn't necessarily negative
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
JohnnyonFlame has joined #dri-devel
<Lynne>
quick question, is it possible that some drivers may signal more features for linear-tiled images than optimal-tiled images?
<Lynne>
neither nvidia nor radv do, all capabilities for each tiling are identical
kts has joined #dri-devel
fab has joined #dri-devel
heat has quit [Ping timeout: 480 seconds]
probablymoony has joined #dri-devel
jkrzyszt has joined #dri-devel
jfalempe has joined #dri-devel
<Lynne>
found a couple on my 960m, oddly enough it's the opposite of what I thought; linear tiled images have less features than optimal tiled images
<Lynne>
that saves me some work
moony has quit [Ping timeout: 480 seconds]
kimbro has joined #dri-devel
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
sgruszka has joined #dri-devel
<mupuf>
alyssa: I see, sorry for the confusion!
fab has quit [Quit: fab]
<mupuf>
My thoughts are that what we want is for CI to *check and fail* if the format is acceptable, not auto-format the code for us before pushing. And to prevent people having to change any of their setup, it would be best if this became a meson pass: Check the style before compilation, if it fails, either fail the compilation or re-format automatically.
* mupuf
may prefer the "fail compilation" rather than auto-magic re-formatting
<mupuf>
Maybe we could start with the driver alyssa already converted, since all the work has already been done there, then we can extend it one driver at a time, as the different driver developers want to hop in it?
<mupuf>
And I guess we really don't want to enforce a uniform coding style across the project just yet, and rather just enforce a coding style per driver (or per file if *really* necessary)
tzimmermann has joined #dri-devel
<mupuf>
Frogging101: yeah, disabling auto-formating/warnings for specific sections we carefully worked on is IMO indeed the way to go :)
rszwicht has joined #dri-devel
kimbro has quit [Ping timeout: 480 seconds]
YuGiOhJCJ has quit [Remote host closed the connection]
YuGiOhJCJ has joined #dri-devel
srslypascal is now known as Guest119
srslypascal has joined #dri-devel
danvet has joined #dri-devel
Guest119 has quit [Ping timeout: 480 seconds]
fab has joined #dri-devel
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
ADS_Sr has quit [Read error: Connection reset by peer]
ADS_Sr has joined #dri-devel
<danvet>
mripard, btw just noticed that there's also misc-next-fixes pending, so pls send pull requests for everything
<danvet>
or do I need to pick up an old one?
<danvet>
probably also means the wrong branch lands in for-linux-next
Lucretia has quit [Read error: Connection reset by peer]
Lucretia-backup has joined #dri-devel
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
Jeremy_Rand_Talos_ has joined #dri-devel
elongbug_ has quit [Remote host closed the connection]
elongbug_ has joined #dri-devel
kts has quit [Quit: Leaving]
RhineDevil^ is now known as RhineDevil
<RhineDevil>
Ristovski: Isn't it possible to partially increase hardware support for codecs in mesa3D? Could I have an idea as clearly as possible of how much of the decoding process takes place in mesa3d, in amd installed firmware and in amd hardware?
<Ristovski>
RhineDevil: The GPU itself has specialized hardware blocks for decoding video, if those HW blocks don't support a codec it simply is not possible to implement support for it
<RhineDevil>
As an example, vainfo -a shows me that vaapi on my machine supports MPEG2, VC1 and H264 with yuv240p and yuv420p pixel encoding, would be nice for example if it could support yuv420p10
<Ristovski>
I am not sure how specialized the HW blocks themselves are, afaik there are no public docs on them either
<RhineDevil>
Ristovski: how much specialized? is the entire processing needed for the format directly encoded? You can't just ask "ok give me this specific function for accelerating yuv420p encoding"?
<RhineDevil>
Ristovski: so it's AMD firmware deciding how to expose HW blocks and you know from that if it supports determinate pixel encoding?
<RhineDevil>
Like, if it supported yuv420p10 you'd see VA_RT_FORMAT_YUV420P10
<RhineDevil>
or a string like that telling you yes I support this pixel format
<Ristovski>
I am not sure if there is some mechanism to directly query the HW blocks
<alyssa>
mupuf: Sure, sticking the checks in meson is an option in addition to / instead of git pre commit hook and CI
<alyssa>
panfrost and asahi are already converted, take your pick which to use as the test dummy
<alyssa>
asahi has fewer devs touching it so might be less disruptive
<alyssa>
(really it's just me and lina)
<alyssa>
both use clang-format off in a fe wplaces but rare
* mupuf
thinks we shouldn't use git pre-commits for this, as it is quite likely to interfere with already-existing pre-commits mesa devs may already have
sgruszka has quit [Ping timeout: 480 seconds]
<alyssa>
OK
<RhineDevil>
Ristovski: uhmmm yeah judging from that seems there is no way to have custom vaapi stuff, god knows what their interfaces are and they're probably tight lipped about their patents and architecture details
<alyssa>
mupuf: meson build rule that runs the lint and (if it fails) fails the build with instructions on how to setup/run clang-format (including integrated with editor) then?
<mupuf>
And I believe checking the coding style in CI is not optional, as I am sure people don't always compile or commit the changes done by the compilation before submitting their series
<mupuf>
yeah, this sounds ideal to me
<Ristovski>
RhineDevil: That is most likely correct. Not to mention that the firmware for all the HW blocks is proprietary as well
<alyssa>
so then people hacking locally get the lint run and CI runs it too automatically
<alyssa>
without adding shit to the sanity stage
<mupuf>
and a switch to opt out from it so that distros don't have to add a build dependency
<alyssa>
and avoids the trap of "did not install clang-format so precommit hook didn't do anything and now CI is yelling at me"
<RhineDevil>
Ristovski: although in the kernel code I see no reference to pixel formats
<RhineDevil>
just the encoding
<alyssa>
mupuf: this *does* require devs to setup "autoformat on save or earlier"
<alyssa>
as opposed to doing it at the commit level
<alyssa>
since now if you're just experimenting you need it formatted right to build t at all
<mupuf>
true that...
<mupuf>
I guess meson can just fail to build if not formated correctly, then we would document the two solutions: pre-commit or reformat on save
<alyssa>
for me that's fine -- I configured vim to autoformat on save, so unformatted code never hits the disk
<alyssa>
=> meson never sees unformatted code
<alyssa>
=> lint always passes
<alyssa>
all competent editors and IDEs can do this
<alyssa>
but it *does* require deliberate configuration
<jenatali>
Are you thinking component-specific jobs, or a tree-wide job with a config for which directories need to be linted?
<jenatali>
Or maybe it's just based on where there's clang-format files
<alyssa>
jenatali: latter
<jenatali>
No but some directories have them but didn't do a full reformat so it'd need to be more scoped than that I think
<jenatali>
Interesting idea, for sure
<alyssa>
right, that's what I didn't realize
<alyssa>
I assumed the dirs with them were reformatted
<alyssa>
r600/sfn seems to be
heat has joined #dri-devel
<jenatali>
Oh maybe I'm wrong about that then
<alyssa>
I thought aco was but ?
<alyssa>
seemingly radv and freedreno were not
<alyssa>
and seemingly ir3
<jenatali>
I've been meaning to write a .clang-format for our internal codebase... That would've been a good thing to do while everyone was on vacation lol
<alyssa>
jenatali: now you know why I yeeted in clang-format to my drivers over Christmas :-p
<jenatali>
Instead I tinkered with Mesa CI
<RhineDevil>
Ristovski: thank you, gonna take a look. Btw from what I've seen there must be a bug somewhere in mesa3d encoding handling before passing it to kernel and underlying hardware, because it doesn't properly encode stuff in needed format
agd5f_ has joined #dri-devel
agd5f_ has quit [Remote host closed the connection]
agd5f_ has joined #dri-devel
agd5f_ has quit [Remote host closed the connection]
agd5f_ has joined #dri-devel
agd5f_ has quit [Remote host closed the connection]
agd5f_ has joined #dri-devel
agd5f_ has quit [Remote host closed the connection]
agd5f_ has joined #dri-devel
agd5f has quit [Ping timeout: 480 seconds]
ADS_Sr has quit [Read error: Connection reset by peer]
ADS_Sr has joined #dri-devel
pcercuei has joined #dri-devel
aknautiy has quit [Remote host closed the connection]
Guest1098 has quit [Ping timeout: 480 seconds]
<alyssa>
jani: re i915 display code, for iris maybe it makes sense to use kmsro?
<alyssa>
i915 display + xe renderonly
<alyssa>
zmike: welcome back
RhineDevil has quit [Remote host closed the connection]
RhineDevil has joined #dri-devel
* zmike
grumbles about the new fad being pre-merge code formatting instead of something more useful like rewriting glsl in rust
<zmike>
ci seems to work though
<zmike>
pluses and minuses
<RhineDevil>
Ristovski: encoder seems generic too
fab has quit [Quit: fab]
<Ristovski>
yeah, I didn't see anything specific for 10bit either, hmm
fxkamd has joined #dri-devel
jewins has joined #dri-devel
<mupuf>
zmike: welcome back!
<mupuf>
I kept Zink on radv clean while you were away :)
<zmike>
💪
MajorBiscuit has quit [Quit: WeeChat 3.6]
MajorBiscuit has joined #dri-devel
srslypascal is now known as Guest148
srslypascal has joined #dri-devel
MajorBiscuit has quit []
srslypascal has quit [Remote host closed the connection]
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
<tzimmermann>
in december there was a patchset to remove the ancient drivers for userspace modesetting. no one really commented, so there is currently no support for this?
<mlankhorst>
tzimmermann: most likely nobody noticed. :)
<tzimmermann>
i should r-b the patchset and silently delete them :P
Duke`` has joined #dri-devel
bgs has joined #dri-devel
aravind has quit [Ping timeout: 480 seconds]
Akari has quit [Quit: segmentation fault (core dumped)]
Haaninjo has joined #dri-devel
jkrzyszt has quit [Ping timeout: 480 seconds]
<jani>
alyssa: it's one pci device for the whole thing, and I don't think there's a feasible way to split this between drivers
<jani>
alyssa: I mean xe render for discrete + i915 render and display for integrated works fine, because they're different devices
fab has quit [Read error: Connection reset by peer]
fab_ has joined #dri-devel
fab_ is now known as Guest155
<danvet>
alyssa, the kernel side needs fairly tight integration in handling mappings and stuff, and at that point doing the kmsro dance feels a bit like an academic exercise ...
<danvet>
could totally be done with aux bus and all that though
tursulin has quit [Ping timeout: 480 seconds]
ybogdano has joined #dri-devel
camus has quit [Remote host closed the connection]
<MrCooper>
pendingchaos: no, but it happens pretty early on, takes less than a minute
camus has joined #dri-devel
sarahwalker has quit [Remote host closed the connection]
nchery has joined #dri-devel
tzimmermann has quit [Quit: Leaving]
ADS_Sr has quit [Remote host closed the connection]
<alyssa>
(that was a joke, it's Rust code, there's no way it possibly builds)
* alyssa
just discovered the ANV indirect draw GLSL shaders
<alyssa>
thanks I hate it
<alyssa>
bnieuwenhuizen: Hmm, ok. I don't think that would really plug in to either of the workflows we (mupuf DavidHeidelberg[m] and I) discussed so far but mh
<danvet>
alyssa, well linux doesn't really care whether pci or anything else, you can instantiate more struct device on top and use all the neat things either way
<danvet>
it's more that the hw is quite a bit a messy thing
rgallaispou has quit [Read error: Connection reset by peer]
<DavidHeidelberg[m]>
thou interesting, I didn't know that meson can do that, but since we have non-clang parts of Mesa, it would be probably hard to utilize
<DavidHeidelberg[m]>
oh, nevermind me, it can read the config and paths, so in theory it could work
nehsou^ has quit [Remote host closed the connection]
devilhorns has quit []
ybogdano has quit [Ping timeout: 480 seconds]
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
sravn has joined #dri-devel
<bl4ckb0ne>
what's the diff between a r-b and ack-by ?
<bnieuwenhuizen>
kernel or mesa?
<bl4ckb0ne>
mesa
<bnieuwenhuizen>
acked-by is roughly a "I didn't provide a full review but still think this should land"
<bl4ckb0ne>
what's the minimum requirement to give a valid r-b beside reviewing the code
<bnieuwenhuizen>
reviewing the code :)
<bnieuwenhuizen>
"Review by non-experts is encouraged. Understanding how someone else goes about solving a problem is a great way to learn your way around the project. The submitter is expected to evaluate whether they have an appropriate amount of review feedback from people who also understand the code before merging their patches."
<bl4ckb0ne>
perfect, thanks
junaid has quit [Ping timeout: 480 seconds]
<bnieuwenhuizen>
of course if the submitter is new and doesn't have submit permissions I think whoever assigns it to marge should make sure the reviews are reasonable
<bl4ckb0ne>
should be good i believe
lkw has joined #dri-devel
<FLHerne>
acked-by -> "what the patch says it does is a good idea"
<FLHerne>
reviewed-by -> "what the patch actually does is a good idea"
<Kayden>
also reviews are good from everyone, more eyes looking at it. acks are mostly only meaningful by someone seen as a kind of authority on the topic
<Kayden>
like if Rob acks freedreno code, it's good to go, if I ack freedreno code, it probably means I looked at it briefly and think it looks plausible, if a user acks it it's more of a "I think this fixes my problem so please land it" (but it might not be right at all) :)
<Kayden>
I think I heard someone say acks from random people are more like "woah, kewl dude", hehe
<Kayden>
but yeah more review is always appreciated!
<bl4ckb0ne>
in this case its a rather short commit fixing a bug i reported
<bl4ckb0ne>
im not at all familiar with the codebase but i poked at it a bit to fix it and gets the gist of the fix
<Kayden>
sounds good :)
ybogdano has joined #dri-devel
kimbro has joined #dri-devel
ngcortes has joined #dri-devel
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
lemonzest has quit [Quit: WeeChat 3.6]
ybogdano has quit [Ping timeout: 480 seconds]
RhineDevil has quit [Quit: Leaving]
RhineDevil^ has joined #dri-devel
nehsou^ has joined #dri-devel
<jani>
sometimes acked-by is also "I've seen it and I'm not opposed"
<bnieuwenhuizen>
jekstrand: actually browsing the patch submission documentation, where is the blurb you post when people get developer permissions from and should we add it to the docs?
<jekstrand>
bnieuwenhuizen: I just copy+paste from an old request. Yeah, we should probably put it in the docs somewhere.
<pepp>
MrCooper: ah :/ It seems I can't trigger the issue on navi21 so I'll test again with a navi10 tomorrow
tzimmermann has joined #dri-devel
OftenTimeConsuming has quit [Remote host closed the connection]
RhineDevil^ has quit [Remote host closed the connection]
<Lynne>
one of the worst things about vulkan is the requirement to allocate all your textures using drm tiling if you ever plan to export your textures as dmabufs
<jekstrand>
That's a feature, not a bug.
<jekstrand>
It's also pretty much a hard requirement if you want the client to be able to manage memory allocation
<emersion>
yeah, it's really important to negociate the modifier with the other side
<Lynne>
yeah, but drm tiling was rarely supported and often limiting when it comes to image formats, features and flags
<jekstrand>
Yup
<jekstrand>
And that's why you can't just up and export any image
<Lynne>
cuda export/import is both much worser and better
<Lynne>
worser, because you have to allocate all your vulkan images as cuda images, which you then import into vulkan
<Lynne>
better, because it operates via memory aliasing, so it doesn't care about tiling
<jekstrand>
Oh, it absolutely cares about tiling
<bylaws>
Is there a disassembler/assembler for modern nv architectures anywhere?
<jekstrand>
bylaws: There's a disassembler provided with the cuda packages
<bylaws>
Envyas seems to be far out of date with nouveau itself
<jekstrand>
Lynne: Whether or not they expose tiling to you is an entirely different question. ;-)
<Lynne>
jekstrand: well, yeah, it just always wants optimal tiling
<jekstrand>
That's because they're magically passing it side-band somehow
<Lynne>
ffmpeg used to allocate all vulkan frames using drm tiling because what if someone wanted to export them to vaapi, but I think vulkan video makes it pointless
<bylaws>
I assume I'm on my own for an assembler?
<jekstrand>
AFAIK, yes.
kimbro has quit [Ping timeout: 480 seconds]
OftenTimeConsuming has joined #dri-devel
rmckeever has joined #dri-devel
ADS_Sr has quit [Remote host closed the connection]
ADS_Sr has joined #dri-devel
kimbro has joined #dri-devel
psykose_ has quit [Remote host closed the connection]
<bnieuwenhuizen>
also getting less and less relevant I think now that anv/iris have a bunch of gitlab CI presence
<jekstrand>
Yeah, 6 is annoying
<jekstrand>
But, really, it's no worse than 4 and 5
<bnieuwenhuizen>
btw best part is specifying nowhere which drivers that are :)
<jekstrand>
lol
<bnieuwenhuizen>
like as long time contributor I know
<jekstrand>
I think at the time I wrote that, Igalia was doing their own disjoint CI stuff too.
<bnieuwenhuizen>
but all these new people?
Haaninjo has quit [Quit: Ex-Chat]
<jekstrand>
As an ex-Intel person (emphasis on ex), I say we should try to drop it. :P
<jekstrand>
Someone's gonna kill me for that....
<bnieuwenhuizen>
well, with anv/iris having some Gitlab CI presence and Amber being what it is I think the time is right?
<danvet>
doit.jpg
<jekstrand>
bnieuwenhuizen: crocus ci?
<bnieuwenhuizen>
I mean this discussion started with this blorb not even in the docs so we have nowhere to update :P
<jekstrand>
lol
<bnieuwenhuizen>
crocus seems missing yeah :|
ybogdano has joined #dri-devel
gawin has joined #dri-devel
bgs has quit [Remote host closed the connection]
<gawin>
iirc Emma is providing some crocus devices. (gen 4 and gen 7.5 iirc) but not enabled by default iirc
<anholt>
right, but you don't have to wait for a third party to run your tests for you.
<anholt>
(unless the systems are down because gpu reset is so unreliable)
kimbro has quit [Ping timeout: 480 seconds]
nchery has quit [Remote host closed the connection]
<gawin>
covering Amber iwould be super annoying igpus at that time weren't proving all features of dedicated gpus. also no bleeding edge features like support for uuid.
lkw has quit [Remote host closed the connection]
<jenatali>
I've said it before but it's discussions like this that make me so happy we managed to get Windows machines in CI for us
<jenatali>
And now we're even using deqp-runner like everyone else
ahajda has quit [Quit: Going offline, see ya! (www.adiirc.com)]
ADS_Sr has quit []
Duke`` has quit [Ping timeout: 480 seconds]
mvlad has quit [Remote host closed the connection]
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
<danvet>
bnieuwenhuizen, submit doc patch, conveniently leave out that last bullet :-)
<jekstrand>
WFM
kimbro has joined #dri-devel
gouchi has quit [Remote host closed the connection]
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
gawin has quit [Quit: Konversation terminated!]
RhineDevil has joined #dri-devel
RhineDevil^ has quit [Ping timeout: 480 seconds]
nchery has joined #dri-devel
kimbro has quit [Ping timeout: 480 seconds]
RhineDevil has quit [Ping timeout: 480 seconds]
Akari has joined #dri-devel
frankbinns1 has joined #dri-devel
frankbinns has quit [Remote host closed the connection]
RhineDevil has joined #dri-devel
Guest155 has quit []
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
kimbro has joined #dri-devel
elongbug_ has quit [Remote host closed the connection]