<javierm>
sravn: asking because on a second thought, maybe you wanted a preparatory patch to change those generic_write calls to dcs_write instead
lynxeye has joined #dri-devel
swalker_ has joined #dri-devel
swalker_ is now known as Guest793
jkrzyszt has joined #dri-devel
apinheiro has joined #dri-devel
swalker__ has joined #dri-devel
Danct12 has quit [Quit: Quitting]
Guest793 has quit [Ping timeout: 480 seconds]
<airlied>
Lynne: ill be still a bit flaky this week, kids at home with me!
aravind has joined #dri-devel
frankbinns has joined #dri-devel
<airlied>
Lynne: amd gave a hint about skipping sps/pps headers but it seems to corrupt slice header, will dig a bit more
rasterman has joined #dri-devel
mango_kiwi has quit []
pcercuei has joined #dri-devel
Nyaa has joined #dri-devel
kts has quit [Quit: Leaving]
<danvet>
jani, good enough reply on the drm_minor doc patch for an ack?
aravind has quit [Ping timeout: 480 seconds]
_kbingham has joined #dri-devel
kbingham has quit [Read error: Connection reset by peer]
<jani>
danvet: none of that addresses debugfs files that are not just about displaying information, right?
<jani>
danvet: see i915_debugfs_register() and everything in i915_debugfs_files[]
<jani>
danvet: ditto for display side
elongbug has joined #dri-devel
<jani>
so there's all this new infrastructure we can convert to, yet can't get rid of any of those, leaving us with the separate register step anyway. unless I'm missing something
<danvet>
yeah it's still rather aspirational, hence should and all that
<danvet>
it's about as much should as using devm/drmm
<danvet>
jani, should I add that in the text? i.e. making it clear it's more about new users and filling the gaps
tobiasjakobi has quit []
<danvet>
jani, the main justification really was that drivers shouldn't add random sysfs interfaces to the kdev
<jani>
danvet: ack
<jani>
I mean with this, and I get the motivation about sysfs, and it's way more important
<danvet>
let me try to word-smith something
<danvet>
brain is very much in monday morning mood
<jani>
just be careful, piling on text about debugfs might be counterproductive regarding sysfs
<Lynne>
airlied: I'm impressed that it's even possible and they didn't bake it in
<danvet>
jani, so just current text and let people discover the todo situation about the debugfs side themselves?
<danvet>
since that is also already documented there
dviola has quit [Read error: Connection reset by peer]
<melissawen>
Does anyone know when LPC 2023 will happen?
<Nyaa>
Probably in 2023
<psykose>
given videogame naming schemes, it already happened in 2022
<melissawen>
LOL
<Nyaa>
Does look like they generally aim for October-November, so until they announce otherwise, probably around then
<Nyaa>
psykose, given car model years, they announced it in 2021
<psykose>
;)
Akari has quit [Quit: segmentation fault (core dumped)]
<Nyaa>
I am kind of tempted to attempt making a shader-based h264 decoder, probably would be too slow to bother with though.
<Lynne>
decoding cabac will be like decoding on a pentium mmx
Nyaa has quit [Remote host closed the connection]
Nyaa has joined #dri-devel
<Nyaa>
Lynne, even just having baseline would be better than no implementation
<Lynne>
not when everything that matters uses Main
<Nyaa>
yeah but does that same most stuff use CABAC
ice9 has joined #dri-devel
<Nyaa>
support for a feature does not necessarily mean use of it
<Lynne>
pretty much everything has used cabac in the last 10+ years
<Nyaa>
hmm, youtube still serves at least one format on all videos using baseline still
<Nyaa>
oh nice, at some point google started putting the encoding date into videos
rgallaispou has left #dri-devel [#dri-devel]
aravind has quit [Ping timeout: 480 seconds]
aravind has joined #dri-devel
YuGiOhJCJ has quit [Quit: YuGiOhJCJ]
MajorBiscuit has joined #dri-devel
aravind has quit [Ping timeout: 480 seconds]
MajorBiscuit has quit [Quit: WeeChat 3.6]
MajorBiscuit has joined #dri-devel
ice9 has quit [Read error: Connection reset by peer]
MajorBiscuit has quit [Quit: WeeChat 3.6]
MajorBiscuit has joined #dri-devel
zehortigoza has joined #dri-devel
Cyrinux has quit [Remote host closed the connection]
jdavies has joined #dri-devel
jdavies is now known as Guest820
fxkamd has joined #dri-devel
paulk-bis has joined #dri-devel
paulk has quit [Read error: Connection reset by peer]
Cyrinux has joined #dri-devel
aravind has joined #dri-devel
MajorBiscuit has quit [Quit: WeeChat 3.6]
jewins has joined #dri-devel
frytaped has joined #dri-devel
ice9 has joined #dri-devel
Haaninjo has joined #dri-devel
Siddh[m] is now known as siddh
bgs has joined #dri-devel
fab has quit [Quit: fab]
frytaped has quit [Quit: WeeChat 3.6]
frytaped has joined #dri-devel
frytaped has quit []
frytaped has joined #dri-devel
frytaped has quit []
frytaped has joined #dri-devel
frytaped has quit []
frytaped has joined #dri-devel
frytaped has quit [Quit: WeeChat 3.6]
aravind has quit [Ping timeout: 480 seconds]
epoll has quit [Ping timeout: 480 seconds]
frytaped has joined #dri-devel
Jeremy_Rand_Talos has quit [Remote host closed the connection]
Jeremy_Rand_Talos has joined #dri-devel
<rodrigovivi>
airlied: danvet: what's your views on the future of gitlab flow with the drm drivers? mailing list for a time is kind of unavoidable anyway on the cross dependencies, but do you see drm drivers attempting to move forward with some hybrid model like mesa had for a while accepting PR and patches?
fab has joined #dri-devel
<rodrigovivi>
I'm asking more for the xe perspective since our flow is on gitlab atm, but I believe that we should align with all the other drm drivers instead of having a different flow... i.e. moving towards mailing list asap and having it active on the cgit, like other drivers... or do you see something different? what would be your open recommendation to us?
mbrost has joined #dri-devel
epoll has joined #dri-devel
nehsou^ has quit [Remote host closed the connection]
<danvet>
see also jani's question on whether fd.o can support the load
<danvet>
jani, thx, I hit sent (after some nice workout and even better sauna this afternoon)
<javierm>
danvet: I wonder if a good compromise could be to keep using ML but then instead of pushing directly to drm-misc, to open MRs
stuart has joined #dri-devel
<javierm>
that way the load won't be that much initially and patches could be properly tested through CI before landing
<javierm>
this all could be done transparently by dim, so from drm developers POV, the workflow won't change that much
<danvet>
javierm, I think concern was more when phoronix links to some mr and everyone picks that up
<danvet>
since the load is substanstially more to serve a gitlab mr than a mail archive
<javierm>
danvet: ahhh, I see
<danvet>
but yeah still posting to m-l for review and doing the gitlab mr for CI only at first sounds like one of the intermediate steps that makes some sense
mbrost__ has joined #dri-devel
<danvet>
maybe
srslypascal is now known as Guest838
srslypascal has joined #dri-devel
<javierm>
danvet: yup, I was thinking something like `dim push-branch drm-misc-next` to open a MR under the hood, kind of how gerrit works IIRC
mbrost_ has quit [Ping timeout: 480 seconds]
<danvet>
yeah
<danvet>
maybe combine with b4 for sending the entire pile out or something
<danvet>
for one stop shop
<danvet>
bonus if the cover letter has the link to the m-l submission
<danvet>
*gitlab mr I mean
<javierm>
danvet: yeah
apinheiro has quit [Ping timeout: 480 seconds]
<javierm>
danvet: we do something like that in the fedora kernel package, we open MR in gitlab but there's a bridge that posts to the fedora kernel ML
<danvet>
because then people have that idea that somehow magically m-l comments will land back on gitlab
<danvet>
which just isn't going to happen in a meaningful way
jkrzyszt has quit [Remote host closed the connection]
<danvet>
pls fd.o admins really don't want to be in the mail amplifier business with gitlab :-)
<javierm>
danvet: indeed. What I see that happens with this workflow at the end is that fedora kernel developers just comment on gitlab and most people just ignore the ML :)
<danvet>
yeah
<danvet>
and if we go that way, we need something where gitlab mr are clearly much better than m-l, because if that's not the case, we'll never get a substantial critical mass over there
<danvet>
and I think the best way to sell this is with really good CI, where developers can check results and fairly easily add more (sw-only at least) testcases and stuff
<danvet>
that seems to have been the catnip to move the heard in other projects at least, like mesa
Guest838 has quit [Ping timeout: 480 seconds]
<danvet>
without that all we'll probably achieve is nice fragmentation
<javierm>
danvet: agreed, that's why I think that keep the current ML workflow for easy collaboration with the rest of the kernel but introducing MR and CI pipeline runs before landing is a good compromise
<javierm>
danvet: because we still rely on drm-misc committers to properly test before pushing to drm-misc, and could still introduce build issues and whatnot
jluthra has quit [Remote host closed the connection]
jluthra has joined #dri-devel
cphealy has quit [Ping timeout: 480 seconds]
<danvet>
javierm, yeah mr for pushing would be really good and 100% an improvement
<danvet>
and yeah kernel also has a higher barrier because at best we can only move all of dri-devel
<danvet>
and we do have some substantial interactions
<danvet>
at least medium term I don't think the kernel will move
<javierm>
danvet: agreed
* javierm
dreams of better times where the kernel is all rewritten in rust by using MRs :)
<javierm>
maybe it will happen before I retire...
aravind has quit [Read error: Connection reset by peer]
<rodrigovivi>
danvet: yeap, I agree... the fragmentation is what I'm mostly afraid... and that having a better CI would be the zero ground....
<rodrigovivi>
worst scenario of the fragmentation that I can think of is the new folks just learning github and gitlab flow not having git-email and email clients setup to quick cross collaboration with other subcomponents...
<rodrigovivi>
but also even with old folks... having to alternate the environment is not that trivial and more prune to dummy mistakes
<danvet>
yeah I mean that's the other one
<danvet>
once we have this for maintainer mr and drm-misc pushing
<danvet>
I do think that you probably want to switch both xe and i915
<danvet>
otherwise good luck
alanc has joined #dri-devel
tursulin has quit [Ping timeout: 480 seconds]
ice9 has quit [Ping timeout: 480 seconds]
<rodrigovivi>
yeap, I fully agree! thanks for confirming it ;)
mbrost__ has quit [Read error: Connection reset by peer]
swalker__ has quit [Ping timeout: 480 seconds]
mbrost has joined #dri-devel
mbrost has quit [Remote host closed the connection]
mbrost has joined #dri-devel
jkrzyszt has joined #dri-devel
ice9 has joined #dri-devel
nchery is now known as Guest841
nchery has joined #dri-devel
mbrost has quit [Ping timeout: 480 seconds]
Guest841 has quit [Ping timeout: 480 seconds]
pallavim_ has joined #dri-devel
devilhorns has quit []
Guest820 has quit [Remote host closed the connection]
apinheiro has joined #dri-devel
sarnex has quit [Quit: Quit]
mbrost has joined #dri-devel
sarnex has joined #dri-devel
djbw has joined #dri-devel
cphealy has joined #dri-devel
* airlied
would love to trial drm next MRs if we had CI integrated
<airlied>
Lynne: not sure it isnt hardcoded, trying to find workarounds, older fw had a disable bit but its gone in newer
<DemiMarie>
Is the Xe driver smaller than the i915 driver? If so, why? Is it because tasks that used to be part of the driver are now handled by GuC firmware?
<mlankhorst>
It doesn't support gen11-, so even that makes it smaller
<kisak>
keep in mind that i915 covers 9 generations of hardware
<airlied>
i915 also semi-actively avoided sharing code with other drivers
kts has quit [Quit: Leaving]
<mlankhorst>
plus some features are likely missing :)
jewins has quit [Ping timeout: 480 seconds]
mbrost has quit [Ping timeout: 480 seconds]
Nyaa has quit [Ping timeout: 480 seconds]
alyssa has joined #dri-devel
<alyssa>
jenatali: any idea why MR label bot missed !20578 ?
tzimmermann has quit [Quit: Leaving]
<alyssa>
the bot source seems to know about src/asahi/
<jenatali>
Has someone picked up those changes in the last 2 months?
<jenatali>
Not sure why you pinged me about it
* alyssa
thought the bot was your doing
<alyssa>
does *anyone* know where this bot came from?
<glehmann>
when is the mesa 23.0 branch point? it looks like the release calendar wasn't updated
<zmike>
I think it's weds?
<dcbaker>
wednesday
<anholt>
skipping drafts is not what I would expect of the bot
mia_ has left #dri-devel [#dri-devel]
<karolherbst>
alyssa: yeah.. put it out of draft and then it labels it once, but it never fixes labels later on
<karolherbst>
also
<karolherbst>
notifying people on every draft is a tad too verbose
<dcbaker>
oh poo, I was supposed to send out that update friday
<glehmann>
zmike: dcbaker: ah that's what I thought too, I was just trying to find an official source
<zmike>
<dcbaker> I AM THE SOURCE
<dcbaker>
lol
* dcbaker
will build your source!
Duke`` has quit [Ping timeout: 480 seconds]
pcercuei has quit [Remote host closed the connection]
pcercuei has joined #dri-devel
JoshuaAshton has quit []
Kayden has quit [Quit: to the office (?!)]
JoshuaAshton has joined #dri-devel
Duke`` has joined #dri-devel
JoshuaAshton has quit []
<Lynne>
airlied: btw do you think it's possible to reduce the alignment needed for the bitstream buffer?
<Lynne>
having to pad to 256 bytes is around 100kbps, you can comfortably fit an audio stream in there :)
junaid has joined #dri-devel
<jekstrand>
airlied: Yeah... I'll try to look. Been reading through Xe stuff.
<airlied>
Lynne: for encode maybe?
* airlied
isn't sure what the encode value should be though
JoshuaAshton has joined #dri-devel
<Lynne>
assuming the driver always generates aligned base values for vkbuffers, you can just keep decreasing it until it breaks
<airlied>
Lynne: what does nvidia report?
<airlied>
Lynne: pushed a change to 16 for encode
<airlied>
4 seems to give decode error on SEI type 5 size
<airlied>
Lynne: okay hacky disables for sps/pps don't seem to work, so we might have to await a new fw release for those
<jekstrand>
airlied: Actually, let me knock out video first. That should be fast. Then I can go read ANV Xe code.
jkrzyszt has quit [Ping timeout: 480 seconds]
<Lynne>
airlied: 256 -_-
<Lynne>
you're out of tricks already?
<airlied>
yup actually emitting 0 data size has the same crash as not emitting the packets at all
<airlied>
the slice header emit seems to be going bad without the sps/pps
<Lynne>
really weird
<Lynne>
because with d3d12 video, there isn't an option for the driver to generate SPS/PPS values, everything must be done by the user
heat has joined #dri-devel
<Lynne>
d3d12 encode even offers AQ adjustments, how did khronos plan to compete with that?
ngcortes has joined #dri-devel
lemonzest has quit [Quit: WeeChat 3.6]
<airlied>
Lynne: oh I wonder how the fw does it then
danilo has joined #dri-devel
dakr has quit [Ping timeout: 480 seconds]
<alyssa>
dcbaker: wait so nobody knows where this bot came from
<alyssa>
is this chatgpt's doing
<alyssa>
are we all doomed
<alyssa>
karolherbst: "notifying people on every draft is a tad too verbose"
<alyssa>
Hmm, okay
<dcbaker>
alyssa: lol, I got it fromone of the other Intel Mesa people, I think Marcin, did some work to finish it, and gave it to Daniel
ice9 has quit [Quit: Leaving]
srslypascal is now known as Guest869
ice9 has joined #dri-devel
srslypascal has joined #dri-devel
<jekstrand>
alyssa: It's not ChatGPT or the GitHub thing, either. It was written by an actual person. :-P
<alyssa>
jekstrand: allegedly
<karolherbst>
lol
<karolherbst>
I mean, what the bot is doing is really simple
ahajda has quit [Quit: Going offline, see ya! (www.adiirc.com)]
<alyssa>
karolherbst: allegedly
Guest869 has quit [Ping timeout: 480 seconds]
<karolherbst>
anyway, the bot is on me and daniels 🙃 I was thinking something like that is a nice way of getting MRs of new contributors or ones without access to being labeld automatically so things don't fall through the cracks
gouchi has joined #dri-devel
<alyssa>
karolherbst: yeah, I'm 100% for it
<alyssa>
What I'm more wondering now is whether I can lean on it (vs using it as a last resort or for new contributors)
<karolherbst>
alyssa: it's really simple and it uses paths and/or driver names in titles to label. _sometimes_ if you do 1 loc change in all drivers it's doing the stupid thing and adds labels for everything
<karolherbst>
but generally I think we can rely on it
<alyssa>
I mean. I've definitely done that stupid thing manually :-p
<karolherbst>
and if something doesn't get labeled correctly, we just fix the rules
<karolherbst>
yeah... sometimes it's okay, sometimes it's not.. I think it doens't matter in any case
<karolherbst>
having pinged the wrong people once is worth the benefits here
<alyssa>
agreed
apinheiro has quit [Ping timeout: 480 seconds]
<karolherbst>
we might want to enable it for issues as well, but that's alot harder to do
<alyssa>
yeah
Haaninjo has quit [Quit: Ex-Chat]
<karolherbst>
maybe title only would be okay, but I suspect we still need to label a lot of things manually.. oh well.. worth checking how badly the bot would label issues
<karolherbst>
everybody can run the bot locally with an gitlab API key, it has a dry-run mode so it doesn't change anything
ice9 has quit [Read error: Connection reset by peer]
ice9 has joined #dri-devel
fab has quit [Quit: fab]
Lucretia has quit [Remote host closed the connection]
Lucretia has joined #dri-devel
apinheiro has joined #dri-devel
alyssa has quit [Quit: leaving]
glennk has quit [Remote host closed the connection]
Kayden has joined #dri-devel
glennk has joined #dri-devel
mbrost has quit [Remote host closed the connection]
mbrost has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
ice9 has quit [Ping timeout: 480 seconds]
mbrost has quit [Ping timeout: 480 seconds]
bgs has quit [Remote host closed the connection]
danilo has quit []
dakr has joined #dri-devel
junaid has quit [Ping timeout: 480 seconds]
mbrost has joined #dri-devel
bgs has joined #dri-devel
bgs has quit [Remote host closed the connection]
Akari has joined #dri-devel
nchery is now known as Guest881
nchery has joined #dri-devel
Guest881 has quit [Ping timeout: 480 seconds]
mvlad has quit [Remote host closed the connection]
gouchi has quit [Remote host closed the connection]