<Marijn[m]>
I prepped a patch earlier, hope to send it to show you what I have in mind
<Marijn[m]>
I just don't remember if the driver implements power domain voting
<Marijn[m]>
Or if that's something implicit after calling pm ops
<Marijn[m]>
Unfortunately though my sm6125 device seems to have stopped working somewhere with v6.0-rc7. Works again after removing fw_devlink=off, but I needed that to get the display to initialize properly amidst the recursive dependencies between dispcc and dsi phys. More issues to resolve...
pevik has quit [Quit: Lost terminal]
pevik has joined #linux-msm
<aka_[m]>
I will probably just compile-test dpu patch because i know it was working on 5.19 and I don't really want to dig in 6.1 either
<aka_[m]>
Issue is if I want to send mdss yaml I have to be sure if compatibles are okish, and I don't know how it will sort out.
<lumag>
aka_[m], regarding dsi compatibles. good question. I'd say, do so and let krzk complain if he thinks this is not the correct way
<lumag>
Regarding the VDDMX. Usually you can ignore MX and CX, up to the point when you start caring about the proper suspend/resume cycles.
<lumag>
So, if there is no separate MMCX domain, I'd say, feel free to ignore the power-domains = <SM6115_VDDfoo> for now.
<lumag>
This is of course not the case if you need to _switch_ levels basing on the frequency.
<Marijn[m]>
lumag: does any of the dsi/dsiphy/dsiphypll currently control power domains?
<Marijn[m]>
Switching levels would use opp tables?
<lumag>
aka_[m], regarding the qcm2290-mdss.yaml. Please send the patch
<lumag>
Marijn[m], yes. dsi definitely has the opp table. It casts different votes on MMCX or CX domains
<lumag>
depending on the device
<aka_[m]>
Well on ours we have vddmx
<aka_[m]>
No separate mm one
<lumag>
aka_[m], if the mx is to be upvoted basing on pll freq changes, then you need the dsi_opp_table & the rest
<aka_[m]>
Wait, we mean MX on phy not dsi
<lumag>
aka_[m], we don't have separate power domains on the PHY.
<aka_[m]>
Qcm have regulator in phy binding yet ds points it to MX
<aka_[m]>
That's what we wonder about
<lumag>
Ah.
<lumag>
Which kernel baseline was used for 6115?
<lumag>
4.?
<aka_[m]>
4.19 for caf
<lumag>
It is trinklet, isn't it?
<aka_[m]>
No
<aka_[m]>
Trinket is 4.14
<aka_[m]>
665
<aka_[m]>
Scuba=qcm, bengal=662, khaje=680
<lumag>
Yeah, too may similar numbers. The mail you've pointed above was talking about 6125
<Marijn[m]>
Trinket is sm6125, the soc I'm working on
<lumag>
ok, 6115. Let me check
* lumag
starts to wander, why does qcm2290 list vdda-supplies too
<Marijn[m]>
lumag: fwiw there's a regulator or power domain in _both_ the dsi _and_ dsi phy
<lumag>
Marijn[m], hmm, I don't see one. DSI has 1p2 regulator and a refgen. DSI PHY has only MX regulator
<lumag>
And the PLL uses mdss_core "regulator"
<lumag>
I have asked Loic and Shawn, as they were working on qcm.
<lumag>
I think (just my assumption) that you can skip MX for now. It is not used for during frequency switching (DSI should use CX for it)
<Marijn[m]>
lumag: I'll doublecheck my downstream sources which node got which regulator/PD and get back to you
<lumag>
I checked the Redmi Note 8 schematic, which can be found in the Internet. The device uses sm6125 (trinklet) platform. The vdda_dsi and vdda_dsi_pll are powered by l18a. The vdda_dsi_0p9 is powered only with the S5A = MX.
<lumag>
Ok. As this is an external voltage supply, please specify the 'power-domains = <&something_MX>;' and add a note in the file (or in the commit message) that the DSI PHY is powered on by the regulator providing MX power domain.
<lumag>
And yes, now I start to wander whether the qcm dsi phy configuration is correct or not
<lumag>
Just for the reference. I'd put this power-domain into the board's dts file, like we put all DSI/PHY/etc. regulators.
<Marijn[m]>
lumag: Yes, downsteam DT makes it impossible to figure out what is SoC specific and what is board specific thanks to vendors just editing all over the place
<lumag>
Another option: follow the sc7180 example. It lists vdds (the pll) as the only supplier of the DSI PHY. However according to the atoll-sde.dtsi, the DSI PLL is also powered by MX.
<lumag>
... the DSI PHY is also powered by MX
<aka_[m]>
Dsi pll, phy, ctrl it's getting confusing there
<lumag>
aka_[m], DSI ctrl - is the main supply for the dsi host. It is the one found in the dsi@N node upstream.
<lumag>
DSI PHY is the supply powering on the DSI PHY block. This is the one for which you see the 'MX' source.
<lumag>
Sometimes it is not present at all.
<lumag>
Sometimes it is regulated by the proper regulator. On some platforms it is regulted by the same regulator as the dsi ctrl.
<lumag>
DSI PLL is a separate regulator driving the PLL logic inside the DSI PHY.
<lumag>
This is the one you see in the SoC-sde-pll.dtsi downstream
pevik has quit [Ping timeout: 480 seconds]
pevik has joined #linux-msm
jhovold has quit [Ping timeout: 480 seconds]
duuooosla[m] has quit [Write error: connection closed]
travmurav[m] has quit [Write error: connection closed]
ungeskriptet[m] has quit [Write error: connection closed]
minecrell[m] has quit [Write error: connection closed]
Guest603 has quit [Write error: connection closed]
ivoszbg[m] has quit [Write error: connection closed]
FieryFlames[m] has quit [Write error: connection closed]
alikateshethey[m] has quit [Write error: connection closed]
vknecht[m] has quit [Write error: connection closed]
underpantsgnome[m] has quit [Write error: connection closed]
Bazsalanszky[m] has quit [Write error: connection closed]
fevv8[m] has quit [Write error: connection closed]
AffeNull[m] has quit [Write error: connection closed]
MartinBotka[m] has quit [Remote host closed the connection]
Syboxez[m] has quit [Write error: connection closed]
RayyanAnsari[m] has quit [Write error: connection closed]
z3ntu has quit [Write error: connection closed]
JoelSelvaraj[m] has quit [Write error: connection closed]
ichernev[m] has quit [Write error: connection closed]
M0[m]1 has quit [Write error: connection closed]
flamingradian[m] has quit [Write error: connection closed]
DylanVanAssche has quit [Write error: connection closed]
DavidHeidelberg[m] has quit [Write error: connection closed]
MatrixTravelerbot[m]1 has quit [Write error: connection closed]
IvanBelokobylskiy[m] has quit [Write error: connection closed]
cosm0[m] has quit [Write error: connection closed]
peremen[m] has quit [Write error: connection closed]
RayyanAnsarimatrixorg[m] has quit [Write error: connection closed]
Leandro[m] has quit [Write error: connection closed]
mirsal has quit [Write error: connection closed]
konradybcio has quit [Write error: connection closed]
kholk[m] has quit [Write error: connection closed]
jojo_autoboy[m] has quit [Write error: connection closed]
aka_[m] has quit [Write error: connection closed]
cmeerw[m] has quit [Write error: connection closed]
frytaped[m] has quit [Write error: connection closed]
Newbyte has quit [Write error: connection closed]
Tooniis[m] has quit [Write error: connection closed]
AntoniAloyTorrens[m] has quit [Write error: connection closed]
sepkov[m] has quit [Write error: connection closed]
wfranken[m] has quit [Write error: connection closed]
maxim[m] has quit [Write error: connection closed]
undev[m] has quit [Write error: connection closed]
ajhalaney[m] has quit [Write error: connection closed]
Marijn[m] has quit [Write error: connection closed]
aedancullen has quit [Write error: connection closed]
Mis012[m] has quit [Write error: connection closed]
AntoniAloyTorrens[m] has joined #linux-msm
aedancullen has joined #linux-msm
AffeNull[m] has joined #linux-msm
ajhalaney[m] has joined #linux-msm
aka_[m] has joined #linux-msm
alikateshethey[m] has joined #linux-msm
Bazsalanszky[m] has joined #linux-msm
Leandro[m] has joined #linux-msm
cmeerw[m] has joined #linux-msm
cosm0[m] has joined #linux-msm
duuooosla[m] has joined #linux-msm
DylanVanAssche has joined #linux-msm
fevv8[m] has joined #linux-msm
FieryFlames[m] has joined #linux-msm
flamingradian[m] has joined #linux-msm
frytaped[m] has joined #linux-msm
M0[m]1 has joined #linux-msm
Guest755 has joined #linux-msm
ichernev[m] has joined #linux-msm
IvanBelokobylskiy[m] has joined #linux-msm
ivoszbg[m] has joined #linux-msm
JoelSelvaraj[m] has joined #linux-msm
jojo_autoboy[m] has joined #linux-msm
kholk[m] has joined #linux-msm
konradybcio has joined #linux-msm
z3ntu has joined #linux-msm
Marijn[m] has joined #linux-msm
maxim[m] has joined #linux-msm
minecrell[m] has joined #linux-msm
mirsal has joined #linux-msm
Mis012[m] has joined #linux-msm
Newbyte has joined #linux-msm
DavidHeidelberg[m] has joined #linux-msm
peremen[m] has joined #linux-msm
RayyanAnsarimatrixorg[m] has joined #linux-msm
RayyanAnsari[m] has joined #linux-msm
MartinBotka[m] has joined #linux-msm
sepkov[m] has joined #linux-msm
Syboxez[m] has joined #linux-msm
underpantsgnome[m] has joined #linux-msm
Tooniis[m] has joined #linux-msm
travmurav[m] has joined #linux-msm
undev[m] has joined #linux-msm
ungeskriptet[m] has joined #linux-msm
vknecht[m] has joined #linux-msm
MatrixTravelerbot[m]1 has joined #linux-msm
wfranken[m] has joined #linux-msm
Mis012[m] has quit [Remote host closed the connection]
kholk[m] has quit [Remote host closed the connection]
cosm0[m] has quit [Remote host closed the connection]
wfranken[m] has quit [Remote host closed the connection]
alikateshethey[m] has quit [Remote host closed the connection]
Tooniis[m] has quit [Remote host closed the connection]
ivoszbg[m] has quit [Remote host closed the connection]
flamingradian[m] has quit [Remote host closed the connection]
underpantsgnome[m] has quit [Remote host closed the connection]
Guest755 has quit [Write error: connection closed]
RayyanAnsari[m] has quit [Remote host closed the connection]
JoelSelvaraj[m] has quit [Remote host closed the connection]
Bazsalanszky[m] has quit [Remote host closed the connection]
Leandro[m] has quit [Remote host closed the connection]
undev[m] has quit [Remote host closed the connection]
AffeNull[m] has quit [Remote host closed the connection]
DylanVanAssche has quit [Remote host closed the connection]
frytaped[m] has quit [Write error: connection closed]
RayyanAnsarimatrixorg[m] has quit [Remote host closed the connection]
ungeskriptet[m] has quit [Write error: connection closed]
travmurav[m] has quit [Write error: connection closed]
minecrell[m] has quit [Write error: connection closed]
FieryFlames[m] has quit [Write error: connection closed]
vknecht[m] has quit [Write error: connection closed]
peremen[m] has quit [Write error: connection closed]
cmeerw[m] has quit [Write error: connection closed]
ichernev[m] has quit [Write error: connection closed]
DavidHeidelberg[m] has quit [Write error: connection closed]
konradybcio has quit [Write error: connection closed]
Marijn[m] has quit [Write error: connection closed]
aedancullen has quit [Write error: connection closed]
MartinBotka[m] has quit [Remote host closed the connection]
maxim[m] has quit [Remote host closed the connection]
IvanBelokobylskiy[m] has quit [Remote host closed the connection]
MatrixTravelerbot[m]1 has quit [Write error: connection closed]
Syboxez[m] has quit [Remote host closed the connection]
jojo_autoboy[m] has quit [Remote host closed the connection]
sepkov[m] has quit [Remote host closed the connection]
M0[m]1 has quit [Remote host closed the connection]
aka_[m] has quit [Remote host closed the connection]
Newbyte has quit [Remote host closed the connection]
fevv8[m] has quit [Write error: connection closed]
duuooosla[m] has quit [Write error: connection closed]
z3ntu has quit [Write error: connection closed]
AntoniAloyTorrens[m] has quit [Write error: connection closed]
ajhalaney[m] has quit [Write error: connection closed]