alyssa changed the topic of #panfrost to: Panfrost - FLOSS Mali Midgard + Bifrost + Valhall - Logs https://oftc.irclog.whitequark.org/panfrost - I don't know anything about WSI. That's my story and I'm sticking to it.
floof58 has quit [Remote host closed the connection]
floof58 has joined #panfrost
indy has joined #panfrost
Danct12 has joined #panfrost
Danct12 has quit [Quit: Quitting]
samuelig_ is now known as samuelig
rasterman has joined #panfrost
MajorBiscuit has joined #panfrost
Danct12 has joined #panfrost
Danct12 has quit []
guillaume_g has joined #panfrost
<q4a>
alyssa: hi. I saw your comment in MR and not sure about understanding `Failing to respect the start parameter` - there is `assert(start_slot == 0);`
<q4a>
I should remove this assert and add start_slot where it needed?
q4a has quit [Read error: Connection reset by peer]
q4a has joined #panfrost
pendingchaos_ has joined #panfrost
pendingchaos has quit [Ping timeout: 480 seconds]
pendingchaos has joined #panfrost
pendingchaos_ has quit [Ping timeout: 480 seconds]
MajorBiscuit has quit [Ping timeout: 480 seconds]
pendingchaos has quit [Ping timeout: 480 seconds]
pendingchaos has joined #panfrost
MajorBiscuit has joined #panfrost
ggardet has joined #panfrost
guillaume_g has quit [Ping timeout: 480 seconds]
paulk-ter has quit [Ping timeout: 480 seconds]
alpernebbi has quit [Ping timeout: 480 seconds]
alpernebbi has joined #panfrost
<alyssa>
q4a: Yep :)
<alyssa>
I don't think that assert is valid for gallium nine (though I might be wrong)
<q4a>
Ok. I pushed v2 of the patch.
floof58 has quit [Ping timeout: 480 seconds]
floof58 has joined #panfrost
paulk-ter has joined #panfrost
guillaume_g has joined #panfrost
<q4a>
Pushed v3 of the patch.
<alyssa>
and queued for merge :-)
ggardet has quit [Ping timeout: 480 seconds]
<q4a>
alyssa: thx. Marge will add your RB?
<alyssa>
nah, we don't use r-b's much in panfrost anymore
<alyssa>
the fact I assigned to Marge signals that I reviewd it and approve :)
<q4a>
Cool. Thanks!
<alyssa>
I'm always interested in lowering the barriers and friction of contributing
<alyssa>
and applying r-b tags is one of those shibboleths that's only easy for Ye Olde Mesa developers who have shell aliases to apply tags from other people automatically
<alyssa>
They made sense when we used the mailing list for development, had no CI, no Marge, and developers pushed directly to main
<alyssa>
Nowadays we have all discussion on GitLab, all merging happens via Marge, commits merged via Marge link back to the GitLab thread automatically, and the act of assigning to Marge is recorded in GitLab
<alyssa>
Which means there's a built-in audit trail
<alyssa>
"How did this commit get merged? Oh, it says Part-of: this MR, and I click the MR and it says @alyssa assigned to Marge. So Alyssa ack'd it, sounds good."
paulk has joined #panfrost
paulk-ter has quit [Read error: Connection reset by peer]
<anarsoul>
alyssa: one extra step to find who's to blame!
<alyssa>
anarsoul: exactly ;)
Daanct12 is now known as Danct12
Leopold_ has quit [Remote host closed the connection]
Leopold_ has joined #panfrost
BarbGarb has joined #panfrost
<alyssa>
i hate custom border colours
MajorBiscuit has quit [Ping timeout: 480 seconds]
greenjustin_ has joined #panfrost
greenjustin_ has quit [Ping timeout: 480 seconds]
floof58 is now known as Guest2010
floof58 has joined #panfrost
Guest2010 has quit [Ping timeout: 480 seconds]
<robmur01>
alyssa: ...and with clear temporal order to boot! As opposed to me looking at a buggy commit in Linux, thinking "huh, I reviewed this?", then digging through the list archives to piece together that I'd reviewed v4, and the bug was introduced in v5, which I hadn't looked closely at since it had my R-b tag on :/