ChanServ changed the topic of #wayland to: https://wayland.freedesktop.org | Discussion about the Wayland protocol and its implementations, plus libinput | register your nick to speak
immibis has quit [Remote host closed the connection]
Lyude has quit [Read error: Connection reset by peer]
Lyude has joined #wayland
co1umbarius has joined #wayland
columbarius has quit [Ping timeout: 480 seconds]
dcz_ has quit [Ping timeout: 480 seconds]
Arnavion has quit [Ping timeout: 480 seconds]
Arnavion has joined #wayland
txtsd has joined #wayland
CodeSpelunker has joined #wayland
hill has joined #wayland
Arnavion has quit [Ping timeout: 480 seconds]
Ariadne has quit [Remote host closed the connection]
JPEW has quit [Remote host closed the connection]
Company has quit [Quit: Leaving]
JPEW has joined #wayland
CodeSpelunker has quit [Ping timeout: 480 seconds]
Ariadne has joined #wayland
CodeSpelunker has joined #wayland
nerdopolis has quit [Ping timeout: 480 seconds]
rpigott has quit [Remote host closed the connection]
Arnavion has joined #wayland
mclasen_ has quit [Ping timeout: 480 seconds]
rpigott has joined #wayland
CodeSpelunker has quit [Remote host closed the connection]
CodeSpelunker has joined #wayland
CodeSpelunker has quit [Remote host closed the connection]
CodeSpelunker has joined #wayland
hill has quit [Remote host closed the connection]
hill has joined #wayland
hill has quit [Remote host closed the connection]
hill has joined #wayland
hardening has joined #wayland
tzafrir_laptop has quit [Quit: No Ping reply in 180 seconds.]
tzafrir has joined #wayland
CodeSpelunker has quit [Quit: CodeSpelunker]
tzafrir has quit [Quit: No Ping reply in 180 seconds.]
tzafrir has joined #wayland
rv1sr has joined #wayland
dcz_ has joined #wayland
Hypfer has quit [Quit: Ping timeout (120 seconds)]
<daniels>
pq: errrr, untangling mappedness involves pulling apart a lot more of libweston-desktop than I'm really comfortable with right now
<daniels>
I'm happy to start doing it gradually, but would like to push the fix to make it not crash atm
<daniels>
pq: basically, subsurfaces will map themselves when they have a valid buffer but never unmap themselves
<daniels>
all other shells will mostly just be mapped on the first commit call, whether or not they should be
plantain has joined #wayland
<daniels>
I'm having a go at a couple of approaches to fix this, but none of them seem like they'll be easy or quick - I'd rather try to deal with it bit by bit in a more easily bisectable & reviewable way
plantain has quit []
<daniels>
weston_surface_unmap() does indeed unmap the views, but there's nothing really to ensure that surfaces are only mapped when we have buffers, and there's also no surface-mapped signal to let users only map views when the surface is mapped
<daniels>
we could of course just handle that in ->committed(), but in terms of API design I think there's nothing wrong with having views mapped when surfaces are not mapped, as long as they're consistently ignored