ChanServ changed the topic of #wayland to: https://wayland.freedesktop.org | Discussion about the Wayland protocol and its implementations, plus libinput | register your nick to speak
Leopold_ has quit [Remote host closed the connection]
ybogdano has quit [Ping timeout: 480 seconds]
Leopold_ has joined #wayland
gschwind_ has quit []
NepNepdmsalwaysopen[m] has joined #wayland
test has joined #wayland
co1umbarius has joined #wayland
columbarius has quit [Ping timeout: 480 seconds]
Seirdy has quit [Ping timeout: 480 seconds]
Seirdy has joined #wayland
test has left #wayland [#wayland]
floof58 has quit [Remote host closed the connection]
floof58 has joined #wayland
Leopold_ has quit []
aswar002 has joined #wayland
Leopold_ has joined #wayland
Leopold_ has quit [Remote host closed the connection]
Leopold_ has joined #wayland
Leopold_ has quit [Remote host closed the connection]
gspbirel56 has quit [Read error: Connection reset by peer]
gspbirel56 has joined #wayland
junaid has joined #wayland
hardening has joined #wayland
jgrulich has joined #wayland
danvet has joined #wayland
junaid has quit [Ping timeout: 480 seconds]
evon377887 has quit [Ping timeout: 480 seconds]
dcz_ has joined #wayland
reductum has quit [Quit: WeeChat 2.8]
junaid has joined #wayland
tzimmermann has joined #wayland
junaid has quit [Quit: leaving]
junaid has joined #wayland
manuel1985 has joined #wayland
junaid has quit [Read error: Connection reset by peer]
junaid has joined #wayland
mvlad has joined #wayland
manuel1985 has quit [Remote host closed the connection]
manuel1985 has joined #wayland
gschwind has joined #wayland
junaid has quit [Quit: leaving]
junaid has joined #wayland
jgrulich has quit [Remote host closed the connection]
jgrulich has joined #wayland
junaid has quit [Ping timeout: 480 seconds]
MajorBiscuit has joined #wayland
AJ_Z0 has quit [Read error: Connection reset by peer]
AJ_Z0 has joined #wayland
rasterman has joined #wayland
gschwind has quit [Remote host closed the connection]
gschwind has joined #wayland
devilhorns has joined #wayland
<gschwind>
Hello, we meet an issue within FreeRDP client under wayland were compositors seems to not comply to the expectect interraction between wl_pointer::set_cursor specification and wl_surface::attach
<jadahl>
gschwind: can you expand on what interaction you're referring to?
<gschwind>
for exemple gnome seems to ignore the buffer offset provided when wl_surface::attach, while some other compositor ignore the hot_point in wl_pointer::set_cursor
<gschwind>
while the spec say : Its top-left corner is always at (x, y) - (hotspot_x, hotspot_y), where (x, y) are the coordinates of the pointer location, in surface-local coordinates
<gschwind>
and : On surface.attach requests to the pointer surface, hotspot_x and hotspot_y are decremented by the x and y parameters passed to the request. Attach must be confirmed by wl_surface.commit as usual.
<gschwind>
for me it's seems quite clear but maybe I miss understood something
<gschwind>
thus for me I expect : mouse_position - hotspot + buffer_offset
<gschwind>
as position of the painted buffer
<emersion>
wl_surface.attach offset is a bit weird
<emersion>
it… accumulates over commits
<emersion>
if you attach with an offset, then set_cursor, then the offset is ignored
<emersion>
if you perform two commits with an offset of 1, then the final effective offset is 2
<emersion>
i'm sure you can find compositor bugs
<gschwind>
emersion, is it expected behaviours ?
<emersion>
the compositor bugs? no
<emersion>
the weird wl_surface offset semantics? yes
<gschwind>
emersion, but if I attach a new buffer, the offset is reset ?
<emersion>
no
<emersion>
wl_surface offset is always relative to the previous position
<emersion>
only set_cursor can reset it
<gschwind>
thus you have to create a new surface to get rid of the offset
<emersion>
or remember what the accumulated offset is client-side, to cancel it out
<gschwind>
emersion, I'm puzzeled, how should the set_cursor reset the offset ?
<emersion>
set_cursor takes a hotspot arg
<emersion>
so, if you set_cursor(42, 42), then commit the surface with offset(1, 1), then set_cursor(12, 12)
<emersion>
the effective hotspot is 12, 12
<emersion>
at the end
<emersion>
set_cursor replaces whatever the previous hotspot was
<gschwind>
yes, but the surface offset still 1,1
<jadahl>
gschwind: ignoring all the head aches of dealing with offsets, why do you need to set both the hotspot and the offset? why is setting the hotspot alone not enough?
<gschwind>
jadahl, the issue is the inconsistent behaviours
<emersion>
gschwind: there is no "the surface offset"
<gschwind>
amoung compositors
<jadahl>
gschwind: i assume at least the hotspot should work on all compositors since that is what 99.9% of existing users do
<emersion>
the offset is tied to a commit, and goes away after that
<gschwind>
jadahl, it seems not :) I have some dev getting other behaviours :)
<kennylevinsen>
you see inconsistent behaviors when only using hotspot and not offset?
<jadahl>
gschwind: note that gtk, qt, and all other clients use the hotspot in the cursors and there has been no bug reports about this and it definitely works in all those cases
<gschwind>
jadahl, I will try by myself if I have time to check, but I trust you :)
<gschwind>
jadahl, but currently gnome to not implement what I do understand from the spec anyway
<jadahl>
gschwind: the resize thing seems unrelated anyhow
<gschwind>
jadahl, if you look at the bug I just submited few image to show the issue
<gschwind>
jadahl, yes, I agree that cursor buffer scale seems unrelated
<gschwind>
and currently I treat both separately
<jadahl>
gschwind: w
<jadahl>
*will check
ybogdano has joined #wayland
<gschwind>
jadahl, if you miss, I understood that the position of the top-left coner of the cursor buffer is computed as mouse_position - hotspot + buffer_offset
adia4 has joined #wayland
adia has quit [Read error: Connection reset by peer]
adia4 has quit []
luna has joined #wayland
Ampera has left #wayland [#wayland]
Ampera has joined #wayland
Ampera has left #wayland [#wayland]
<gschwind>
jadahl, you want to reproduce the bug of alpha scaling ?
luna has quit []
ybogdano has quit [Ping timeout: 480 seconds]
Ampera has joined #wayland
<gschwind>
because in that case I can provide a wayland client that trigger the bug
<jadahl>
gschwind: yes, but still can't get wlfreerdp to not draw its own cursor
<jadahl>
(using your branch taht adds the bars)
<gschwind>
jadahl, Yes I know, but I have a basic client that trigger the issue I think
<gschwind>
I just update it and cleanup it to share it
<gschwind>
and provide similar output
<gschwind>
but I think you will have to way few days :)
<gschwind>
othewise you need to setup xrdp (or maybe window rdp ?)
<gschwind>
I do not know other rdp servers
<jadahl>
I have weston's rdp backend and gnome-remote-desktop as available rdp servers
<gschwind>
jadahl, yes but I tryed weston, and I think the choise of uploading the cursor to the client is on server side, and weston do server side cursor
<gschwind>
but the issue is not related to RDP or freerdp, thus I made a wayland client that draw a basic cursor and submit it to the compositor
<jadahl>
gschwind: fwiw, if its using wl_surface.attach(.. nonzero dx/dy) thats a known issue, mostly because it has had no known users so noone bothered dealing with it
<jadahl>
also since there isn't really any practical reason of using offsets with cursors other perhaps animating with a hanging hotspot
<gschwind>
jadahl, Ok, if you look at wlfreerdp, they use dx/dy and if they remove it akallabeth[m] get wrong posisionning with the gnome sited above
<jadahl>
looking at wlfreerdp it seems you do both (attach with inverted offset, commit, then after that set_cursor which I think would discard any offset you did before)
<gschwind>
jadahl, but as reported it's not the case :D
<gschwind>
at less for older gnome version, my version is not affected
junaid_ has joined #wayland
manuel_ has quit [Ping timeout: 480 seconds]
<jadahl>
gschwind: think I managed to reproduce with gnome-remote-desktop
<gschwind>
jadahl, the fun fact is that gnome-screenshot actually render the cursor properly :D
ybogdano has joined #wayland
Lucretia has quit [Read error: Connection reset by peer]
___nick___ has joined #wayland
MajorBiscuit has quit [Ping timeout: 480 seconds]
Lucretia has joined #wayland
smallville7123 is now known as Guest1588
smallville7123 has joined #wayland
Guest1588 has quit [Ping timeout: 480 seconds]
small has joined #wayland
smallville7123 is now known as Guest1589
small is now known as smallville7123
Guest1589 has quit [Ping timeout: 480 seconds]
devilhorns has quit [Quit: Leaving]
___nick___ has quit []
___nick___ has joined #wayland
___nick___ has quit []
___nick___ has joined #wayland
d_ed has quit [Ping timeout: 480 seconds]
smallville7123 has quit [Read error: Connection reset by peer]
smallville7123 has joined #wayland
jmdaemon has joined #wayland
gschwind has quit [Quit: Leaving]
rasterman has quit [Quit: Gettin' stinky!]
tzimmermann has quit [Quit: Leaving]
opotin has joined #wayland
rodrgz has joined #wayland
smallville7123 has quit [Ping timeout: 480 seconds]
<LaserEyess>
I think I've asked this before, but does a toy (very basic, only designed to implement that protocol) client implementaiton count towards implementations?
<emersion>
nope
jgrulich has quit [Ping timeout: 480 seconds]
Leopold_ has quit [Remote host closed the connection]
Leopold_ has joined #wayland
junaid has quit [Ping timeout: 480 seconds]
junaid_ has quit [Ping timeout: 480 seconds]
MajorBiscuit has joined #wayland
d_ed has joined #wayland
junaid has joined #wayland
junaid_ has joined #wayland
MajorBiscuit has quit [Ping timeout: 480 seconds]
junaid_ has quit []
d_ed has quit [Ping timeout: 480 seconds]
junaid has quit [Remote host closed the connection]
ybogdano has quit [Ping timeout: 480 seconds]
Sachiel has quit [Ping timeout: 480 seconds]
ybogdano has joined #wayland
ids1024 has joined #wayland
Sachiel has joined #wayland
dcz_ has quit [Ping timeout: 480 seconds]
bluebugs has quit [Ping timeout: 480 seconds]
___nick___ has quit [Ping timeout: 480 seconds]
rgallaispou1 has joined #wayland
rgallaispou has quit [Read error: No route to host]
floof58 has quit [Read error: No route to host]
floof58 has joined #wayland
rgallaispou1 has quit [Read error: Connection reset by peer]
rgallaispou has joined #wayland
mvlad has quit [Remote host closed the connection]