<sven>
I guess it’s for the t2 where the whole nvmmu doesn’t make much sense
<sven>
And there nvme is attached over pcie so you “just” need a few quirks to the normal driver to make it work in that mode
gladiac is now known as Guest6447
gladiac has joined #asahi-dev
gladiac has quit []
gladiac has joined #asahi-dev
Guest6447 has quit [Ping timeout: 480 seconds]
gladiac is now known as Guest6448
gladiac has joined #asahi-dev
Guest6448 has quit [Ping timeout: 480 seconds]
the_lanetly_052___ has quit [Ping timeout: 480 seconds]
aleasto has quit [Remote host closed the connection]
gladiac is now known as Guest6452
gladiac has joined #asahi-dev
Guest6452 has quit [Ping timeout: 480 seconds]
nsklaus has quit [Quit: WeeChat 3.3]
klaus has joined #asahi-dev
<marcan>
maz: so in apple-pcie, we don't actually do anything with the max link speed
<marcan>
also there's some extra stuff that has to happen with the designware registers to make it train at the right speed on the first go (ASPM ends up making it retrain anyway, but that's after linux complains about a speed bottleneck)
<marcan>
remind me again why we aren't reusing any code from drivers/pci/controller/dwc? It's the same registers for the parts that are shared...
<marcan>
(that codebase does the speed dance properly that apple-pcie doesn't)
<kettenis>
the existing dwc code has the 1 contoller 1 port assumption throughly built in
<kettenis>
s/throughly/thoroughly/
Dcow has quit [Quit: My Mac Mini has gone to sleep. ZZZzzz…]
<marcan>
I kind of hate that. It's poking config space registers, but since this is before the PCI bus gets initialized, we can't use the usual accessors...
<marcan>
Also, the pmgr stuff in t6000/bringup-work is what I'm going to send as v3, modulo I need to do a final check to make sure I didn't do anything silly :)
<marcan>
main changes are I enable auto-PM now (unconditionally, seems to be fine) and also force on "always-on" things that aren't, but complain. There's also a bit of cleanup/fixes, and also the t6000 compatible in the bindings.
<marcan>
also I'm outright adding the entire t8103 pmgr tree instead of just a subset
<kettenis>
marcan: some of the link speed related setup is actually done by the tunables applied by m1n1
<marcan>
not this one though
<marcan>
you get this: [ 0.266469] pci 0000:02:00.0: 2.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s PCIe x1 link at 0000:00:01.0 (capable of 4.000 Gb/s with 5.0 GT/s PCIe x1 link)
<marcan>
because without PORT_LOGIC_SPEED_CHANGE preset (can be done before initial link training), it just comes up at Gen1
<marcan>
the max speed thing is tangential, it defaults to Gen4 but still comes up at Gen1 without that bit
jkkm has quit [Remote host closed the connection]
cptcobalt has quit [Remote host closed the connection]
nkaretnikov has quit [Remote host closed the connection]
nathanchance has quit [Remote host closed the connection]
jabashque has quit [Remote host closed the connection]
weems_ has quit [Remote host closed the connection]
brinly has quit [Remote host closed the connection]
austriancoder has quit [Ping timeout: 480 seconds]
esden has quit [Ping timeout: 480 seconds]
philpax has quit [Ping timeout: 480 seconds]
tom-w has quit [Ping timeout: 480 seconds]
robher has quit [Ping timeout: 480 seconds]
kendfinger has quit [Ping timeout: 480 seconds]
Chainsaw has quit [Ping timeout: 480 seconds]
Ariadne has quit [Ping timeout: 480 seconds]
sjg1 has quit [Ping timeout: 480 seconds]
arnd_ has quit [Ping timeout: 480 seconds]
daniels has quit [Ping timeout: 480 seconds]
<kettenis>
marcan: since you rebased the PMGR stuff on top of a tree that has more stuff than what has been submitted upstream so far, the bits that actually add the nodes to the device tree won't apply
<kettenis>
not really a problem since you're probably going to end up applying those yourself
Dcow has joined #asahi-dev
<kettenis>
otherwise it looks good
weems_ has joined #asahi-dev
tardyp has joined #asahi-dev
brinly has joined #asahi-dev
NekomimiScience has joined #asahi-dev
jabashque has joined #asahi-dev
arnd_ has joined #asahi-dev
kendfinger has joined #asahi-dev
esden has joined #asahi-dev
robher has joined #asahi-dev
sjg1 has joined #asahi-dev
daniels has joined #asahi-dev
cptcobalt has joined #asahi-dev
jkkm has joined #asahi-dev
nkaretnikov has joined #asahi-dev
Chainsaw has joined #asahi-dev
nathanchance has joined #asahi-dev
philpax has joined #asahi-dev
Ariadne has joined #asahi-dev
austriancoder has joined #asahi-dev
tom-w has joined #asahi-dev
maor26 has joined #asahi-dev
thunfisch has quit [Remote host closed the connection]
thunfisch has joined #asahi-dev
thunfisch has quit [Remote host closed the connection]
thunfisch has joined #asahi-dev
thunfisch is now known as Guest6468
thunfisch has joined #asahi-dev
Guest6468 has quit [Ping timeout: 480 seconds]
thunfisch has quit [Remote host closed the connection]
<jannau>
another potential difference is that iboot doesn't detect my display but we should be good if you tested without display connected. also unclear how it would be related
RealityVoid has quit [Remote host closed the connection]
RealityVoid has joined #asahi-dev
<marcan>
I did test without display
<marcan>
I need to get some sleep, but I'll try updating to 12.0.1 tomorrow
<marcan>
not seeing anything obvious in the pmgr dump :/
<marcan>
you could try removing pmgr nodes and seeing if it works at some point
<marcan>
though I think you aren't even at the point where it starts turning things off
<marcan>
so I really don'tknow
<j_ey>
marcan: I thought you woke up early.. lol
<marcan>
yeah... this cold has also screwed up my sleep schedule