<rqou_>
idk if this is the same thing or just a naming clash, but "piodma" in the context of AVD and the hardware scaler refers to an actual piece of hardware that can copy data to/from hardware registers according to memory descriptors
nulltemp[m] has joined #asahi-dev
AnushervonTabarov[m] has joined #asahi-dev
<rqou_>
for AVD this is actually used, but for the scaler it does not appear to be used (but the driver contains code for it)
<rqou_>
i have tested the AVD one with a hardware test, but i have not personally tested the scaler one (but the "shape" of the register interface is definitely identical)
<rqou_>
the memory descriptors are accessed behind a dart, which is what `mapper-avd0-piodma` appears to describe
handofstand[m] has joined #asahi-dev
ella-0[m] has joined #asahi-dev
AdityaJS[m] has joined #asahi-dev
houlton[m] has joined #asahi-dev
SergioLopez[m] has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
AnthonyGlyadchenko[m] has joined #asahi-dev
TellowKrinkle[m] has joined #asahi-dev
maxim[m] has joined #asahi-dev
mathmagician_x[m] has joined #asahi-dev
tensorcat[m] has joined #asahi-dev
saintstellaris[m] has joined #asahi-dev
catinahatisback[m] has joined #asahi-dev
DragoonAethis has quit [Quit: hej-hej!]
DragoonAethis has joined #asahi-dev
headscracher[m] has joined #asahi-dev
enchiladasconpinguino[m] has joined #asahi-dev
ruby10x[m] has joined #asahi-dev
ianlienfa[m] has joined #asahi-dev
IanPlatt[m] has joined #asahi-dev
ruffiely[m] has joined #asahi-dev
RianSouzaSantos[m] has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
<rmk>
sven: can I add a suggested-by for you for that?
<sven>
sure
<rmk>
patch sent.
bluetail0 has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
the_lanetly_052 has joined #asahi-dev
the_lanetly_052 has quit [Remote host closed the connection]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
yamii_ has joined #asahi-dev
yamii has quit [Read error: Connection reset by peer]
amarioguy2 has joined #asahi-dev
<amarioguy2>
marcan: just saw your response, lol i completely didn't realize i was enabling syscall hooks (i needed them for firmware dev which was why i had them on) when booting XNU
<amarioguy2>
but yea i'll take note of that extra boot arg when collecting sep data today
<amarioguy2>
(2 at the end of my name because my main username is taken by my desktop and I'm not at my desktop for a while)
yamii_ has quit [Ping timeout: 480 seconds]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
dabaum|2er0 has joined #asahi-dev
yamii_ has joined #asahi-dev
goldsoultheory has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
jlco_ has joined #asahi-dev
jlco has quit [Ping timeout: 480 seconds]
amarioguy2 has quit [Ping timeout: 480 seconds]
amarioguy2 has joined #asahi-dev
goldsoultheory has joined #asahi-dev
<rmk>
sven: I'll update the patch in a few days.
<sven>
Nice! I do wonder if I missed anything else from pci.c that we just haven’t run into yet now though
<rmk>
can't really diff the two drivers, because diff can't cope with the changes
<sven>
yeah, it’s diverged quite a bit. I’ll take a closer look this weekend
<sven>
it’s probably fine but I can’t shake the feeling that I overlooked something else ;)
<rmk>
is there any way we could share code between the two to reduce the probability of divergence?
<sven>
the initial version did that but the nvme maintainers preferred to have it separate
<rmk>
ok, let me put it another way then :)
<rmk>
is it worth creating a library that could be used by both drivers? :D
<sven>
it’s probably possible to share e.g. the whole dma mapping code but the nvme guys are very concerned about performance in pci.c
<ljs>
j`ey: cheers, I looked in that repo but somehow missed that... :)
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
SuperED has joined #asahi-dev
SuperED has quit [Remote host closed the connection]
ljs has quit [Remote host closed the connection]
ljs has joined #asahi-dev
ljs has quit [Remote host closed the connection]
ljs has joined #asahi-dev
<ChaosPrincess>
marcan: hey, since you already have the spi nvram working on m1 pro/max, can you tell me the output of ` hexdump -C path/to/nvram | grep nvram` on those machines? i want to check some offsets that do not seem to be encoded in the adt
ljs has quit [Remote host closed the connection]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
chipxxx has quit [Read error: Connection reset by peer]
chipxxx has joined #asahi-dev
chipxxx has quit [Read error: Connection reset by peer]
amarioguy2 has joined #asahi-dev
amarioguy2 has quit [Remote host closed the connection]
jluthra has quit [Remote host closed the connection]
jluthra has joined #asahi-dev
<amarioguy>
alright perfect, at the login screen!
<amarioguy>
(for sep tracing i mean)
<amarioguy>
what's the priority stuff we want to be tracing? SKS stuff?
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
<amarioguy>
sep tracer's still broken :/
ljs has joined #asahi-dev
goldsoultheory has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
goldsoultheory has joined #asahi-dev
ljs has quit [Remote host closed the connection]
ljs has joined #asahi-dev
ljs has quit [Remote host closed the connection]
ljs has joined #asahi-dev
ljs has quit [Remote host closed the connection]
ljs has joined #asahi-dev
goldsoultheory has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
ljs has quit [Remote host closed the connection]
SSJ_GZ has quit [Ping timeout: 480 seconds]
ljs has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
ljs has quit [Remote host closed the connection]
bisko has quit [Ping timeout: 480 seconds]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
<amarioguy>
huh seems like when the call to iomon.poll is taken, seems like the readmem call inside that poll call is taking 3 args when it only can handle 2
<amarioguy>
gonna try changing the readmem_iova function prototype seeing what that does
<amarioguy>
looks like that did it!
<amarioguy>
the amount of tracing is well.... a lot
<amarioguy>
me thinks whether I should add a "save hv log" option to run_guest or smth because the amount of logs here is patently ridiculous
<amarioguy>
though admittedly part of me is slightly unsatisfied not knowing why the iomon.poll method was passing in 3 arguments (the third being "readfn" which is unnecessary as the sep tracer already defines readmem_iova?
<amarioguy>
would this be a consequence of the HV abi instability? this code was 6 months old after all
<amarioguy>
also yes the macos desktop is rendering at about 2 frames per second :^)