<mps>
blanking screen by `echo 1 > /sys/class/backlight/gpio-bl/bl_power` and suspend doesn't save drain from battery. same drain as before, i.e. from 100% to 57% for 7 hours
<sven>
jannau: fwiw, dcp->crtc is NULL inside dcp_delayed_vblank
<sven>
but the link setup is also still broken in other ways afaict. it should send more ap calls than it does right now even before set_digital_out_mode is called
<_jannau_>
sven: that should be set in dcp_link() during probing
<_jannau_>
called from apple_probe_per_dcp()
<sven>
ugh. i think i know what happens
<sven>
if dcp_probe takes too long it can already get the hotplug cb and queue that work before apple_probe_per_dcp is done
thelounge7571340 has joined #asahi-dev
<_jannau_>
iomfb_start_rtkit() should probably not be in dcp_probe()
thelounge7571340 has quit [Remote host closed the connection]
<sven>
yeah
<sven>
i can hack around it for now by just queueing the DPTX stuff (which takes a while) to a workqueue
<_jannau_>
I'd just add an dcp_start(), called from apple_drv when its setup is done
<sven>
that sounds like a proper fix, I don't do that here :D
<sven>
ah, it's also a bit more complicated than that because dcp_is_initialized is only set after some messages have been sent over iomfb
<sven>
this entire thing sounds like a giant race condition right now tbh
amarioguy has quit [Ping timeout: 480 seconds]
<_jannau_>
I agree. I should have noticed that as I added the connector state detection for external displays to dcp_link()
<sven>
if (!dcp_is_initialized(dcp[nr_dcp]))
<sven>
return -EPROBE_DEFER;
<sven>
that's also not a good idea
<sven>
EPROBE_DEFER will only try again as long as new devices are probed
gladiac has joined #asahi-dev
<sven>
but dcp_is_initialized changes from false->true only after dcp_probe is already done
<sven>
so if you're unlucky enough the last devices probes, dcp_is_initialized is still false, then DCP sends that message and only then dcp_is_initialized becomes true but the display-subsystem probe is never called again
<_jannau_>
I added that code with zero thought to see if dcpexpt would at least boot
<sven>
that dcp_is_initialized issue is already present in the original driver I think
<sven>
we're just lucky that we never hit it with just dcp
<sven>
two dcps + my ugly hacks seem to make everything just slow enough to hit it :)
amarioguy has joined #asahi-dev
MajorBiscuit has quit [Ping timeout: 480 seconds]
MajorBiscuit has joined #asahi-dev
enteentegeh has joined #asahi-dev
<enteentegeh>
hello, I am a experienced c developer. Are there any open topics where I could help?
alyssa has joined #asahi-dev
<alyssa>
13:22 <sven> that dcp_is_initialized issue is already present in the original driver I think
<alyssa>
sven: yes i take credit for that sin
enteentegeh has quit [Quit: Leaving]
pthariensflame has joined #asahi-dev
pthariensflame has quit []
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
MajorBiscuit has quit [Ping timeout: 480 seconds]
MajorBiscuit has joined #asahi-dev
<sven>
looks like the dp altmode tunable magic actually didn't change for t6000 phy, so this may just work there as well
<sven>
and even t8112 seems to call back into the t8103 dp tunable magic
MajorBiscuit has quit [Ping timeout: 480 seconds]
MajorBiscuit has joined #asahi-dev
<alyssa>
woo!
MajorBiscuit has quit [Ping timeout: 480 seconds]
Gaspare has joined #asahi-dev
MajorBiscuit has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
MajorBiscuit has quit [Ping timeout: 480 seconds]
whistlingoat has joined #asahi-dev
Gaspare has quit [Quit: Gaspare]
thelounge7571340 has joined #asahi-dev
roxfan has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
whistlingoat has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
whistlingoat has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
Gaspare has joined #asahi-dev
gladiac has quit [Quit: k thx bye]
Gaspare has quit [Quit: Gaspare]
fmstrat has quit [Ping timeout: 480 seconds]
Gaspare has joined #asahi-dev
whistlingoat has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
jluthra has quit [Remote host closed the connection]
jluthra has joined #asahi-dev
jluthra has quit [Remote host closed the connection]
jluthra_ has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
whistlingoat has joined #asahi-dev
whistlingoat has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
whistlingoat has joined #asahi-dev
<jannau>
dcp suspend works and resume almost works. it doesn't crash dcp but it appears to need a mode set after resume
<alyssa>
jannau: woohoo!
<jannau>
after fixing code rot due to not compiling with CONFIG_PM_SLEEP
<alyssa>
;-D
<jannau>
hmm, it might work and just tty0 is not active after booting with under the HV with serial port
<jannau>
works in X and on other ttys with login
<mps>
jannau: \o/
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
Gaspare has quit [Quit: Gaspare]
SSJ_GZ has quit [Ping timeout: 480 seconds]
whistlingoat has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
amw has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]