<nicolas17>
oh so I need to update /usr/lib/asahi-boot/dtb too
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
<nicolas17>
nope
<nicolas17>
update-m1n1 gets dtbs from /lib/modules/*-ARCH/dtbs/*
<nicolas17>
my self-built kernel did *not* put dtbs in the modules directory
<nicolas17>
there is a "make dtbs_install" in the kernel but that installs into /boot/dtbs
<nicolas17>
finally...
<nicolas17>
I copied dtbs from the kernel build directory into /usr/lib/asahi-boot/dtb thinking that would work and it didn't, then I modified update-m1n1 to get them from there and it worked
<nicolas17>
ChaosPrincess: this may be relevant (dmesg): "spi-nor spi0.0: unrecognized JEDEC id bytes: c2 2b 27 c2 2b 27"
<nicolas17>
(/dev/mtd0 still didn't appear, and that error may be why)
bluetail5 has joined #asahi-dev
bluetail has quit [Ping timeout: 480 seconds]
bluetail5 is now known as bluetail
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
nicolas17 has quit [Quit: Konversation terminated!]
SSJ_GZ has joined #asahi-dev
Dcow has joined #asahi-dev
Dcow has quit [Ping timeout: 480 seconds]
psykose has quit [Remote host closed the connection]
psykose has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
Etrien has joined #asahi-dev
Etrien__ has quit [Ping timeout: 480 seconds]
kettenis has quit [Ping timeout: 480 seconds]
Etrien has quit [Remote host closed the connection]
Etrien has joined #asahi-dev
uur has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
uur has quit [Remote host closed the connection]
uur has joined #asahi-dev
uur has quit [Remote host closed the connection]
Dcow has joined #asahi-dev
Etrien__ has joined #asahi-dev
Etrien has quit [Ping timeout: 480 seconds]
uur has joined #asahi-dev
Dcow has quit [Ping timeout: 480 seconds]
uur has quit [Remote host closed the connection]
duban6 has quit []
duban6 has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
uur has joined #asahi-dev
Etrien__ has quit [Read error: Connection reset by peer]
Etrien has joined #asahi-dev
brentr123 has joined #asahi-dev
brentr123 has quit []
brentr123 has joined #asahi-dev
brentr123 has quit []
brentr123 has joined #asahi-dev
brentr123 has quit [Quit: Leaving...]
millenialhacker has joined #asahi-dev
kettenis has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
brentr123 has joined #asahi-dev
brentr123 has quit []
<ChaosPrincess>
Welp, i hoped that m2 would just work(tm), but apparently this is not happening
uur has quit [Remote host closed the connection]
uur has joined #asahi-dev
brentr123 has joined #asahi-dev
Etrien__ has joined #asahi-dev
Etrien has quit [Ping timeout: 480 seconds]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
brentr123 has quit [Quit: Leaving...]
brentr123 has joined #asahi-dev
Etrien has joined #asahi-dev
brentr123 is now known as Guest4505
Guest4505 has quit [Quit: Leaving...]
brentr123 has joined #asahi-dev
Etrien__ has quit [Ping timeout: 480 seconds]
brentr123 has quit [Quit: Leaving...]
systwi has quit [Read error: Connection reset by peer]
<chadmed_>
i caught the missing curly brace, but we dont need to go to free_microwatt in that last case right
<chadmed_>
if we get to that stage and supplies is still -1 then microwatt was never allocated
<kazuki>
Ah right yes
<kazuki>
No need for the if (pcount) too
<chadmed_>
yeah
<chadmed_>
same goes for microamp and microvolt, theyre only allocated iff icount/vcount are valid, so if we make it to free_* then we know that i/vcount arent 0
<kazuki>
They might not get allocated if !icount/!vcount
<chadmed_>
if ive written the code correctly they should never be allocated under such conditions
<chadmed_>
theyre only there to be indexed into for populating the regulator struct
<chadmed_>
if !vcount, !icount or !pcount then theres no data to populate so we dont need those arrays
<chadmed_>
and they should not be allocated
<kazuki>
Yes, that's why we don't need to kfree them
<chadmed_>
yeah so why do we need to jump to free_* in branches where theyre not allocated
<chadmed_>
the previous code just returned straight out of the branch like i had it before
uur has joined #asahi-dev
<kazuki>
What if microvolt is not allocated but microamp is, and we want to exit in microwatt path
<chadmed_>
oh of course that makes sense
<chadmed_>
in that case would it be better to have one error: label which checks all three and cleans up ones that have been allocated instead of three discrete ones
<kazuki>
wdym
<chadmed_>
instead of having free_*, we condense them into one operation that just frees any of the arrays that were allocated
<chadmed_>
my thinking is that since theres no longer a hierarchy of props, any of them could be allocated out of order and having individual ops to error out of parsing them could leave some non-freed memory behind depending on the order they were parsed/allocated
ccs1 has joined #asahi-dev
<ccs1>
😁️
<chadmed_>
given that we dont actually populate the regs under any error condition, we should just check for all three arrays and free any that were allocated on all error paths to guarantee we dont leave anything behind
brentr123 has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
<kazuki>
Sure, I guess it's up to the maintainer to decide at this point then
<kazuki>
Technically yours have more overhead (more branches) but I guess that's mostly irrelevant
<ccs1>
just wondering anyone work on the "SSM3515" ? newbie here would like to learn some driver dev.
Dcow has quit [Remote host closed the connection]
Dcow has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
chengsun has joined #asahi-dev
chengsun has quit [Ping timeout: 480 seconds]
Dcow_ has joined #asahi-dev
Dcow has quit [Ping timeout: 480 seconds]
<millenialhacker>
Does DCP improved battery life?
<millenialhacker>
s/improved/improve/g
uur has quit [Remote host closed the connection]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
gladiac has joined #asahi-dev
ccs1 has quit [Ping timeout: 480 seconds]
uur has joined #asahi-dev
ljs has joined #asahi-dev
millenialhacker has quit [Quit: Konversation terminated!]
lkron has joined #asahi-dev
chadmed_ has quit [Remote host closed the connection]
brentr123 has quit [Quit: Connection closed for inactivity]
kazuki has quit [Quit: Konversation terminated!]
DarkShadow44 has joined #asahi-dev
DarkShadow4444 has quit [Remote host closed the connection]
DarkShadow44 has quit []
DarkShadow4444 has joined #asahi-dev
DarkShadow44 has joined #asahi-dev
ljs has quit [Ping timeout: 480 seconds]
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
gladiac has quit [Quit: k thx bye]
gladiac has joined #asahi-dev
gladiac has quit []
gladiac has joined #asahi-dev
brentr123 has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
brentr123 has quit [Quit: Leaving...]
Dcow_ has quit [Remote host closed the connection]
Dcow has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
uur has quit [Remote host closed the connection]
uur has joined #asahi-dev
lkron has quit [Read error: No route to host]
lkron has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
c10l5 has quit []
c10l has joined #asahi-dev
chengsun has joined #asahi-dev
chengsun has quit [Ping timeout: 480 seconds]
<jannau>
sigh, I finally found out how to set the backlight. much easier than thought, it's encoded in 0x2e4 - 0x2f3 of dcp_swap/swap_rec
<jannau>
I still don't understand the how exactly it's coded and what the limits are
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]
gladiac has quit [Quit: k thx bye]
jluthra has quit [Remote host closed the connection]
jluthra has joined #asahi-dev
l3k has joined #asahi-dev
thelounge7571340 has joined #asahi-dev
thelounge7571340 has quit [Remote host closed the connection]