09:19 <robimarko> f00b4r0: Have you had a similar "issue" with the routerbootpart parser?

09:19 <robimarko> [ 1.007103] RouterBoot: routerboot partition /ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@af000/soft_config (/ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@af000) "soft_config" overlaps with previous partition "dtb_config".

09:19 <robimarko> [ 1.031043] RouterBoot: error parsing routerboot partition /ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@af000/soft_config (/ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@af000)

09:19 <f00b4r0> robimarko: no, but I'm not running master

09:19 <robimarko> Ok, I gotta poke deeper

09:20 <robimarko> I am working on finally adding RB5009

09:20 <f00b4r0> is it possible the dtb contains the soft-config signature?

09:21 <f00b4r0> I don't remember if parsing is sequential or starts from beginning for all parts (should be the former, but it's been a long time)

09:21 <robimarko> I dont think that is the case, I added some prints:

09:21 <robimarko> [ 0.987201] RouterBoot: found "hard_config": offset af000 size 1000

09:21 <robimarko> [ 0.976686] 0x000000000000-0x000001000000 : "RouterBoot"

09:21 <robimarko> [ 0.993997] RouterBoot: found "soft_config": offset c0000 size 1000

09:21 <robimarko> [ 1.000863] RouterBoot: found "dtb_config": offset d4000 size 5a8f

09:21 <robimarko> So they should not overlap

09:21 <f00b4r0> indeed not

09:21 <f00b4r0> error makes no sense

09:26 <robimarko> Il poke around as its rather weird

09:27 <f00b4r0> thx. No time to dig here sadly, sorry

09:28 <robimarko> I commented out the goto for the error:

09:28 <robimarko> [ 0.986504] RouterBoot: found "hard_config": offset af000 size 1000

09:28 <robimarko> [ 0.975989] 0x000000000000-0x000001000000 : "RouterBoot"

09:28 <robimarko> [ 0.993295] RouterBoot: found "soft_config": offset c0000 size 1000

09:28 <robimarko> [ 1.000178] RouterBoot: found "dtb_config": offset d0000 size 5a8f

09:28 <robimarko> [ 1.006419] RouterBoot: routerboot partition /ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@0/soft_config (/ap806/config-space@f0000000/spi@510600/flash@0/partitions/partition@0) "soft_config" overlaps with previous partition "dtb_config".

09:28 <robimarko> [ 1.029671] 3 routerbootpart partitions found on MTD device RouterBoot

09:28 <robimarko> [ 1.036227] Creating 3 MTD partitions on "RouterBoot":

09:28 <robimarko> [ 1.041395] 0x0000000af000-0x0000000b0000 : "hard_config"

09:28 <robimarko> [ 1.047184] 0x0000000d0000-0x0000000d5a8f : "dtb_config"

09:28 <robimarko> [ 1.052803] 0x0000000c0000-0x0000000c1000 : "soft_config"

09:28 <robimarko> [ 1.058228] mtd: partition "soft_config" doesn't end on an erase/write block -- force read-only

09:28 <robimarko> Nothing overlaps

09:34 <f00b4r0> robimarko: it strikes me as odd that the partitions are listed in reverse address order

09:34 <f00b4r0> dtb and soft, that is

09:34 <f00b4r0> this may be why the overlap warning triggers

09:35 <f00b4r0> let me take a (very) quick look at my code ;)

09:35 <robimarko> Hm, I just copy/pasted my hAP ac3 DTS for the RB partitions

09:35 <robimarko> dtb_config is before soft_config there, let me reorder that

09:36 <f00b4r0> * This parser requires the DTS to list partitions in ascending order as

09:36 <f00b4r0> * expected on the MTD device.

09:37 <f00b4r0> there you go :)

09:37 <f00b4r0> NOTABUG ;)

09:37 <robimarko> So, I just had to read :)

09:37 <f00b4r0> i guess the parser could be made to be more flexible, at the expense of some performance though, and I'm too lazy :)

09:38 <robimarko> Ok,now its happy and doesnt complain about overlap

09:39 <robimarko> Though kernel is not happy with the DBT

09:39 <robimarko> [ 1.011940] mtd: partition "soft_config" doesn't end on an erase/write block -- force read-only

09:39 <robimarko> [ 1.020950] 0x0000000d0000-0x0000000d5a8f : "dtb_config"

09:40 <f00b4r0> the read-only warning shouldn't happen with the partial eb patch that we've been having for some time

09:40 <f00b4r0> unless it's not enabled on your target (likely)

09:41 <robimarko> 4K read/writes?

09:41 <robimarko> Its been ages since I messed with this

09:45 <robimarko> Ahh, CONFIG_MTD_SPI_NOR_USE_VARIABLE_ERASE

09:49 <f00b4r0> that :)

09:54 <robimarko> And it works :)

09:54 <robimarko> Gotta rebase my U-Boot port for this so I can get rid of one of those adron ELF loaders

09:55 <f00b4r0> 👍

10:14 <Znevna> so there should be light for rb5009? :P

10:23 <robimarko> Cannot promise anything, MTik really made it hard with the stupid YAFFS

10:34 <jow> ö

10:34 <jow> sry

10:41 <Habbie> söry

10:42 <jow> congratulations, you passed the annual utf8 check

10:43 <Habbie> :)

12:02 <Znevna> rofl

15:54 <mrnuke> damo22: yeah, I wrote a script to mess with them

15:56 <mrnuke> damo22: https://github.com/openwrt/openwrt/pull/14922/files#diff-2ab37134bb86b93dca7786c4a5bd2ee8c8d61cdf96203b707855e6139e929878

18:23 <owrt-images-builds> Build [#283](https://buildbot.openwrt.org/images/#/builders/4/builds/283) of `master_mvebu/cortexa53` failed.

19:49 <owrt-images-builds> Build [#250](https://buildbot.openwrt.org/images/#/builders/190/builds/250) of `master_at91/sam9x` completed successfully.

20:03 <owrt-images-builds> Build [#157](https://buildbot.openwrt.org/images/#/builders/238/builds/157) of `master_d1/generic` completed successfully.

20:36 <owrt-images-builds> Build [#245](https://buildbot.openwrt.org/images/#/builders/204/builds/245) of `master_sunxi/cortexa53` completed successfully.

20:41 <Mangix> I'll note https://github.com/openwrt/openwrt/pull/14082 is ready

22:09 <owrt-images-builds> Build [#248](https://buildbot.openwrt.org/images/#/builders/163/builds/248) of `master_gemini/generic` completed successfully.

23:11 <damo22> mrnuke: see private message