Mangix has quit [Read error: Connection reset by peer]
<neocturne>
Ansuel: currently having a look at the qca8k patches again, and I have a question regarding the "enable assisted learning on CPU port" change
<neocturne>
I understand why QCA8K_PORT_LOOKUP_LEARN is cleared for the CPU ports, but why is the same clearing removed for user ports, which have this bit controlled by bridge flags when offloaded?
<Ansuel>
new dsa implementationrequire learning to be enabled separately
<neocturne>
The comment reads like the intention was to clear the bit for all ports, both CPU and user
<Ansuel>
also the assisted is for adding the entry for the wifi interface if i'm not wrong
<neocturne>
I'm specifically asking why the learning bit is not initialized for user ports anymore (left at reset value?), that part looks unintended
<neocturne>
I'm talking about the part ll.40-44 here: https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/generic/pending-6.6/712-net-dsa-qca8k-enable-assisted-learning-on-CPU-port.patch;h=18afa1c0725170d7e31668865bd400dc2448c18b;hb=HEAD
<neocturne>
Where the bit was changed from enabled to disabled, but now it's not at at all anymore
<neocturne>
*not set
mark22k is now known as Guest10363
mark22k has joined #openwrt-devel
<neocturne>
Maybe the intention was to move the lines into the dsa_switch_for_each_port() loop, rather than the dsa_switch_for_each_cpu_port() loop?
Guest10363 has quit [Ping timeout: 480 seconds]
<Ansuel>
neocturne i smell refresh problem and the code got moved to the wrong loop? or totally fkup by my side
<neocturne>
I can push a patch that moves it to the other loop to my staging, but I'm not sure what I should do to test the change, besides verifying that the register value is set as expected
<Ansuel>
well the thing should be learning disabled for cpu port and assisted enabled
<Ansuel>
just check if the reg is correct
<Ansuel>
and maybe we can compare fdb entry with bridge fdb show
SlimeyX has quit [Ping timeout: 480 seconds]
zer0def has quit [Quit: zer0def]
zer0def has joined #openwrt-devel
jakllsch has joined #openwrt-devel
minimal has joined #openwrt-devel
Tapper has joined #openwrt-devel
valku has joined #openwrt-devel
torv has quit [Remote host closed the connection]
fakuivan has quit [Remote host closed the connection]
<stefanct>
ive been trying to use my host toolchain to build openwrt HEAD for a ramips target. i've not investigated the problem at all but the message seems to indicate that the check itself is at least a bit broken/incomplete.
<stefanct>
"Testing external toolchain for softfloat support ... Toolchain directory '--cflags' does not exist."
<stefanct>
seems like CONFIG_TOOLCHAIN_ROOT is not set at that point
<stefanct>
which apparently should come from the kconfig but that's a bit odd... since the setting for that is hidden once you select "Use host's toolchain"
<stefanct>
which is exactly how the kconfig is coded so... i am not sure how this is supposed to ever work :)