yuq825 has quit [Read error: Connection reset by peer]
yuq825 has joined #dri-devel
bmodem1 has joined #dri-devel
<javierm>
sima, rodrigovivi: I found a bug in dim but not sure how to fix it. Problem is `git show --pretty=email` respects .mailmap and so checkpatch complains that author != S-o-B even when that's not the case
<javierm>
that is, the author and S-o-B does match in the commit but git show doesn't show the real email address as author and instead shows that's in .mailmap
<javierm>
sima, rodrigovivi: I'm reading the git-show man page but I don't see how to make --pretty=email to ignore .mailmap. One option is to use our own --pretty=tformat:<format> with %ae instead of %aE
<javierm>
another option is just to ask the author to re-send the patch. But this is a problem if you want to land old patches if the author added an entry to .mailmap in the meantime, so worth to fix I believe
bmodem has quit [Ping timeout: 480 seconds]
Danct12 has joined #dri-devel
camus has quit [Ping timeout: 480 seconds]
JohnnyonF has quit [Ping timeout: 480 seconds]
<javierm>
hmm, it seems that I can still push the branch so I'll just ignore the warning, the commit is correct anyways
frieder has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
kts has quit [Read error: Connection reset by peer]
itoral has quit [Quit: Leaving]
fab has quit [Ping timeout: 480 seconds]
<rodrigovivi>
javierm: but I don't believe anyone would have a mailmap entry that's not for the person-self... right?! anyway, it might be worth if we have a more reliable way to get that, a patch to dim shouldn't hurt
<javierm>
rodrigovivi: yeah, the case here was a patch that was in the ML for some time, the author asked for it to be merged and when I tried their author email was overriden by a mail map entry so dim got confused
<javierm>
rodrigovivi: and yes, I'll try to type a patch for dim later to ignore mailmap in the git show output since we want to compare the actual patch, not some overriden fields
<rodrigovivi>
why do you have a mailmap entry that's not yourself?
camus has joined #dri-devel
<javierm>
rodrigovivi: not sure I understand the question. People also use mailmap to prevent get_maintainer.pl --git-fallback to list email address that no longer exist
<tursulin>
sometimes it is just old-vs-new email address
<javierm>
yeah, what tursulin said
<tursulin>
we hit this a few times already over the years
<tursulin>
I *think* jani was the last person who brain stormed how to "fix" this but I can't remember the conclusion.. sorry for the ping jani if I am misremembering things here
columbarius has joined #dri-devel
co1umbarius has quit [Remote host closed the connection]
bmodem1 has quit [Ping timeout: 480 seconds]
co1umbarius has joined #dri-devel
columbarius has quit [Read error: Connection reset by peer]
<jfalempe>
I switched mgag200 driver to use DRM_GEM_DMA_DRIVER_OPS, so that I can use DMA to directly send the framebuffer to the VRAM.
<jfalempe>
But there is a limitation on x86_64, if the framebuffer is > 4MB, the dma allocation fails, and it breaks the driver.
<jfalempe>
his limits the resolution to 1024x768 (3MB) because 1280x1024 (5MB) fails.
<jfalempe>
Is there a way to workaround this ?
fab has joined #dri-devel
<DemiMarie>
<kisak> "to do what now? A cpu based..." <- OpenH264 should have hardware acceleration.
Company has joined #dri-devel
cmichael has quit [Quit: Leaving]
cmichael has joined #dri-devel
aravind has quit [Ping timeout: 480 seconds]
aravind has joined #dri-devel
camus has quit [Ping timeout: 480 seconds]
camus has joined #dri-devel
co1umbarius has quit [Read error: No route to host]
co1umbarius has joined #dri-devel
<karolherbst>
even on the cpu is kinda hardware accelerated because without SIMD ops it's also slow :P
<alyssa>
gerddie: Will you have time to convert r600/sfn to unified atomics this week or should I go ahead and write the patch?
Danct12 has quit [Quit: WeeChat 3.8]
* alyssa
writes it I guess
<robmur01>
jfalempe: check if CONFIG_CMA and CONFIG_DMA_CMA are enabled - sounds like they probably aren't
<robmur01>
(or turn the IOMMU on if you have one)
<jfalempe>
I do have CONFIG_CMA=y and CONFIG_DMA_CMA=y
<robmur01>
hmm, 4MB sounds suspiciously like the limit of a regular MAX_ORDER page allocation
<robmur01>
CMA should be allowing you to go bigger
<jfalempe>
for iommu, it looks like it's not enabled.
<robmur01>
jfalempe: hmm, weird, in that case it should be going dma_direct_alloc() -> __dma_direct_alloc_pages() -> dma_alloc_contiguous() and hitting CMA
<jenatali>
alyssa: I'm pretty impressed at how fast you've managed to convert the whole tree
<jenatali>
Feel free to ping me for frontend reviews when you get there
<jenatali>
alyssa: Btw any more comments on !22879?
<alyssa>
jenatali: thanks, it turns out being out of school and giving me free reign to make mesa better has consequences :P
<alyssa>
jenatali: certainly ack.. IDK if I'm confident in giving an r-b here
yuq825 has left #dri-devel [#dri-devel]
<zamundaaa[m]>
How is Colorspace and HDR metadata handled with eDP displays?
<zamundaaa[m]>
With a integrated display that supports HDR on an Intel laptop (at least the EDID says so), the HDR_OUTPUT_METADATA property is missing entirely
<pq>
wish I knew - I'd assume they're not :-)
<pq>
hwentlan_ or vsyrjala might have a clue?
<zamundaaa[m]>
That is what I assume too. Setting the Colorspace property doesn't seem to do anything; sending data encoded as BT.2020 just makes everything horrible
<jenatali>
alyssa: Fair enough. Honestly an ack is probably fine for me to land it, if there's problems after the fact we can just fix 'em. I don't want to just let it languish forever
<zamundaaa[m]>
pq: wdym?
<robmur01>
jfalempe: right, which implies that either dma_alloc_contiguous() or the subsequent dma_coherent_ok() check failed unexpectedly
<pq>
zamundaaa[m], I mean does the screen brightness go up enough to facilitate HDR display, or is something keeping it low?
agd5f_ has quit []
<robmur01>
jfalempe: OK, alloc_pages() failing for >4MB is expected behaviour (for typical default values of MAX_ORDER), so the question to dig into is why CMA isn't working
agd5f has joined #dri-devel
<zamundaaa[m]>
pq: the display is limited to 400 nits
<zamundaaa[m]>
That's the maximum according to the EDID
<jfalempe>
robmur01, what should be the path in dma_alloc_attrs() when CMA is working ?
<robmur01>
dma_alloc_contiguous() would return your buffer
<jfalempe>
robmur01, thanks, I will add more printk to see why it fails.
<alyssa>
jenatali: Removing legacy atomics from core
Duke`` has joined #dri-devel
<alyssa>
actually doesnt compile yet, still deleting
<vsyrjala>
zamundaaa[m]: icl+ should have it. older likely not
frieder has quit [Ping timeout: 480 seconds]
<zamundaaa[m]>
drm_info says it's a CometLake GPU
<zamundaaa[m]>
CometLake-U GT2
<vsyrjala>
that's too old
bmodem has joined #dri-devel
<zamundaaa[m]>
The driver exposes the Colorspace property though
tursulin has quit [Quit: Konversation terminated!]
<zamundaaa[m]>
That should probably be removed if the hardware can't support it
<vsyrjala>
it can support that
tursulin has joined #dri-devel
<zamundaaa[m]>
okay, then there's some bug with that. If I set Colorspace to BT2020_RGB and send BT.2020 content, everything's super desaturated. I assume it's ignoring the property
<vsyrjala>
does i915.enable_psr=0 make a difference?
tursulin has quit [Read error: Connection reset by peer]
<alyssa>
so that should fulfill my code deletion quota for the week
<jenatali>
Very nice
lynxeye has quit [Quit: Leaving.]
guru_ has quit [Read error: No route to host]
pochu has quit [Quit: leaving]
oneforall2 has joined #dri-devel
oneforall2 has quit [Remote host closed the connection]
oneforall2 has joined #dri-devel
cmichael has quit [Quit: Leaving]
airlied has quit [Ping timeout: 480 seconds]
JohnnyonFlame has joined #dri-devel
swalker__ has quit [Remote host closed the connection]
airlied has joined #dri-devel
kts has joined #dri-devel
<karolherbst>
do we have code in place to check what extensions a spir-v declares so we can validate against a list of supported ones?
<karolherbst>
or is it all yolo atm?
<karolherbst>
jenatali: you don't support accepting random spir-v in CL yet, right?
ngcortes has joined #dri-devel
<jenatali>
karolherbst: I implemented it forever ago but never really hooked it up
<jenatali>
karolherbst: vtn_handle_extension?
ayaka has left #dri-devel [Leaving]
<jenatali>
karolherbst: You might know something I was just looking at - does CL have 64-bit atomics?
<karolherbst>
it does
<karolherbst>
as an extension I think
<karolherbst>
somewhere...
<karolherbst>
`cl_khr_int64_base_atomics` and `cl_khr_int64_extended_atomics`
<jenatali>
I was thinking through extensions that I should be implementing for VK and 64-bit atomics was on my list, and I realized that the way we do shared vars can't handle that right now so I need to rework it, but the reworked way of doing it wouldn't be able to handle CL
<karolherbst>
yeah.. it's messy because there is enough hardware not doing it on all address spaces either
<karolherbst>
especially local/shared
<karolherbst>
anwyay
<karolherbst>
what I kinda want to do is to reject spir-vs declaring extensions we don't support
<jenatali>
Isn't that already going to happen?
<karolherbst>
it doesn't
<karolherbst>
we can tell the translator what we support, but that doesn't help for application provided spir-vs
<jenatali>
Did you look at vtn_handle_extension?
<karolherbst>
I did
<jenatali>
Or are you talking about capabilities that aren't extensions?
<jenatali>
Or rather, that don't have extended opcodes
<karolherbst>
I don't see where it handles general spirv extensions
<karolherbst>
things like "SPV_EXT_shader_atomic_float_add"
<jenatali>
Oh 'cause it only adds a capability and modifies validation rules, it doesn't add new instructions...
<karolherbst>
it's defined through cl_ext_float_atomics, but if you don't support that extension you are free to reject spir-vs using the spirv ext
<karolherbst>
yeah..
<karolherbst>
atm we only handle those ext instruction things
<karolherbst>
and that's kinda fine
<karolherbst>
but I kinda want to validate all extensions declared
<jenatali>
Wait no it does have new instructions, but they're not "extension instructions" they're just... instructions. Wtf
<karolherbst>
yeah
<karolherbst>
it's not uncommon
<karolherbst>
anyway
<karolherbst>
now that I look into supporting SyCL/HIP I kinda want to bail when seeing unknown extensions
<karolherbst>
especially DPCPP is in yolo mode and just doesn't care what the runtime supports
<jenatali>
I'd add handling of SpvOpExtension similar to what we do with SpvOpCapability, have a nice table of known/implemented extensions that the caller can provide
<karolherbst>
yeah.. maybe
<karolherbst>
or just a list of strings.. dunno
<karolherbst>
I think we have something for vulkan already actually...
<karolherbst>
gfxstrand: is there any kind of spir-v extension validation going on for vulkan?
<jenatali>
Generally the extensions add a capability. We already have a list of valid/known capabilities. Maybe we don't need to do anything for OpExtension then
bcheng has quit [Remote host closed the connection]
<karolherbst>
mhh yeah.. maybe it would be fine to just fail in `spirv_to_nir`
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
orbea has quit [Remote host closed the connection]
orbea has joined #dri-devel
mvlad has quit [Remote host closed the connection]
ngcortes has quit [Ping timeout: 480 seconds]
heat has quit [Remote host closed the connection]
heat has joined #dri-devel
ngcortes has joined #dri-devel
Kayden has quit [Quit: -> JF]
Guest24 has quit []
Danct12 has joined #dri-devel
Net147 has quit [Ping timeout: 480 seconds]
sima has quit [Ping timeout: 480 seconds]
Net147 has joined #dri-devel
heat has quit [Read error: No route to host]
heat has joined #dri-devel
<lumag>
rodrigovivi, excuse me, yet another ping for the DSC series
Kayden has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
ngcortes has quit [Remote host closed the connection]
ngcortes has joined #dri-devel
Haaninjo has quit [Quit: Ex-Chat]
ngcortes has quit [Remote host closed the connection]
ngcortes has joined #dri-devel
<alyssa>
total instructions in shared programs: 1537964 -> 1571328 (2.17%)
<alyssa>
big ouch
jkrzyszt has quit [Remote host closed the connection]
* alyssa
giving up on mediump
jkrzyszt has joined #dri-devel
bgs has quit [Remote host closed the connection]
ngcortes has quit [Ping timeout: 480 seconds]
<rodrigovivi>
lumag: only patch 6 missing review now, right? I put and internal email here to find out the best one to give the final review on that so we can merge...
<lumag>
rodrigovivi, thank you!
<lumag>
Please excuse me for being PITA about it :-)
ngcortes has joined #dri-devel
jkrzyszt has quit [Remote host closed the connection]
apinheiro has joined #dri-devel
jkrzyszt has joined #dri-devel
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
Jeremy_Rand_Talos_ has joined #dri-devel
dcz_ has quit [Ping timeout: 480 seconds]
jernej_ has joined #dri-devel
jernej has quit [Read error: Connection reset by peer]
heat has quit [Read error: Connection reset by peer]
heat has joined #dri-devel
tomeu has quit [Ping timeout: 480 seconds]
talcohen[m] has quit [Ping timeout: 480 seconds]
reactormonk[m] has quit [Ping timeout: 480 seconds]
K0bin[m] has quit [Ping timeout: 480 seconds]
Anson[m] has quit [Ping timeout: 480 seconds]
tleydxdy has quit [Ping timeout: 480 seconds]
knr has quit [Ping timeout: 480 seconds]
sigmoidfunc[m] has quit [Ping timeout: 480 seconds]
ohadsharabi[m] has quit [Ping timeout: 480 seconds]
samueldr has quit [Ping timeout: 480 seconds]
nekit[m] has quit [Ping timeout: 480 seconds]
msizanoen[m] has quit [Ping timeout: 480 seconds]
nyorain[m] has quit [Ping timeout: 480 seconds]
kunal10710[m] has quit [Ping timeout: 480 seconds]
AlexisHernndezGuzmn[m] has quit [Ping timeout: 480 seconds]
egalli has quit [Ping timeout: 480 seconds]
tomba has quit [Ping timeout: 480 seconds]
MayeulC has quit [Ping timeout: 480 seconds]
heftig has quit [Ping timeout: 480 seconds]
mripard has quit [Ping timeout: 480 seconds]
zamundaaa[m] has quit [Ping timeout: 480 seconds]
marmarek[m] has quit [Ping timeout: 480 seconds]
naheemsays[m] has quit [Ping timeout: 488 seconds]
MotiH[m] has quit [Ping timeout: 488 seconds]
gdevi has quit [Ping timeout: 488 seconds]
Tooniis[m] has quit [Ping timeout: 483 seconds]
ids1024[m] has quit [Ping timeout: 480 seconds]
jasuarez has quit [Ping timeout: 480 seconds]
jenatali has quit [Ping timeout: 483 seconds]
x512[m] has quit [Ping timeout: 483 seconds]
DavidHeidelberg[m] has quit [Ping timeout: 480 seconds]
ajhalaney[m] has quit [Ping timeout: 480 seconds]
Newbyte has quit [Ping timeout: 480 seconds]
orowith2os has quit [Ping timeout: 480 seconds]
Mis012[m] has quit [Ping timeout: 480 seconds]
dcbaker has quit [Ping timeout: 480 seconds]
sythemeta847[m] has quit [Ping timeout: 480 seconds]
Hi-Angel has quit [Ping timeout: 480 seconds]
general_j[m] has quit [Ping timeout: 483 seconds]
pac85[m] has quit [Ping timeout: 480 seconds]
znullptr[m] has quit [Ping timeout: 480 seconds]
Sumera[m] has quit [Ping timeout: 480 seconds]
Vin[m] has quit [Ping timeout: 480 seconds]
aura[m] has quit [Ping timeout: 480 seconds]
RAOF has quit [Ping timeout: 480 seconds]
eyearesee has quit [Ping timeout: 480 seconds]
EricCurtin[m] has quit [Ping timeout: 480 seconds]
m00nlit[m] has quit [Ping timeout: 480 seconds]
viciouss[m] has quit [Ping timeout: 480 seconds]
go4godvin has quit [Ping timeout: 480 seconds]
dabrain34[m] has quit [Ping timeout: 480 seconds]
Soroush has quit [Ping timeout: 480 seconds]
robertmader[m] has quit [Ping timeout: 480 seconds]
ram15[m] has quit [Ping timeout: 480 seconds]
moben[m] has quit [Ping timeout: 480 seconds]
siddh has quit [Ping timeout: 480 seconds]
yshui` has quit [Ping timeout: 480 seconds]
PiGLDN[m] has quit [Ping timeout: 480 seconds]
gallo[m] has quit [Ping timeout: 480 seconds]
LinuxHackerman has quit [Ping timeout: 480 seconds]
doras has quit [Ping timeout: 483 seconds]
vidal72[m] has quit [Ping timeout: 483 seconds]
michael5050[m] has quit [Ping timeout: 483 seconds]
LaughingMan[m] has quit [Ping timeout: 480 seconds]
hch12907 has quit [Ping timeout: 480 seconds]
Guest10855 has quit [Ping timeout: 480 seconds]
shoffmeister[m] has quit [Ping timeout: 480 seconds]
fkassabri[m] has quit [Ping timeout: 480 seconds]
kunal_10185[m] has quit [Ping timeout: 480 seconds]
Nirvin[m] has quit [Ping timeout: 480 seconds]
ofirbitt[m] has quit [Ping timeout: 480 seconds]
pp[m] has quit [Ping timeout: 480 seconds]
q4a has quit [Ping timeout: 480 seconds]
dhirschfeld2[m] has quit [Ping timeout: 480 seconds]
ella-0[m] has quit [Ping timeout: 480 seconds]
aradhya7[m] has quit [Ping timeout: 480 seconds]
bubblethink[m] has quit [Ping timeout: 480 seconds]
Quinten[m] has quit [Ping timeout: 480 seconds]
Hazematman has quit [Ping timeout: 480 seconds]
martijnbraam has quit [Ping timeout: 480 seconds]
danylo has quit [Ping timeout: 480 seconds]
Targetball[m] has quit [Ping timeout: 480 seconds]
pushqrdx[m] has quit [Ping timeout: 480 seconds]
YaLTeR[m] has quit [Ping timeout: 480 seconds]
nicofee[m] has quit [Ping timeout: 480 seconds]
masush5[m] has quit [Ping timeout: 480 seconds]
kelbaz[m] has quit [Ping timeout: 480 seconds]
zzoon_off_1th_May[m] has quit [Ping timeout: 480 seconds]
jluthra has quit [Ping timeout: 480 seconds]
DemiMarie has quit [Ping timeout: 480 seconds]
dantob has quit [Ping timeout: 480 seconds]
cwfitzgerald[m] has quit [Ping timeout: 480 seconds]
swick[m] has quit [Ping timeout: 480 seconds]
onox[m] has quit [Ping timeout: 480 seconds]
gnustomp[m] has quit [Ping timeout: 480 seconds]
BilalElmoussaoui[m] has quit [Ping timeout: 480 seconds]
tak2hu[m] has quit [Ping timeout: 480 seconds]
xerpi[m] has quit [Ping timeout: 480 seconds]
ttayar[m] has quit [Ping timeout: 480 seconds]
KunalAgarwal[m][m] has quit [Ping timeout: 480 seconds]
JosExpsito[m] has quit [Ping timeout: 480 seconds]
DUOLabs[m] has quit [Ping timeout: 480 seconds]
devarsht[m] has quit [Ping timeout: 480 seconds]
daniliberman[m] has quit [Ping timeout: 480 seconds]
Eighth_Doctor has quit [Ping timeout: 480 seconds]
undvasistas[m] has quit [Ping timeout: 480 seconds]
sergi has quit [Ping timeout: 480 seconds]
Wallbraker has quit [Ping timeout: 480 seconds]
enunes[m] has quit [Ping timeout: 480 seconds]
Mershl[m] has quit [Ping timeout: 483 seconds]
T_UNIX has quit [Ping timeout: 483 seconds]
sewn has quit [Ping timeout: 483 seconds]
rasterman has quit [Quit: Gettin' stinky!]
Soroush has joined #dri-devel
Peuc has quit [Quit: Peuc]
heat has quit [Read error: Connection reset by peer]
heat has joined #dri-devel
pcercuei has quit [Quit: dodo]
Peuc has joined #dri-devel
vliaskov has quit [Quit: Leaving]
Jeremy_Rand_Talos_ has quit [Remote host closed the connection]
apinheiro has quit [Quit: Leaving]
siddh has joined #dri-devel
Rayyan has quit [Quit: Ping timeout (120 seconds)]
Rayyan has joined #dri-devel
ngcortes has quit [Remote host closed the connection]
ngcortes has joined #dri-devel
Peuc has quit [Quit: Peuc]
smiles_1111 has joined #dri-devel
Peuc has joined #dri-devel
elongbug has quit [Remote host closed the connection]
Jeremy_Rand_Talos has joined #dri-devel
robertmader[m] has joined #dri-devel
JohnnyonF has joined #dri-devel
Jeremy_Rand_Talos has quit [Remote host closed the connection]
JohnnyonFlame has quit [Ping timeout: 480 seconds]