<DavidHeidelberg[m]>
Dor Askayo: thank you, I think it solves my issue I had and few I seen in the issues, but from missing description of the change it's hard to guess.
<doras>
David Heidelberg: I'll reply in the MR.
<DavidHeidelberg[m]>
Dor Askayo: edit the description of it ;-) thank you
gouchi has joined #dri-devel
Kwiboo has quit [Quit: .]
Kwiboo has joined #dri-devel
<doras>
David Heidelberg: do you mind sharing what were the issues you're thinking of?
<DavidHeidelberg[m]>
Dor Askayo: I found that issue got resolved already (it was missing `opencl-c.h`), I had this too when doing some combination of libclc + microsoft-clc
<doras>
Ah.
<jenatali>
Dor Askayo: There's a general guideline to wait 24 hours, not including weekends, before merging changes to common code, to give other reviewers a chance to chime in
<jenatali>
So I was waiting for that before assigning
gouchi has quit [Remote host closed the connection]
cmarcelo has quit [Quit: leaving]
cmarcelo has joined #dri-devel
kts has joined #dri-devel
heat has quit [Ping timeout: 480 seconds]
puck_ has quit [Remote host closed the connection]
puck_ has joined #dri-devel
<Lynne>
I think I found a fundamental issue with how video decoding works
<Lynne>
when decoding, you decode to size-aligned images, with the padding being generally at the bottom
<Lynne>
the decoder decodes, leaving junk at the bottom in the padding
<Lynne>
but because the vkimage is oversized, reading into the padding is valid
<Lynne>
so when you do bilinear sampling at the very bottom, the bottom-most line will contain junk
<Lynne>
and if you use a multi-tap sampler, it's even worse
<Lynne>
you can't alias non-disjoing multiplane images either, so it's not like you could bind the memory to a regular-sized vkimage (the layout will be a mismatch)
Vanfanel_ has quit [Ping timeout: 480 seconds]
<jkqxz_>
Lynne: Is there not some way to clamp at the edges to avoid that? I remember hitting exactly the same issue in D3D a while ago (manifesting as greenish borders at right/bottom), but it was easily avoided once you knew about it.
<Lynne>
only way I can think of is for users to always use a compute shader with a boundary condition, which is very vulkan indeed
<Lynne>
imageviews would be the correct place to put a clamp like that, but I didn't see any way for that
<Lynne>
the most correct way is of course to just ask the driver to do the padding, but no such option
<jenatali>
Yeah I'm not aware of any way to clamp to an arbitrary coordinate that's not the edge of the image
<jenatali>
In D3D or VK for the record
Lynne has quit [Remote host closed the connection]
Lynne has joined #dri-devel
<jkqxz_>
Trying to remember the D3D case I had, I think that the answer was actually that it was shared with a different device instance (because asynchronous threading), and then the texture on the second device used the actual size.
pa has quit [Ping timeout: 480 seconds]
gouchi has joined #dri-devel
gouchi has quit []
<glehmann>
do we have a nir pass that does if (inot(cond)) {block2} else {block3} -> if (cond) {block3} else {block2} somewhere?
<glehmann>
I only found a pass in nir_opt_if that does the opposite if the if block is empty
junaid has joined #dri-devel
Vanfanel_ has joined #dri-devel
fxkamd has joined #dri-devel
kts has quit [Quit: Konversation terminated!]
sukrutb__ has joined #dri-devel
fxkamd has quit []
fxkamd has joined #dri-devel
fxkamd has quit []
thenemesis has joined #dri-devel
Vanfanel_ has quit [Quit: Lost terminal]
<Lynne>
any ideas for a workaround?
kzd has joined #dri-devel
smilessh has quit [Ping timeout: 480 seconds]
junaid has quit [Ping timeout: 480 seconds]
pa has joined #dri-devel
jfalempe_ has quit [Quit: Leaving]
iive has joined #dri-devel
thenemesis has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
sukrutb__ has quit [Remote host closed the connection]
junaid has joined #dri-devel
nabaiste^ has joined #dri-devel
Leopold has quit [Remote host closed the connection]
Leopold has joined #dri-devel
junaid has quit [Ping timeout: 480 seconds]
Lyude has quit [Quit: Bouncer restarting]
Lyude has joined #dri-devel
Leopold has quit [Remote host closed the connection]
Lyude has quit [Quit: Bouncer restarting]
sukrutb has joined #dri-devel
rasterman has joined #dri-devel
Leopold_ has joined #dri-devel
benjaminl has joined #dri-devel
sima has quit [Ping timeout: 480 seconds]
<benjaminl>
hi, I'm currently working on getting rusticl running on my ivy bridge laptop. is this the kind of thing that would be accepted upstream, or is the maintenance effort for supporting the old hardware too much?
rasterman has quit [Quit: Gettin' stinky!]
<emersion>
Lynne: is it possible to create another image aliasing the same VkMemory, same width/stride but smaller height?
<Lynne>
nope, layout would change
<Lynne>
there's no way to ask for a specific stride for an image either
<Lynne>
how did no one think this may be a problem? the extension was first published 2 years ago
<Lynne>
it'll be at least 6 months of discussion at TSG pace to fix this, and knowing them, it'll be a yet another capability, because what if some hardware/vendor is unable to?
<Lynne>
this is a pretty much a fiasco
<psykose>
drama alert in linux graphics
<Lynne>
it's a strategy, raise enough stink, and hope on monday they say "we're terrible at this video malerkey, could you tell us what to do?"
Leopold_ has quit []
Leopold_ has joined #dri-devel
<Lynne>
but it is pretty much rendering the extension useless without big workarounds that everyone would say "no, I'll use vdpau, interlaced-only output sounds reasonably sane"
<psykose>
vdpau was ahead of its time
Jeremy_Rand_Talos has quit [Remote host closed the connection]
Jeremy_Rand_Talos has joined #dri-devel
iive has quit [Quit: They came for me...]
Leopold_ has quit [Ping timeout: 480 seconds]
Guest1278 has quit [Remote host closed the connection]