ChanServ changed the topic of #dri-devel to: <ajax> nothing involved with X should ever be unable to find a bar
maxzor has quit [Ping timeout: 480 seconds]
iive has quit [Quit: They came for me...]
<zf>
I'm encountering a problem on radeonsi where adding "invariant gl_Position;" to a shader causes artifacts. this is bizarre since, if I'm not misreading, nothing anywhere in mesa actualy cares whether a variable is invariant or not. does anyone have any hints or guesses as to what may be going on here?
anzel has quit [Remote host closed the connection]
<JoshuaAshton>
zf: Invariant will disable certain optimizations on a path to the result of that variable such that any two shaders with the same shader code producing that variable will produce identical outcomes
<JoshuaAshton>
Looks pretty implemented to me?
<zf>
I'm fully aware of what invariant does
sadlerap has joined #dri-devel
<zf>
as far as I can tell, on mesa, invariant is implemented, it sets a boolean field "invariant" to true; that's propagated to nir and tgsi, there's a pass to propagate it to dependent stores, but nothing actually *interprets* it
sima has quit [Ping timeout: 480 seconds]
sadlerap4 has quit [Ping timeout: 480 seconds]
<zf>
presumably because the default behaviour is as if it's always set. that's fine, but then it's baffling that adding that declaration makes a difference
<JoshuaAshton>
The glsl -> nir interprets that, same as the Vulkan path, no?
<zf>
interprets how?
<zf>
it sets the equivalent nir attribute, but I can't find any consumer of nir that consumes that attribute in turn
camus has quit [Remote host closed the connection]
camus has joined #dri-devel
kts has joined #dri-devel
kts has quit []
kts has joined #dri-devel
Company has joined #dri-devel
<karolherbst>
uhhh...
<karolherbst>
I think our scratch memory lowering needs to be smarter
<karolherbst>
but this code is also cursed
camus1 has joined #dri-devel
camus has quit [Ping timeout: 480 seconds]
<karolherbst>
gfxstrand: we might want to align scratch memory a bit less optimal in lower_explicit_io, I've encountered a kernel where it has u8[3] arrays, but the first two components are loaded as a 16 bit value, which leads to unaligned accesses if two of them are after each other (like 2 u8[3] arrays) and the second one causes the nir shader to do a 16 = load_scratch(0x3) access...
<karolherbst>
but the source code is also heavily obfuscated, so no idea if we mess it up by ignoring some alignment or something else is going wrong here ...
<karolherbst>
but that also let us ran into a intel backend compiler bug, so there is that...
yyds has joined #dri-devel
<jenatali>
karolherbst: yeah, seems like a tradeoff between consuming less memory vs providing better alignments. Sounds like a hard problem to solve
maxzor_ has quit [Ping timeout: 480 seconds]
crabbedhaloablut has joined #dri-devel
loki_val has joined #dri-devel
crabbedhaloablut has quit [Ping timeout: 480 seconds]
crabbedhaloablut has joined #dri-devel
loki_val has quit [Ping timeout: 480 seconds]
heat has quit [Ping timeout: 480 seconds]
macslayer has quit [Ping timeout: 480 seconds]
Leopold_ has quit [Remote host closed the connection]
Leopold_ has joined #dri-devel
kts has quit [Remote host closed the connection]
kts has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
<karolherbst>
jenatali: it sounds more like an optimal placement problem, but yeah...
glennk has joined #dri-devel
Duke`` has joined #dri-devel
fab has joined #dri-devel
luc has joined #dri-devel
sghuge has quit [Remote host closed the connection]
<luc>
i wonder if there is any technical reason why we don't upload other texture targets (e.g. 2D_ARRAY) in pixel buffer. or it is just no such use case
fab has quit [Ping timeout: 480 seconds]
YuGiOhJCJ has quit [Remote host closed the connection]
YuGiOhJCJ has joined #dri-devel
<karolherbst>
jenatali: the biggest problem is just, that the source code is so obfuscated, that I can't tell if those 8 bit arrays even exist or if something else is going on 🙃
<alyssa>
karolherbst: why does llvm not like 16-bit math
maxzor_ has joined #dri-devel
kts has joined #dri-devel
glennk has joined #dri-devel
YuGiOhJCJ has quit [Quit: YuGiOhJCJ]
<jenatali>
alyssa: in what context?
<alyssa>
jenatali: clc is turning 16-bit math into 32-bit math + piles of conversions
<alyssa>
wheee
<jenatali>
That... sounds wrong
<alyssa>
wheeeeeeeee
<jenatali>
What kind of math? Basic arithmetic?
<alyssa>
Yes
nashpa has joined #dri-devel
dliviu has quit [Ping timeout: 480 seconds]
heat has joined #dri-devel
nashpa has quit [Ping timeout: 480 seconds]
dliviu has joined #dri-devel
user has joined #dri-devel
user is now known as Guest13068
gouchi has joined #dri-devel
Guest13068 has quit []
camus1 has quit [Remote host closed the connection]
camus has joined #dri-devel
simondnnsn has joined #dri-devel
user_ has joined #dri-devel
simondnnsn has quit [Ping timeout: 480 seconds]
user_ has quit [Ping timeout: 480 seconds]
glennk has quit [Ping timeout: 480 seconds]
gouchi has quit [Remote host closed the connection]
maxzor_ has quit [Ping timeout: 480 seconds]
maxzor_ has joined #dri-devel
simondnnsn has joined #dri-devel
simondnnsn has quit [Read error: No route to host]
kzd has joined #dri-devel
kts has quit [Quit: Leaving]
maxzor_ has quit [Ping timeout: 480 seconds]
glennk has joined #dri-devel
AnuthaDev has joined #dri-devel
<mareko>
luc: PBO is a buffer, not a texture
heat has quit [Remote host closed the connection]
<mareko>
the source is a buffer, the destination is a texture
heat has joined #dri-devel
iive has joined #dri-devel
gabertron has quit [Ping timeout: 480 seconds]
AnuthaDev has quit []
AnuthaDev has joined #dri-devel
<karolherbst>
alyssa: I guess it depends on the code and what LLVM does with it
<karolherbst>
but yeah.. LLVM is sometimes.. a bit silly
<karolherbst>
I _hope_ it becomes better with the LLVM SPIR-V backend
<karolherbst>
then we can also enable optimizations
<karolherbst>
and I know that LLVM has some to reduce the bit size as well
<karolherbst>
but libclc is also implementing some 32 bit ops using 64 bit math, so there is that as well
AnuthaDev has quit [Ping timeout: 480 seconds]
AnuthaDev has joined #dri-devel
<mareko>
I'm considering removing AMD from the CI again and this time for real because the libdrm upgrade isn't progressing
<mareko>
and it's been almost 2 weeks
<karolherbst>
That's fine, though I'd be careful with making statements which could be read as "I'm disappointed nobody did the work I need during holiday season". People where on vacation and wanted to take time of, so I wouldn't hold them against it if they didn't want to work on stuff
junaid has joined #dri-devel
junaid has quit [Quit: leaving]
<mareko>
you are making incorrect assumptions
<mareko>
when bug fixes depend on the latest libdrm, and libdrm isn't possible to upgrade, then hard choices have to be made
eukara has joined #dri-devel
<mareko>
that's made after all other options have been exhausted
<mareko>
it's really a fuckup of the CI maintainers making it hard to upgrade libdrm in the first place
<mareko>
it was not a fuckup, it was a lack of communication between Mesa developers and CI developers because Mesa developers who understand how things work don't often review CI changes, so CI developers unknowingly made the wrong choices
<mareko>
or decisions
<mareko>
there is nobody to blame for anything, shit just happens
<karolherbst>
yeah.. and I'm also not saying that it's not a pain. It's fine to disable the CI if that makes you fix the bug in the short term and we can enable it later
<karolherbst>
I just would be careful about expecting people to work during holiday season
<mareko>
upstream never sleeps
Company has quit [Remote host closed the connection]
simondnnsn has joined #dri-devel
junaid has joined #dri-devel
gouchi has joined #dri-devel
alanc has quit [Remote host closed the connection]
alanc has joined #dri-devel
simondnnsn has quit [Ping timeout: 480 seconds]
xq has quit [Ping timeout: 480 seconds]
junaid has quit [Remote host closed the connection]
JohnnyonFlame has joined #dri-devel
tobiasjakobi has joined #dri-devel
tobiasjakobi has quit [Remote host closed the connection]
tobiasjakobi has joined #dri-devel
<emersion>
mareko: what makes libdrm difficult to upgrade?
tobiasjakobi has quit []
<mareko>
emersion: gitlab CI uses libdrm from the distro instead of building it
<emersion>
ah, i see
<mareko>
can't update libdrm if the distro doesn't do it, which is sully
<mareko>
silly*
AnuthaDev has quit []
dliviu has quit [Ping timeout: 480 seconds]
Stary has quit [Ping timeout: 480 seconds]
Stary has joined #dri-devel
dliviu has joined #dri-devel
angerctl has quit [Ping timeout: 480 seconds]
Namarrgon has joined #dri-devel
gabertron has joined #dri-devel
<DavidHeidelberg>
emersion: WIP, I haven't forgot.
<DavidHeidelberg>
I just having issue with some weirdness on ppc64 and s390x, otherwise it's resolved
Duke`` has quit [Ping timeout: 480 seconds]
<DavidHeidelberg>
(weirdness different dependencies)
apinheiro has quit [Quit: Leaving]
gouchi has quit [Remote host closed the connection]
crabbedhaloablut has quit []
maxzor_ has joined #dri-devel
Leopold_ has quit [Remote host closed the connection]
Leopold_ has joined #dri-devel
jeeeun841351908 has quit [Read error: Connection reset by peer]