00:49 <HappY[m]> <konradybcio> "HappY🤗: try using mipi_dsi_dcs_s..." <- after this display is black and error is `[drm:dpu_crtc_get_vblank_counter] *ERROR* no encoder found for crtc 0`

01:06 <konradybcio> are you sure it's black and not at 0 brightness

01:06 <konradybcio> try echo 1000 > /sys/class/backlight/*/brightness

01:14 <Degdag_Med[m]> <konradybcio> "are you sure it's black and..." <- I have the same issue and removing _large just make it worse , when adjusting the brightness it's not continues from low to high , it changes randomly and even goes blank

01:14 <konradybcio> _large just handles 16-bit-wide big endian values

01:15 <Degdag_Med[m]> * In reply to @konradybcio:matrix.org

01:15 <Degdag_Med[m]> I have the same issue and removing _large just make it worse , when adjusting the brightness it's not continues from low to high , it changes randomly and even goes black

01:15 <Degdag_Med[m]> are you sure it's black and not at 0 brightness

01:15 <konradybcio> panels accept and expect a range of bit-wideness and bit order values

01:16 <Degdag_Med[m]> How to check if my panel handle 16 or 8 bit-wide value?

01:17 <konradybcio> what's the maximum backlight value specified in downstream dt?

01:20 <Degdag_Med[m]> konradybcio: qcom,mdss-brightness-max-level = <0x7ff>;

01:20 <Degdag_Med[m]> 2047

01:21 <konradybcio> that's equivalent to setting 11 low bits

01:21 <konradybcio> is the panel brighter if you send 255 than if you send 512?

01:22 <Degdag_Med[m]> Not sure let me test

01:38 <Degdag_Med[m]> <konradybcio> "is the panel brighter if you..." <- Yes it is

01:40 <konradybcio> and if you send 2048 does it go black?

01:42 <Degdag_Med[m]> Degdag_Med[m]: This with mipi_dsi_dcs_set_display_brightness_large

01:43 <Degdag_Med[m]> konradybcio: Nah it's maxed at 2047

01:44 <konradybcio> did you update the function to _large in both get and set functions?

01:45 <Degdag_Med[m]> with mipi_dsi_dcs_set_display_brightness

01:45 <Degdag_Med[m]> I'm sure it can get black on random brightness value

01:45 <Degdag_Med[m]> konradybcio: Yes sure

01:46 <Degdag_Med[m]> But with _large brightness works correctly it's just has some glitches

01:46 <Degdag_Med[m]> When adjusting the brightness

01:51 <Degdag_Med[m]> I'm not entirely sure but this might just be an issue with Mesa

01:52 <flamingradian[m]> I believe the brightness setting is sent directly to the kernel

01:53 <Degdag_Med[m]> Brightness is fine , just the ui dose glitch

01:54 <Degdag_Med[m]> Tried gnome KDE phosh xfce all has this issue

02:00 <flamingradian[m]> if 255 brightness is brighter than 512, then I think it's a brightness problem

02:09 <Degdag_Med[m]> <flamingradian[m]> "if 255 brightness is brighter..." <- It's not

02:10 <Degdag_Med[m]> <Degdag_Med[m]> "Yes it is" <- Sorry I misunderstood

02:10 <Degdag_Med[m]> No it isn't brighter

02:10 <Degdag_Med[m]> 512 is brighter than 255

02:12 <flamingradian[m]> Okay, are the graphical glitches only when changing brightness, or do they happen when something else is happening?

02:12 <Degdag_Med[m]> flamingradian[m]: Only when changing the brightness

02:17 <flamingradian[m]> if it's a bit order issue, I'd set the brightness to each power of 2 from 1 through 1024 and see if it keeps getting brighter

02:39 <HappY[m]> <konradybcio> "what's the maximum backlight..." <- This is my all types of brightness level..... (full message at <https://matrix.org/_matrix/media/v3/download/matrix.org/xxejzqggslUaaNVJdNGjsXZb>)

08:26 <Marijn[m]> <flamingradian[m]> "Okay, are the graphical glitches..." <- Happens on other devices as well, probably something with interleaving brightness commands in the DSI stream while it is transmitting pixel data, though on qcom I thought BURST_MODE was supposed to mitigate that

08:30 <z3ntu> fwiw I see also bad display glitches when changing brightness on msm8974 Fairphone 2, that one uses these dsi dcs commands for changing brightness

08:47 <Marijn[m]> Hopefully folks don't mistake the glitchiness for using the wrong set_brightness(_large) function and/or messing up endianness, they're two distinct issues

08:51 <z3ntu> on this msm8974 it's glitchyness as in the picture jumps a bit randomly up and down the screen, I'd guess the synchronization between the start and end of the pixel data is lost

11:25 <HappY[m]> <z3ntu> "on this msm8974 it's glitchyness..." <- Same happen with me.. suppose I open keyboard.. after work close and then I see screen colour changed & sometime screen going up & sometimes down..

15:02 <Degdag_Med[m]> <Marijn[m]> "Hopefully folks don't mistake..." <- Well for me the brightness is fine.

15:02 <Degdag_Med[m]> if I swap the brightness slider slowly there's even no glitches at all or if I change it without swapping

15:35 <HappY[m]> <Degdag_Med[m]> "Well for me the brightness is..." <- > <@degdag:matrix.org> Well for me the brightness is fine.

15:35 <HappY[m]> > if I swap the brightness slider slowly there's even no glitches at all or if I change it without swapping

15:35 <HappY[m]> Just checked same like you.. if I reduce brightness without swipe then no issues..

15:36 <HappY[m]> But I can reduce brightness upto 50%

16:10 <Degdag_Med[m]> <HappY[m]> "But I can reduce brightness upto..." <- For brightness control works as expected it can go low and night at max without issue , only the graphical glitches occur

16:11 <HappY[m]> Degdag_Med[m]: With large?

16:11 <HappY[m]> Now I am on large

16:11 <Degdag_Med[m]> HappY[m]: Yes

16:12 <HappY[m]> Without swipe I also don't have issues only issue with 1% 49% working fine or 50% to 100% working fine

16:14 <HappY[m]> Check this video you can understand https://matrix.to/#/!mCFUAbDMChDbEFqHbW:matrix.org/$U4Lvv2lyV9si-m_8X5YJdh-628XHgpV11_2ks0cUuTU?via=matrix.org&via=reactos.org&via=igalia.com

16:14 <bamse> ajhalaney[m]: damn you! you tricked me to review the ufs series again

16:17 <Degdag_Med[m]> HappY[m]: I saw it , probably I don't have the same as you since my BL control works as expected

16:17 <ajhalaney[m]> tricking others into doing work is part of my job description i think bamse :P

16:17 <bamse> ajhalaney[m]: i thought that was my job description ;)

16:18 <ajhalaney[m]> what would you say you do here?

16:19 <HappY[m]> Degdag_Med[m]: But its okay it's usable.. if I reduce to 1 to 49% working fine without swipe.. & same 50 to 100% working fine without swipe..