<jow>
nbd: I try to understand the UBUS_ATTR_NO_REPLY semantics wrt. ubus notify requests
rua has quit [Ping timeout: 480 seconds]
<jow>
what exactly is a "reply" in this context? Can subscribers respond to incoming notifications? If so, how? Can you suggest any example code?
<jow>
is that what the data_cb of struct ubus_notify_request.req is for?
<jow>
invoked once for each reply of each subscriber?
Kali_ has quit [Quit: leaving]
rua has joined #openwrt-devel
rua has quit [Ping timeout: 480 seconds]
<nbd>
jow: blocking ubus_notify waits for all subscribers to complete
<nbd>
jow: when using ubus_notify with timeout -1, it means that the subscribers don't need to bother with a status reply
<nbd>
since the notifier will not wait for one
minimal has joined #openwrt-devel
rua has joined #openwrt-devel
_lore_ has quit [Server closed connection]
_lore_ has joined #openwrt-devel
<stintel>
nbd: have you tested autorate-ingress? there seems to be a problem in the qosify init script that enables it, while it's not enabled for that device. additionally, enabling that on a mostly idle devices results in the ingress rate lowering until traffic is barely possible at all
<stintel>
while this sounds like a bug in cake, I propose to either disable it in qosify for now. alternatively we can print a warning, but this could be very easily overlooked
<stintel>
thoughts?
<stintel>
I'll look into why the init script enables it even if it's not
<nbd>
i'm fine with disabling it by default
<stintel>
oh, it is enabled by default?
<nbd>
yes
<nbd>
i think so
<stintel>
that would explain something
<stintel>
let me dig into the code again
<nbd>
btw. i've created a testing branch, where i've implemented dns snooping within the qosify daemon
<nbd>
in a way that shouldn't cause performance issues
<stintel>
that's neat
<stintel>
although we realised the whole dns snooping is going to be useless in the future, as people/operating systems/.. switch to DoH/DoT/DoQ
<nbd>
at some point, yes
<stintel>
I will ask my colleagues if they can test it
<nbd>
at that point the clients devices/browsers will need some helpers to feed qosify
owrt-1907-builds has quit [Server closed connection]
owrt-1907-builds has joined #openwrt-devel
rua has quit [Ping timeout: 480 seconds]
Guest328 has quit [Server closed connection]
foxtrot has joined #openwrt-devel
<stintel>
cfg->autorate_ingress = true;
<stintel>
ok I missed that :)
foxtrot is now known as Guest1274
<stintel>
nbd: can I add your ack on this ? https://git.openwrt.org/?p=project/qosify.git;a=commitdiff;h=ae86fe96fa9d1ed148ad4429486cea5b67358e57
<stintel>
and same question for https://git.openwrt.org/?p=openwrt/staging/stintel.git;a=commitdiff;h=619260d991a61642d1e39d2f15a93edb81aea4a0
rua has joined #openwrt-devel
rua has quit [Ping timeout: 480 seconds]
rua has joined #openwrt-devel
philipp64 has joined #openwrt-devel
<stintel>
in 26 minutes, 100Mbps dropped to <5000kbps with autorate
<nbd>
ouch
philipp64 has quit [Quit: philipp64]
agb[m] has joined #openwrt-devel
Guest1228 has joined #openwrt-devel
aparcar[m] has joined #openwrt-devel
bluse-blue[m] has joined #openwrt-devel
decke[m] has joined #openwrt-devel
evils[m] has joined #openwrt-devel
fieryeagle954[m] has joined #openwrt-devel
fpsusername[m] has joined #openwrt-devel
gnustomp[m] has joined #openwrt-devel
GuruPrasathGovindarajan[m] has joined #openwrt-devel
hexagonwin[m] has joined #openwrt-devel
John[m]12345678 has joined #openwrt-devel
JuniorJPDJ has joined #openwrt-devel
Q__ has joined #openwrt-devel
lipnitsk has joined #openwrt-devel
MatMaul[m] has joined #openwrt-devel
nick[m]1234 has joined #openwrt-devel
olmari has joined #openwrt-devel
pavlix has joined #openwrt-devel
t4h4[m] has joined #openwrt-devel
MatrixTravelerbot[m] has joined #openwrt-devel
whatevs111[m] has joined #openwrt-devel
will[m] has joined #openwrt-devel
Misanthropos has quit [Ping timeout: 480 seconds]
<Slimey>
heh
SherlockDomes has quit [Read error: Connection reset by peer]
<stintel>
we're now on a 1999 Internet connection :D
<Habbie>
haha
<jow>
nbd: I suppose I can from within a subscriber callback, invoke ubus_send_reply() on the passed req context and it'
<jow>
ll end up in the .data_cb() of the notifier?
<jow>
and final question: is it valid to (regardless of the context, also for normal object methods invocations) do ubus_send_reply() and return a status code != UBUS_STATUS_OK ?
shibboleth has joined #openwrt-devel
noltari_ has joined #openwrt-devel
noltari has quit [Remote host closed the connection]
noltari_ has quit [Read error: Connection reset by peer]
noltari has joined #openwrt-devel
ecloud has quit [Ping timeout: 480 seconds]
srslypascal has quit [Ping timeout: 480 seconds]
kenny has quit []
ecloud has joined #openwrt-devel
Grommish_ has joined #openwrt-devel
mattytap__ has joined #openwrt-devel
Grommish has quit [Ping timeout: 480 seconds]
srslypascal has joined #openwrt-devel
mattytap_ has quit [Ping timeout: 480 seconds]
ephemer0l has quit [Server closed connection]
ephemer0l has joined #openwrt-devel
minimal has quit [Remote host closed the connection]
<f00b4r0>
stintel: yes, but with ultra low latency! :D
minimal has joined #openwrt-devel
<nbd>
jow: yes, you can send replies from the subscriber cb, and data replies are independent of the status code
srslypascal has quit [Remote host closed the connection]
srslypascal has joined #openwrt-devel
<jow>
nbd: thanks
Rayyan has quit [Server closed connection]
Rayyan has joined #openwrt-devel
Rayyan is now known as Guest1305
minimal has quit [Remote host closed the connection]
minimal has joined #openwrt-devel
minimal has quit [Ping timeout: 480 seconds]
rua has quit [Ping timeout: 480 seconds]
rua has joined #openwrt-devel
clayface_ has joined #openwrt-devel
clayface has quit [Ping timeout: 480 seconds]
Tapper has joined #openwrt-devel
romany has quit [Server closed connection]
romany has joined #openwrt-devel
PaulFertser has quit [Server closed connection]
PaulFertser has joined #openwrt-devel
cbeznea has quit [Quit: Leaving.]
cbeznea has joined #openwrt-devel
cbeznea has quit []
cbeznea has joined #openwrt-devel
gladiac has quit [Quit: k thx bye]
cbeznea1 has joined #openwrt-devel
cbeznea1 has quit []
cbeznea has quit [Ping timeout: 480 seconds]
guidosarducci has quit [Remote host closed the connection]