<Ansuel>
we should have some warning for the same name and led core appending stuff to it automatically
<Ansuel>
to me it seems somehow led probing is failing? or even the general probe of the phy???
<robimarko>
PHY is fully probed and the driver is attached
<Ansuel>
do you have that device by chance?
<robimarko>
Yeah
<robimarko>
I am looking live
<Ansuel>
oh! thank god... then if you have time one first test would be comment one of the 2 led and see if one magically appear
<robimarko>
Just working on it
<Ansuel>
thanks
<robimarko>
And nope, removed the second LED and still none were registered
<robimarko>
What code registers the LED-s?
<robimarko>
Ok, its of_phy_leds
<Ansuel>
hoped it was a node problem... well the next guess is that of_phy_leds is returning error
<Ansuel>
(or not getting called at all)
xback has joined #openwrt-devel
<robimarko>
Ansuel: Its not getting called at all
<robimarko>
Because: # CONFIG_PHYLIB_LEDS is not set
<robimarko>
Yeah, once I enabled it LED got registered
<Ansuel>
o.O
<Ansuel>
that is optional?
<robimarko>
Its not
<robimarko>
of_phy_leds is guarded by if (IS_ENABLED(CONFIG_PHYLIB_LEDS))
<robimarko>
And CONFIG_PHYLIB_LEDS is disabled in the generic config
<robimarko>
Only Filogic enables it
<Ansuel>
no i mean we are not enabling CONFIG_PHYLIB_LEDS by default?
<robimarko>
No
<Ansuel>
oh... ok we disable it by default
<Ansuel>
easy fix i guess
<robimarko>
Yeah, already making a PR
<Ansuel>
but i'm tempted to enable it globally
<robimarko>
Does it depend on CONFIG_LEDS_CLASS?
<robimarko>
CONFIG_PHYLIB is not globaly enabled
<robimarko>
So you cant enable CONFIG_PHYLIB_LEDS
<Ansuel>
depends on LEDS_CLASS=y || LEDS_CLASS=PHYLIB
<Ansuel>
if we don't have phylib enabled than no go for generic...
<robimarko>
Yes, its disabled in generic ofnig
<Ansuel>
(we can still enable it globally as it would be dropped later but it would be something that will be dropped on the next guy that refresh the generic kernel config)
<Ansuel>
so yes enable it only for qualcommax
<robimarko>
Yes, it would get drop silently and then we are back at square one
<Ansuel>
meanwhile i feel i have some kind of curse in getting reviwers fight on each other everytime i send a patch ahahahah
<robimarko>
Well, that tends to happen when everybody is looking at it from their subsystem point of view
minimal has joined #openwrt-devel
xback has quit [Ping timeout: 480 seconds]
xback has joined #openwrt-devel
rua has quit [Remote host closed the connection]
rua has joined #openwrt-devel
<xback>
robimarko: I wonder if your mac80211 bump would fix the wifi 6E connection issues i'm seeing :-) giving it a try ..
<KanjiMonster>
PHYLIB_LEDS isn't a user selectable symbol, so it doesn't matter if you set it in the linux config or not, its value will always be autocalculated on build
goliath has quit [Quit: SIGSEGV]
<robimarko>
KanjiMonster, its definitively user selectable
<robimarko>
I selected it via kernel_menuconfig
<robimarko>
But you are right, upstream version is not user selectable