<csharper2005>
the tool is intented for ASUS routers and allows install OpenWrt without UART soldering.
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
rua has quit [Quit: Leaving.]
theJoker8814 has joined #openwrt-devel
xback has quit [Remote host closed the connection]
xback has joined #openwrt-devel
goetz has joined #openwrt-devel
<mrkiko>
jow: s/tolate/tollerate/ ? Or am I missing the english word?
rua has joined #openwrt-devel
jkl has quit [Quit: Gone.]
SlimeyX has quit [Ping timeout: 480 seconds]
<rmilecki>
mrkiko: s/tollerate/tolerate/ ? Or am I missing the english word?
<rmilecki>
;)
<rmilecki>
no offense!
nixuser has quit [Ping timeout: 480 seconds]
<mrkiko>
rmilecki: :D
gch981213 has joined #openwrt-devel
<mrkiko>
rmilecki: jow: however, when I say I might have missed the english word I don't meant to be sarcastic. I was just telling that some english words may exist and I don't know them. Actually a lot of them surely :)
<rmilecki>
mrkiko: sure, i don't think noone would feel insulted by that or treat it as a sarcasm
theJoker8814 has quit [Quit: theJoker8814]
<mrkiko>
rmilecki: :) in Italian I do use sarcasm, but in english I feel like I never know exactly how to transmit emotions withthe language
<rmilecki>
ah, i know that feeling
<rmilecki>
i use English daily for years yet I realized I'll never be able to joke in it
<mrkiko>
rmilecki: BTW, may you have some ideas about my rootfs mistery (talked about it here during this week)
<mrkiko>
rmilecki: :D maybe I am able to kinda joke, but I am always under the impression things can go out of hand quickly. In my native languageof course I can be more precise, but english ...
<rmilecki>
mrkiko: i'm sorry I can't recall that rootfs mistery
<rmilecki>
can you remind me what was that?
<mrkiko>
rmilecki: on gl-mt2500 and gl-mt6000 (mediatek/eMC), OpenWrt started using the whole space on the rootfs partition, not just the value in ROOTFS_PARTSIZE. I am Ok with that but wanted to know from where it comes in the code in thefirst place, and maybe make it configurable. I noticed it first-hand with gl-mt2500, but an user reported in the the gl-mt6000 thread discussion,
<mrkiko>
and even tough looking more carefully commits around 15 Feb/19 Feb, I didn't find the reason for it. And I am not sure this happens on other eMMC devices as well, even tough the person porting the X3000 didn't experience that (I asked it via comments in their PR).
<rmilecki>
another person look at that situation could be better
<rmilecki>
i'm probably already tained by discussion I had so far
<rmilecki>
i'm arguing about validiting of requested changes
xback has quit [Remote host closed the connection]
xback has joined #openwrt-devel
<robimarko>
Yeah, that person kind of has quite a narrow view on the world
<robimarko>
He kind of stole the AX89X thread
csharper2005 has joined #openwrt-devel
<mrkiko>
jow: thanks a lot!!
mrkiko has quit [Quit: leaving]
<jow>
robimarko: rmilecki: refuse to merge and close
<jow>
discussion will not end here but continue wirth every single contribution
mrkiko has joined #openwrt-devel
<jow>
in the end it's the project having to maintain the code in the long run and the probability of the submitter still being around in 10, 20 years is low
<robimarko>
I currently deal with him only if he really annoys me
<jow>
some attitude and passion about the own code is fine, but flat out refusing to address review comments simply makes it a NAK
<jow>
the tool also contains compatibility code with microsoft visual C compilers
<jow>
which will never ever get hit
<jow>
so it's simply messy code, unmaintainable. period.
<ynezz>
ok, done, thanks for double checking
<rmilecki>
thanks guys
<stintel>
yeah, I was going to say just close it
<stintel>
if they start flaming, block and report their profile
<stintel>
no use getting worked up (and eventually burnt out) over stuff like that
<rmilecki>
ynezz: if you would have time to add GitHub checks for new code not introducing any compilation warnings that would be great
<rmilecki>
ynezz: i'm not sure how complex that may be
<rmilecki>
ynezz: i've sent some patches getting rid of warnings except one last one I'm not 100% how to handle
<ynezz>
Re: tabs Vs spaces discussion, for that we would likely need to resort to some common formating tool/config, then reformat the project, but this is usually a bit controversial :P
<ynezz>
due to the Git history/blame etc. which I understand, but then you need to choose between additional manual review/work and automation, I don't see other option
<ynezz>
yes, we could use some LLM based solution, but once it starts hallucinating, we're doomed and banned from GitHub
jeff___m has quit [Ping timeout: 480 seconds]
<rmilecki>
LLM? Wiki says "large language model"
<stintel>
yeah they tend to hallucinate alright ;)
froztbyte has joined #openwrt-devel
<ynezz>
thinking about it a bit more, we could simply set a CI config option, that prefered indentation for the project is spaces/tabs and then just assure it on the (+) added/changed lines in that particular pull request
<ynezz>
but not sure if this special handling is worth doing, considering the possible corner cases, maintenance load etc.
<PaulFertser>
A reasonable person would just M-x tabify (or untabify) when asked by a maintainer and skip the argument. Accepting contributions from unreasonable people is too problematic in many other aspects anyway.
<f00b4r0>
people using spaces to indent aren't reasonable to begin with
* f00b4r0
runs
zer0def has quit [Ping timeout: 480 seconds]
<ynezz>
our idea is to put the bot/CI in front of the reviewers, because for some reason folks don't take (automated) reviews from bots personally :P
<f00b4r0>
that makes sense
<ynezz>
so one could start review stuff once it have `ci:ready-for-review` tag or such
zer0def has joined #openwrt-devel
<mrkiko>
you will forgive me if for my submissions I might still rely on e-mail? :D
<jow>
I indent with both tabs *and* spaces to anny people :)
<jow>
tabs to indent the block and spaces to column-align multiline expressions
<jow>
slowly giving up on this though as most tooling does not cope well with it
<f00b4r0>
i do that too. Xcode handles it well ;)
<PaulFertser>
It's default in Emacs, it uses as many tabs as possible and then adds spaces to align precisely.
nixuser has joined #openwrt-devel
<robimarko>
I do that in Sublime as well
<jow>
iirc Kernel does too, right? E.g. when a function prototype / declaration spans multiple ines
<dwfreed>
jow: re what rmilecki said, at least in bash, ${#content} counts UTF-8 chars, rather than bytes; eg, with the example, it'll give 13 instead of 14