jeff___m has quit [Remote host closed the connection]
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
dangole has quit [Remote host closed the connection]
dangole has joined #openwrt-devel
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
jeff___m has joined #openwrt-devel
killgufo has quit [Quit: Byez]
jeff___m has quit [Remote host closed the connection]
killgufo has joined #openwrt-devel
fakuivan has quit [Remote host closed the connection]
fakuivan has joined #openwrt-devel
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
minimal has quit [Quit: Leaving]
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
tSYS has quit [Quit: *squeak*]
tSYS has joined #openwrt-devel
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
rua has quit [Remote host closed the connection]
rua has joined #openwrt-devel
jeff___m has joined #openwrt-devel
<owrt-images-builds> Build [#60](https://buildbot.openwrt.org/images/#/builders/155/builds/60) of `master_sunxi/cortexa8` completed successfully.
<owrt-images-builds> Build [#61](https://buildbot.openwrt.org/images/#/builders/45/builds/61) of `master_sunxi/cortexa7` completed successfully.
dangole has quit [Remote host closed the connection]
dangole has joined #openwrt-devel
dangole has quit [Remote host closed the connection]
jeff___m has quit [Remote host closed the connection]
cmonroe has quit [Ping timeout: 480 seconds]
jeff___m has joined #openwrt-devel
cmonroe has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
johnf has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
johnf has joined #openwrt-devel
rua has quit [Quit: Leaving.]
jeff___m has joined #openwrt-devel
goliath has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
<ynezz> KanjiMonster: hauke: https://github.com/openwrt/openwrt/pull/13646 (PKG_CVE_FIXES and PKG_CVE_IGNORE) ACK?
nixuser has quit [Ping timeout: 480 seconds]
nixuser has joined #openwrt-devel
robimarko has joined #openwrt-devel
rsalvaterra has joined #openwrt-devel
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
Tapper has joined #openwrt-devel
rmilecki has quit [Quit: Konversation terminated!]
rua has joined #openwrt-devel
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
rmilecki has joined #openwrt-devel
GNUmoon has quit [Remote host closed the connection]
GNUmoon has joined #openwrt-devel
GNUmoon has quit [Max SendQ exceeded]
GNUmoon has joined #openwrt-devel
<rmilecki> Piraty: we have different view on clean vs. confusing code ;)
<Piraty> i didn't read into it, it just appears to be not the usual shell spaghetti but be nicely partitioned into well meaning functions
GNUmoon has quit [Remote host closed the connection]
<rmilecki> /sbin/sysupgrade has:
<rmilecki> exports not grouped together (there is some code executed between)
<rmilecki> functions not grouped together (do_save_conffiles() is in the middle of code)
<rmilecki> unclear names:
<rmilecki> - does add_conffiles() add files to archive or where?
<rmilecki> - does do_save_conffiles() saves list of files somewhere? or actual files?
<rmilecki> - name "do_save_conffiles" suggests it does only saving but there is more logic and we don't have "save_conffiles"
<rmilecki> all code is mixed together - we don't have separated blocks for 1. parsing arguments 2. backups handling 3. sysupgrade handling
<rmilecki> *
<rmilecki> it's not a terrible spaghetti and it's still possible to understand it
<rmilecki> but some clear code flow would be nice
<rmilecki> oh, and in the middle of code we have "include /lib/upgrade"
<rmilecki> i'm not saying all of that is totally wrong, just probably could be refactored a bit
<Piraty> yeah i was confused by include, which is a crappy alias for "."/source
<f00b4r0> rmilecki: and it also throws random errors and terminates the calling shell session with non-zero
<f00b4r0> :)
<robimarko> And nicely fails without letting you know it failed and why
Tapper has quit [Read error: Connection reset by peer]
<Ansuel> After an initial successful authentication to an OpenWrt AP, a WPA3 client can reconnect to the AP with any random password provided MAC address remains the same. A malicious network observer could just read MAC and use it to gain access to network bypassing authentication.
<Ansuel> for some reason the algo goes from sae to open after first auth ?
<russell--> networks should be open anyway, /me approves
<ynezz> bloatware, use cables, luke
<nbd> Ansuel: wow, that's really weird
<jow> pff cables, carry the disk over to the other room
<nbd> though i'm somewhat skeptical about the report
<nbd> because in the wrong-password case, it says WPA: pairwise key handshake completed (RSN)
<Ansuel> nbd i bet it's something in mixed wpa2 and wpa3 or the algo getting wiped somewhere in the codeflow? If it's true it's a massive security hole
<nbd> i don't see how a RSN handshake could complete with the wrong password and allow data transfer
<Ansuel> the guy provided repro config tho so it should be ""easy"" to repro?
quinq has quit [Ping timeout: 480 seconds]
<nbd> i wonder if his client somehow caches the old credentials and tries them via SAE
<nbd> i mean not via SAE
<nbd> but PSK
<jow> Ansuel: wrt. that ticket... extraordinary claims require extraordinary evidence
quinq has joined #openwrt-devel
<Ansuel> it's very strange, the repro steps looks too easy to be true. He claimed the wpa3 is broken like it's just a marginal bug LOL
<jow> with zero evidence to back up, execept a few log lines from hostapd
<rsalvaterra> Holy crap, just read the bug report now.
<jow> at the very least I would've expected pcaps, client sdie wpa_supplicant logs etc.
<Ansuel> Should I test it... the thing looks basic enough...
<jow> how was the client disconnected?
<jow> sta kacked, client side triggered?
<nbd> Ansuel: sure, would be good to have another data point
<jow> how was the password changed and the reconnect performed?
<nbd> i just asked for clarification in the ticket
<jow> what was the client in the first place? linux/wpa_supp, android, ios, windows, ...
<Ansuel> QCA9563 ath10k i guess
<jow> the client mac looks random, which hints at a mobile client
<robimarko> Ansuel: BTW, I see you merged ipq60xx
<robimarko> :)
<Ansuel> robimarko yep but I need to check if some patch can be upstreamed, for the basic support it's good (still no wifi tho)
<robimarko> Ansuel: Yeah, I plan to restart working on it
<Ansuel> jow nbd this is the confusing part... Connect to AP with any random password ensuring MAC address remains the same
<robimarko> Mantas did upstream most of the patches he added
<Ansuel> is another device used?
<Ansuel> i mean i can use the samsung ""privacy"" feature that randomize mac on public wifi
<robimarko> Every phone has that
<Ansuel> nha that doesn't make sense... he say mac is the same
<jow> tbh it reads like one of those "port forwards are broken" reports
<Ansuel> with a simple test following his steps the phone correctly ask me the password again
<Ansuel> (as it's invalid)
<Ansuel> meanwhile on another topic...
<Ansuel> STRANGE DAY TODAY...
<Ansuel> Openwrt One is a good thing and people are already creating drama out of nothing o.o
<jow> yes, the punishment of voluntarily doing something
<jow> "you're producing e-waste"
<jow> "you're killing openwrt"
<robimarko> No good deed goes unpunished
<jow> "you suck and your idea is crap, go die"
<jow> "fuck you and fix your damn software instead"
<jow> makes one really enthusiastic about our community :)
<robimarko> I learned the hard way not to look for encouragment or thanks in the largest part of the community
<jow> yep
<robimarko> They somehow keep forgetting that nobody has an obligation to work on stuff they need
<Ansuel> the fun thing is that in the meeting we just talked about a new minor release and we were planning in the next 2 weeks if everything was right LIKE GOD DAMN >:(
Borromini has joined #openwrt-devel
<jow> even funnier is that the last maintenance release was twelve (!) weeks ago
<jow> with christmas holidays in between
<Ansuel> In all of this, one thing is ""good"". It seems people are curious about it and the project was noticed.
<Ansuel> robimarko sorry didn't notice your pr :(
<f00b4r0> nbd: hi, dunno if you saw my mt7915 crashdump? The device is still running but eventually will have to be rebooted as wifi is unuseable
<jow> robimarko: oh, there's no obligation? all those wasted years! ;)
<f00b4r0> heh :)
<nbd> f00b4r0: i've seen it, thanks. just didn't get around to analyzing it properly yet
<f00b4r0> nbd: no worries, do you think you'll need more data from the device or can I reboot it?
<nbd> one thing i suspect is that there is an issue with too much broadcast traffic potentially overflowing hw queues
<nbd> so i'm planning on attempting to add AQL for broadcast packets in mac80211 soon
<nbd> just need to find the time for it
<Ansuel> that might also benefits ath
<robimarko> Ansuel: No worries, I just made it like 10 minutes ago
<nbd> Ansuel: definitely
<nbd> that's why i decided to not try to deal with this in mt76 but move the solution to mac80211
johnf has quit [Quit: ZNC 1.7.5+deb4 - https://znc.in]
johnf has joined #openwrt-devel
theJoker8814 has joined #openwrt-devel
Borromini has quit [Read error: No route to host]
mentalow has quit [Quit: :]]
mentalow has joined #openwrt-devel
zer0def has joined #openwrt-devel
f00b4r0 has quit [Quit: bbl]
goliath has quit [Quit: SIGSEGV]
SlimeyX has quit [Ping timeout: 480 seconds]
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
Tapper has joined #openwrt-devel
goliath has joined #openwrt-devel
theJoker8814 has quit [Ping timeout: 480 seconds]
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
Mangix has quit [Read error: Connection reset by peer]
goliath has quit [Quit: SIGSEGV]
goliath has joined #openwrt-devel
bluew has joined #openwrt-devel
minimal has joined #openwrt-devel
<nbd> Ansuel: broadcast/multicast AQL works for me now. the commit is in my staging tree, if you want to test it
<Ansuel> nbd will test tomorrow thanks for the patch
lucenera has quit [Ping timeout: 480 seconds]
hanetzer1 has joined #openwrt-devel
hanetzer has quit [Ping timeout: 480 seconds]
robimarko has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
<mrkiko> Ansuel: can I pm?
<Ansuel> sure just write and I will answer when I have time. Currently relaxing a bit
<mrkiko> Ansuel: thanks
Mangix has joined #openwrt-devel
<Mangix> wonder how much that will break
<mrkiko> Mangix: I'm going to tell you in a moment :D
<mrkiko> Mangix: joking, but I am updating a system with the latest snapshot and that commit. Wondering if I am better in not preserving /etc/dropbear
<mrkiko> I enabed it atm
<Mangix> I don't know that AES is weak honestly
<Mangix> IIRC AES in CTR mode is fine
<Mangix> probably slow though
<dwfreed> Mangix: the only things that will break are people using ancient clients
<Mangix> dwfreed: I have an Android one using some ancient ssh library
<dwfreed> time to update, then
<Mangix> i don't think it even supports ECDSA
<Mangix> it's a file manager
<dwfreed> I use FX for file management; have not had issues when I've used its SFTP support, iirc
<mrkiko> seems to work but in the end I kept etc/dropbear
GNUmoon has joined #openwrt-devel
<Mangix> dwfreed: FX is what I'm talking about. lol
<Mangix> Maybe he updated the library or switched to a new one
gch981213 has quit [Quit: https://quassel-irc.org - Chat comfortably. Anywhere.]
jeff___m has joined #openwrt-devel
jeff___m has quit [Ping timeout: 480 seconds]
jeff___m has joined #openwrt-devel
goliath has quit [Quit: SIGSEGV]