14:45 <alyssa> bbrezillon: ok, i was wrong about the frame shaders. I'm sorry.

15:15 <alyssa> I /am/ somewhat unsure why we cache RSDs

15:20 <alyssa> (Doesn't the cache cost more than just uploading them again to a temp pool?)

17:08 <alyssa> fast mipmapping, rather

17:09 <alyssa> Not conceptually hard, but figuring out what API to expose is nontrivial

17:09 <alyssa> might do it bifrost only, at least to start out and test the value

17:11 <macc24> fast mipmaps https://i.imgur.com/s4qWlYp.png xD

18:48 <alyssa> fast mipmap impl passed its first test ;-D

18:48 <macc24> \o/

18:49 <alyssa> whether it's meaningfully faster remains to be seen

18:54 <alyssa> ha HA!!

18:56 <alyssa> (asterisk: still need to verify correctness)

19:00 <alyssa> looks right over VNC at least

19:02 <alyssa> glmark2 -bterrain on Mali-G52:

19:02 <alyssa> 46fps to 53fps

19:03 <alyssa> (this is off-screen)

19:03 <alyssa> so frame time is cut by a massive 13%

19:04 <macc24> :O !!!

19:04 <alyssa> (The rest of glmark2 should be unaffected. -bterrain is the only scene stupid enough to call glGenerateMipmap in a hot path)

19:08 <alyssa> the fast mipmap generation is passing deqp-gles2 on g52

19:08 <alyssa> not complete nough for gles3, but seeing terrain improved that much means this is probably worth finishing up

19:23 <alyssa> that benchmark has taunted me for years, so i'm glad to finally get an explanation for it.

19:34 <cphealy> alyssa: That's a very nice improvement. terrain is one of the glmark2 benchmarks that performs significantly slower than Mali so this improvement is definitely welcome!

19:51 <alyssa> cphealy: for sure :)

19:51 <alyssa> still quite a bunch of todo's for that MR

19:52 <alyssa> (expanding functionality to cover gles3 requirements, porting to midgard, cleaning up the code, figuring out how to coax bbrezillon into reviewing it, ... ;) )

19:58 <cphealy> One interesting thing about glmark2 benchmarks is that even though some benchmarks are slower with Mesa than Mali DDK, others are faster with Mesa when compared to Mali DDK. Definitely promising!

20:22 <HdkR> ooo, fast mips

20:50 <alyssa> cphealy: It is interesting how little glmark2 numbers say about real world perf *sighs*

20:50 <cphealy> That's likely true with many benchmarks... ;-)

20:51 <alyssa> yep

20:52 <cphealy> The marketing folks definitely like benchmarks though

20:53 <cphealy> Look, mine is 3fps faster than theirs

20:56 <HdkR> 1 to 4 FPS is a heck of an improvement! :D

20:57 <cphealy> haha, fair enough

20:57 <HdkR> Must be a ray tracing benchmark

20:58 <alyssa> HdkR: you joke but 4x faster!!

20:59 <HdkR> Perfect for marketing

21:09 <cphealy> alyssa: beyond the above mentioned change that improves terrain demo, are there any other known optimizations with G52 that are not already in Mesa 22 branch?

21:10 <alyssa> don't remember

21:10 <alyssa> probably no, been focused on Valhall

21:12 <cphealy> ack

22:07 <alyssa> did I just accidentally implement an optimization for Mali-T720 only jeez I've caved

22:08 <alyssa> I don't even own any T720 hardware

23:09 <HdkR> It's a slippery slope. Soon you'll be optimizing for t6xx

23:21 <macc24> is there even t6xx hardware around that is still working

23:22 <HdkR> I'm sure there are a bunch of hard kernel boards being used

23:22 <HdkR> HardKernel even