ChanServ changed the topic of #wayland to: https://wayland.freedesktop.org | Discussion about the Wayland protocol and its implementations, plus libinput | register your nick to speak
Company has quit [Quit: Leaving]
Satan has joined #wayland
columbarius has joined #wayland
co1umbarius has quit [Ping timeout: 480 seconds]
user__ has joined #wayland
user__ has quit [Remote host closed the connection]
cabal704 has joined #wayland
devilhorns has joined #wayland
repetiti` has left #wayland [#wayland]
fmuellner has quit [Ping timeout: 480 seconds]
devilhorns has quit []
ybogdano has quit [Ping timeout: 480 seconds]
cabal704 has quit [Quit: WeeChat 3.5]
Consolatis_ has joined #wayland
Consolatis is now known as Guest2247
Consolatis_ is now known as Consolatis
Guest2247 has quit [Ping timeout: 480 seconds]
xerpi[m] has joined #wayland
radu242 has joined #wayland
zebrag has quit [Quit: Konversation terminated!]
coleman has quit [Remote host closed the connection]
coleman has joined #wayland
cool110 has quit [Remote host closed the connection]
cool110 has joined #wayland
cool110 has quit [Quit: ZNC 1.8.2+deb2build5 - https://znc.in]
cool110 has joined #wayland
cool110 has quit [Remote host closed the connection]
cool110 has joined #wayland
cool110_ has joined #wayland
cool110 has quit [Remote host closed the connection]
remyabel2 has joined #wayland
remyabel2 has quit [Quit: remyabel2]
remyabel2 has joined #wayland
chekam has joined #wayland
dcz has joined #wayland
cheka has quit [Ping timeout: 480 seconds]
tzimmermann has joined #wayland
mbalmer has joined #wayland
mbalmer has quit []
danvet has joined #wayland
andyrtr has quit [Read error: Connection reset by peer]
andyrtr has joined #wayland
<pq>
romangg, I disagree. That summary line looks horrible, and it does not push contributors to communicate better. Reviewers are the only thing that pushes for better communication.
<emersion>
^
andyrtr has quit [Remote host closed the connection]
andyrtr has joined #wayland
peeterm_ has quit []
peeterm has joined #wayland
peeterm has quit []
peeterm has joined #wayland
peeterm has quit []
andyrtr has quit [Remote host closed the connection]
<kennylevinsen>
Well, the the syntax and thus release note text could be improved by changing "fix(xyz): sort planes" -> "xyz: Fix glitch caused by plane order"
<kennylevinsen>
but yeah, while I like shortlog release notes, they do require at least a manual resumé/highlight of breaking changes/etc.
<kennylevinsen>
ah, the fix(xyz) is part of the conventional-changelog spec, hmm. yeah, not a fan - that negatively affects the shortlog aesthetics and general git interaction :(
<pq>
To me, the point of release notes is to be something end users can understand and find relevant. Commit messages are written to a more technical audience and even the summary may not be understandable to end users.
<kennylevinsen>
agreed - sometimes the end-user is developers and then shortlog og shortlog + small text about highlights/breakages is fine, but not always
<pq>
since the summary length is very limited and it basically acts as a unique'ish id of a change, it's not appropriate for end user communication.
<pq>
I think the shortlog tends to become very noisy if developers keep patches optimized for reviewability, i.e. doing small incremental and contained changes as steps towards the goal.
<pq>
MR titles would work better I think.
<emersion>
one reason why i have this script around to collect MRs for a release
<emersion>
but even MR title isn't enough
<emersion>
maybe if the MRs are labeled bug/enhancement, it helps a bit
RomanGilg[m] has joined #wayland
<emersion>
bugfixes are not worth including in major version release notes
<jadahl>
labels can help with that ^^ but it requires reviewers to set them
<kennylevinsen>
I don't think MRs will be understandable when git summary commits are not, it just reduces the number of lines. MR titles are written with the same audience in mind as git summary lines.
<emersion>
yes
<emersion>
some features are split in multiple MRs, some MRs aren't bugfixes but still aren't interesting to end users
<pq>
kennylevinsen, exactly, MR titles reduce the noise. You don't have to dig into each commit, it's enough to dig into each MR.
<emersion>
maybe my script could sort the MRs by diffstat size
<jadahl>
for mutter/gnome-shell we've been contemplating adding specially crafted ``` entries in some comment that the committer writes to help the one who makes the release
<jadahl>
i.e. someone who lands an MR can make the release note writing easier by preparing the release note for some MR when merging
<kennylevinsen>
pq: is our issue too many lines or incomprehensible content? if our only issue is too many lines in a shortlog, then sure
<kennylevinsen>
but I'd argue that if the git summary line was not useful for the end-user, then neither will an MR title be - they were both written for Weston developers, not end-users
<pq>
wonder if the NEWS file could be made to work without requiring all contributors to fill it in - they could fill it in if they want, but somehow make it easy for the reviewer to add that into the MR before merging.
<kennylevinsen>
I have no opposition to hand-written release notes though
<jadahl>
pq: it could by adding convention how to write them in gitlab commets then making a release note script understand said convention
<pq>
jadahl, that's definitely not what I meant.
<kennylevinsen>
hmm, what's the benefit over just extending a release note file as part of the MR in that case?
<kennylevinsen>
if it's written as part of the MR anyway
<jadahl>
pq: i mean the committer writes the comment, not the arbitrary contributor
<pq>
I mean an actual commit updating the NEWS file as part of the MR. Either a separate commit or squashed into an appropriate commit.
<jadahl>
ah, i see
<jadahl>
sounds like a way to always get merge conflicts
<pq>
then when later MR modify the feature, they can update the NEWS file entry too
<jadahl>
each merge request changing the same line in the same file
<pq>
kennylevinsen, the benefit is that you don't demand the contributor to do one more thing.
<kennylevinsen>
silly idea: per-MR changelog file in a changelog folder, avoid the conflicts
<pq>
that did occur to me, yeah
<emersion>
if you're fighting Git, might as well not use Git for that use-case
<pq>
I would really like the release note to be part of the code submission and enter the source tree at the same time.
<kennylevinsen>
I haven't tried it - for consumer-facing products I usually just handwrite release notes asynchronously with an in-tree file per version (e.g. relnotes/1.2.3.txt)
<kennylevinsen>
with time set aside to do a walk of the git log from last release to see if we forgot anything
<jadahl>
pq: put it in the commit message then?
<pq>
jadahl, would that not require imposing machine readable format requirements to the commit message?
cool110_ has quit [Remote host closed the connection]
cool110 has joined #wayland
emersion has quit [Remote host closed the connection]
emersion has joined #wayland
cool110_ has joined #wayland
cool110 has quit [Quit: ZNC 1.8.2+deb2build5 - https://znc.in]
cabal704 has joined #wayland
frytaped has joined #wayland
cabal705 has joined #wayland
cabal704 has quit [Ping timeout: 480 seconds]
frytaped has quit []
frytaped has joined #wayland
frytaped has quit [Quit: WeeChat 3.5]
bhawan has joined #wayland
fmuellner_ has joined #wayland
fmuellner has quit [Ping timeout: 480 seconds]
cabal705 has quit [Read error: Connection reset by peer]
cabal705 has joined #wayland
markbolhuis has quit [Quit: markbolhuis]
tzimmermann has quit [Quit: Leaving]
cabal704 has joined #wayland
cabal705 has quit [Ping timeout: 480 seconds]
agd5f_ has joined #wayland
agd5f_ has quit [Remote host closed the connection]
agd5f_ has joined #wayland
jmdaemon has joined #wayland
agd5f has quit [Ping timeout: 480 seconds]
ybogdano has joined #wayland
<MrCooper>
the compositor is free to send both scanout and non-scanout tranches in a single feedback for zwp_linux_dmabuf_v1::get_default_feedback , right?
rasterman has quit [Quit: Gettin' stinky!]
<emersion>
MrCooper: that's not a good idea in general
<emersion>
it means clients will try to use the scanout modifiers for all of their buffers always
<emersion>
default feedback is designed for simple clients which don't know how to re-allocate their buffers
cabal704 has quit [Read error: Connection reset by peer]
cabal704 has joined #wayland
eroux_ has joined #wayland
eroux has quit [Ping timeout: 480 seconds]
eroux has joined #wayland
eroux_ has quit [Ping timeout: 480 seconds]
<bl4ckb0ne>
when was wl_output v4 introduced? i cant find the release log
cabal704 has quit [Read error: Connection reset by peer]
<emersion>
click "..." button next to "parent"
<emersion>
shows all tags the commit is in
<emersion>
tl;dr 1.20
<bl4ckb0ne>
oh neat, thanks
cabal704 has joined #wayland
eroux_ has joined #wayland
agd5f_ has quit []
agd5f has joined #wayland
bhawan has quit []
manuel1985 has quit [Quit: Leaving]
eroux has quit [Ping timeout: 480 seconds]
Brainium has joined #wayland
bhawan has joined #wayland
radu242 has quit [Ping timeout: 480 seconds]
fmuellner_ has quit [Ping timeout: 480 seconds]
rasterman has joined #wayland
cabal704 has quit [Remote host closed the connection]
ybogdano has quit [Ping timeout: 480 seconds]
chekam has quit []
Brainium has quit [Ping timeout: 480 seconds]
ybogdano has joined #wayland
Brainium has joined #wayland
<kchibisov>
When compositor sends just `text_input::done` (without any preedit, commit, ect) what client should do? Should I assume that preedit was cleared that way?
shankaru has quit [Read error: Connection reset by peer]
aswar002 has quit [Read error: Connection reset by peer]
shankaru has joined #wayland
aswar002 has joined #wayland
zebrag has joined #wayland
<vyivel>
based on the description, I'd say yes
<kchibisov>
It sort of reads like that as well, just not clear that you must apply it in that case.
bhawan has quit []
rv1sr has quit []
rasterman has quit [Quit: Gettin' stinky!]
Lucretia has quit [Read error: No route to host]
Lucretia has joined #wayland
fmuellner has joined #wayland
cool110_ has quit [Remote host closed the connection]