ChanServ changed the topic of #asahi-dev to: Asahi Linux: porting Linux to Apple Silicon macs | Non-development talk: #asahi | General development | GitHub: https://alx.sh/g | Wiki: https://alx.sh/w | Logs: https://alx.sh/l/asahi-dev
<janneg>
I thought it would be a good idea to support adding keys dynamically through sysfs for simple user testing of keys but after seeing how hwmon is probed: no way
<chadmed>
yeah its a nightmare, i really really hate how the whole hwmon_channel_info thing works
<janneg>
I tried to make macsmc_hwmon_populate_info() nicer buit gave up
<chadmed>
which is why my initial prototype just had a header file with all of them precomposed for each machine
<chadmed>
but thats getting very close to amd drm autogen register definitions
<chadmed>
(approximately 99.999% of all kernel code)
<chadmed>
we could probably improve macsmc_hwmon_populate_info() eventually, im sure ive done something a bit silly in there
<chadmed>
also just fyi '-' in hwmon driver names is now illegal which is why i used '_'
<janneg>
ah, that'll break the pattern in smc_core.c
<chadmed>
yeah :/
<janneg>
oh well
<chadmed>
i wonder which will get NACKed for upstreaming, the pattern break or using a '-' :)
<chadmed>
its a coin flip
<janneg>
a comment over the driver name would be helpful
<chadmed>
oh wait no the smc stuff is in our platform/apple dir ok who cares then
<chadmed>
did hwmon not complain about the '-' on probe?
<janneg>
I see only complaints about the temp sensors nopt being attached top a thermal zone
<chadmed>
huh interesting. when i used - it had a big whinge about it and explicitly said to replace it with _
<janneg>
devm_hwmon_device_register_with_info has still a "macsmc_hwmon" parameter
<janneg>
probably complained about that one
<chadmed>
ah yeah thats the one it didnt like
<chadmed>
okay so it doesnt care about the mfd cell name thats nice
cylm has joined #asahi-dev
gabuscus has quit []
hightower3 has joined #asahi-dev
hightower2 has quit [Ping timeout: 480 seconds]
gabuscus has joined #asahi-dev
jeisom has quit [Ping timeout: 480 seconds]
crabbedhaloablut has joined #asahi-dev
Warr has joined #asahi-dev
Warr has quit []
tristan2 has joined #asahi-dev
tristan2_ has quit [Ping timeout: 480 seconds]
zalyx0 has quit [Read error: Connection reset by peer]