<tarceri_>
mareko: it is first populated by the interstage linking right? In case there are multiple shaders used in the same stage. This is something spirv doesn't have to worry about.
kts has quit [Ping timeout: 480 seconds]
alanc has quit [Remote host closed the connection]
illwieckz has quit [Remote host closed the connection]
<javierm>
tzimmermann: I see that Geert already acked patch #2
<javierm>
tzimmermann: let me take a look to #1
<tzimmermann>
javierm, geert only acked one architecture :/
<tzimmermann>
the powerpc devs appear to be ok with the ppc changes. it's the code that they sugggested to me
illwieckz has joined #dri-devel
An0num0us has joined #dri-devel
bmodem has quit [Quit: bmodem]
lynxeye has joined #dri-devel
pcercuei has joined #dri-devel
pekkari has quit [Quit: Konversation terminated!]
itoral_ has joined #dri-devel
vliaskov has joined #dri-devel
pochu has joined #dri-devel
pekkari has joined #dri-devel
apinheiro has joined #dri-devel
lcn has quit [Remote host closed the connection]
lcn has joined #dri-devel
xypron has quit [Remote host closed the connection]
nashpa has quit []
lcn has quit [Quit: leaving]
dliviu has joined #dri-devel
pekkari has quit [Quit: Konversation terminated!]
tursulin has joined #dri-devel
crabbedhaloablut has quit [Read error: Connection reset by peer]
crabbedhaloablut has joined #dri-devel
qyliss has quit [Quit: bye]
qyliss has joined #dri-devel
MajorBiscuit has joined #dri-devel
tursulin has quit [Read error: Connection reset by peer]
simon-perretta-img has joined #dri-devel
tursulin has joined #dri-devel
tursulin has quit [Read error: Connection reset by peer]
tursulin has joined #dri-devel
illwieckz has quit [Remote host closed the connection]
crabbedhaloablut has quit [Read error: Connection reset by peer]
crabbedhaloablut has joined #dri-devel
illwieckz has joined #dri-devel
lcn has joined #dri-devel
xypron has joined #dri-devel
pekkari has joined #dri-devel
aravind has joined #dri-devel
cmichael has joined #dri-devel
<arnd>
tzimmermann: I took another look at your patches, and they all look sensible to me, including the revised interface names. The one part I haven't figured out so far is the purpose of this cleanup, and it does make it harder to change powerpc over to use the open-flags in phys_mem_access_prot (like arm) if we ever want to do that
<arnd>
I think the powerpc method works for them because all framebuffers are behind PCI bridges and they are unlikely to ever have a SoC with built-in GPU in the future
pekkari has quit [Quit: Konversation terminated!]
pekkari has joined #dri-devel
pcercuei has quit [Quit: brb]
tristianc6704 has quit [Ping timeout: 480 seconds]
slattann has quit [Ping timeout: 480 seconds]
tristianc6704 has joined #dri-devel
pcercuei has joined #dri-devel
donaldrobson has joined #dri-devel
bmodem has joined #dri-devel
<tzimmermann>
arnd, thanks a lot. to answer your question on the purpose: the call to fb_pgprotect() currently happens in the fbdev core code at https://elixir.bootlin.com/linux/v6.6-rc2/source/drivers/video/fbdev/core/fb_chrdev.c#L368 . it's the default mmap code for fbdev framebuffers. as part of a modernization of this code, i want to move it into a helper callback. but our current callback for per-driver mmap does not support
<javierm>
tzimmermann: dropping the struct file argument seems the correct thing to do, what I don't understand is the value on on passing vm_{start,end} and offset instead of the vma
pekkari has quit [Quit: Konversation terminated!]
<tzimmermann>
javierm, "principle of least surprise": the new api is close in spirit to the existing pgprot_() functions. none of them uses vm_area_struct directly. interacting with the vma is left to the caller. the new helper simply blends in
Ntemis has quit [Read error: Connection reset by peer]
yogesh_mohan has joined #dri-devel
pcercuei has quit [Quit: brb]
pcercuei has joined #dri-devel
Haaninjo has joined #dri-devel
bmodem has joined #dri-devel
pekkari has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
frieder has quit [Remote host closed the connection]
pekkari has joined #dri-devel
<jani>
hey all, I wanted to add issue templates to https://gitlab.freedesktop.org/drm/intel. however, in gitlab they need to be in the default branch under .gitlab/issue_templates. this is annoying for kernel repos (even if we don't host the drm-intel.git in that project yet). the alternative is to add a dedicated repo for issue templates at the group level. any opposition to adding an issue template repo under the drm group?
<jani>
it could either be a dedicate repo for templates, or we could reuse the maintainer-tools repo for this
<koike>
why not a general drm issue repo with tags ?
rasterman has quit [Quit: Gettin' stinky!]
<jani>
I think drivers want to manage their issues as they see fit
<jani>
within the fdo gitlab instance you can still move issues between repos
<jani>
plus I presume most non-intel folks don't want to see our firehose of CI issues
<jani>
(afk->)
kzd has joined #dri-devel
tristianc6704 has quit [Read error: No route to host]
yuq825 has quit []
<robclark>
jani: I'
<robclark>
jani: I'd be interested in templates for drm/msm as well
rsalvaterra has quit []
rsalvaterra has joined #dri-devel
angerctl has joined #dri-devel
Namarrgon has quit [Ping timeout: 480 seconds]
sgruszka has quit [Ping timeout: 480 seconds]
kts has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
<arnd>
tzimmermann: ok, got it. thinking about it some more, I suppose we could still make powerpc work more like arm, in which case the pci sysfs path would use the file flags when passed but fall back to the rewritten code that does not need the file anyway
pekkari has quit [Quit: Konversation terminated!]
mattst88 has quit [Quit: leaving]
mattst88 has joined #dri-devel
mattst88 has quit []
mattst88 has joined #dri-devel
crabbedhaloablut has quit [Read error: Connection reset by peer]
crabbedhaloablut has joined #dri-devel
Duke`` has joined #dri-devel
kts has quit [Ping timeout: 480 seconds]
<anholt>
hakzsam: I'd like to get vulkan video tested, but it looks like the cts we're on is missing some significant fixes.
<jani>
robclark: unfortunately, the default template would still have to be common for the group (can't set it per project in the free version afaict) but it could be a template telling folks to choose a suitable template
lemonzest has joined #dri-devel
<robclark>
jani: that works for me.. I think we could come up with templates that work reasonably across drivers. Let's just try it and we can improve the templates as we go
bmodem has quit [Remote host closed the connection]
bmodem has joined #dri-devel
MajorBiscuit has quit [Ping timeout: 480 seconds]
_DOOM_ has joined #dri-devel
cmichael has quit [Quit: Leaving]
<mareko>
tarceri_: I don't actually know how it's populated, only that UniformBlocks is set before UBO linking for GLSL, but it's NULL for SPIR-V
<mareko>
tarceri_: it would also be useful to have dead UBO elimination in the future
<alyssa>
idr: you assigned marge as I was typing! =D
<_DOOM_>
Are there any deeper explanations for the property types in drm_mode.h, like what is DRM_MODE_PROP_RANGE?
<idr>
alyssa: I tried to unassign it. Does that work?
<alyssa>
probably?
<idr>
I had to cancel the pipeline too.
rasterman has joined #dri-devel
<alyssa>
ah
pochu has quit [Quit: leaving]
<alyssa>
idr: fwiw I don't particularly object to the MR, just suspect the shaderdb results may look very different once opt_sink'ing alu is enabled and the easy cases with compares happen automatically
heat_ has joined #dri-devel
heat has quit [Read error: Connection reset by peer]
<idr>
alyssa: After looking at that pass, these are generally doing opposite things. nir_opt_sink is a simplified GCM/GVN kind of thing. The rematerialization pass tries to create more copies of an instruction whose result is used by a comparison.
<idr>
The goal there is to reduce register pressure... only x needs to be live instead of perhaps x and bool(x == 0).
<idr>
But... it's for sure worth looking at the interation.
<idr>
*interaction
<alyssa>
idr: sure :)
donaldrobson has quit [Ping timeout: 480 seconds]
_DOOM_ has quit [Quit: WeeChat 4.0.4]
_DOOM_ has joined #dri-devel
kzd has quit [Quit: kzd]
flom84 has joined #dri-devel
kts has quit [Remote host closed the connection]
kts has joined #dri-devel
<zzag>
Do you know why `glFenceSync(GL_SYNC_GPU_COMMANDS_COMPLETE, 0)` can take 500-800ms to execute?
<zzag>
kwin uses a persistently mapped vertex buffer
<zzag>
after finishing every frame, it inserts a fence to avoid overwriting vertex buffer that might be used by the gpu
<zzag>
but we've noticed that sometimes inserting can take a really long time
<zzag>
thus resulting in frame drops
<zzag>
is it a bug or do we need to look out after something?
<cmarcelo>
eric_engestrom: dcbaker: are meson dependencies transitive? e.g. if I have a library b that depends on idep_a, then declare a dependency idep_b; finally would a library c that depends on both a/b need to dep both on idep_a and idep_b or is idep_b enough?
<eric_engestrom>
cmarcelo: if idep_b had idep_a in its dependencies, then anything that has idep_b in its dependencies also has idep_a
_DOOM_ has quit [Ping timeout: 480 seconds]
<eric_engestrom>
*also gets idep_a (to be clearer)
<idr>
zzag: Is this on a specific driver, or have you observed this on multiple platforms?
<eric_engestrom>
that's why I had started rewriting a bunch of headers and static libs into ideps, so that we don't have to care about what that header or static lib uses internally, the dependencies gets transmitted automatically
<eric_engestrom>
but iirc I posted a few conversions like this, but I never finished
<zzag>
idr: so far we've observed it only on machines with intel gpus
Haaninjo has quit [Read error: Connection reset by peer]
<eric_engestrom>
cmarcelo: if you're thinking about doing that for your builtin header target, I approve and will review your MR :)
<zzag>
idr: I can try to get a backtrace with debug symbols
heat_ has quit [Remote host closed the connection]
heat_ has joined #dri-devel
Haaninjo has joined #dri-devel
kts has quit [Read error: Connection reset by peer]
kts has joined #dri-devel
<dcbaker>
cmarcelo: link_(with|whole) are not guaranteed to be transitive in a situation like `liba = library(... dep : foo); lib = library(..., link_with : liba)`, (though as an implementation detail it may), but as eric_engestrom said, `declare_dependency(dependencies : ...)` does have that guarantee, so bundling generated headers and libraries for linking is a good way to go for that
heat_ has quit [Remote host closed the connection]
<cmarcelo>
eric_engestrom: yes the plan is to add idep_compiler
heat_ has joined #dri-devel
<koike>
mairacanal: there are some tests I couldn't run (please see -skips.txt file in the patch) and some consistent failures, could you please confirm that those were expected?
<koike>
mairacanal: I also see the configfs patch, will that change vkms ? Would that require more vkms jobs in different configurations?
<cmarcelo>
dcbaker: so do I need to explicitly add the dependencies again inside the idep? here's the sequence, the XXX marks the spot where I'm unsure I need to add dependencies again: libcompiler = static( .... generated_sources_h ... ); idep_compiler = ( includes... link_with: libcompiler); nir = static( .... deps: idep_compiler); idep_nir = ( link_with: nir... XXX); vtn = static( deps: idep_nir).
flom_84 has joined #dri-devel
flom84 has quit [Ping timeout: 480 seconds]
<dcbaker>
cmarcelo: yes, or you could do something like `_private_dep = declare_dependency(<everything except the lib itself>); lib = library(..., dependencies : _private_dep); idep = declare_dependency(link_with : lib, dependencies : _private_dep)`
flom_84 has quit []
<cmarcelo>
dcbaker: ok.
<cmarcelo>
tks
lynxeye has quit [Quit: Leaving.]
<mareko>
tarceri_: FYI, there are some fields in gl_shader_program that aren't serialized
<mareko>
I don't know if that's expected
tristianc6704 has joined #dri-devel
ngcortes has joined #dri-devel
frankbinns has joined #dri-devel
<karolherbst>
I wonder if I can reduce an uniform loop (each instruction is converged and all outputs are uniform) with n iterations to one with n / subgroup_size iterations... and replace alu operations (e.g. iadd) with subgroup operations...
rasterman has quit [Quit: Gettin' stinky!]
frankbinns has quit [Ping timeout: 480 seconds]
illwieckz has quit [Ping timeout: 480 seconds]
frankbinns has joined #dri-devel
<pendingchaos>
sounds like basically an extreme form of loop vectorization
<karolherbst>
cmarcelo: that happens if you update rustc via rustup or other random reasons. You can just remove all those *.rlib files and it should fix it
junaid has quit [Remote host closed the connection]
<cmarcelo>
karolherbst: trying removing them. shouldn't "ninja clean" be able to remove them though?
<karolherbst>
it should...
<karolherbst>
but then you need to rebuild everything
<karolherbst>
ohh.. you might have to delete librusticl_proc_macros.so as well
<cmarcelo>
(It did ninja clean and there were a few *.rlib.p directories inside build
<karolherbst>
yeah.. that's fine
<karolherbst>
it's just about the rlib files, because rust wants everything to be built with the same rustc compiler
<karolherbst>
and meson doesn't pick up that rustc changed if using rustup
<cmarcelo>
trying with a brand new build dir
<karolherbst>
normally you'd have some more lines before that failed to resolve which should tell you what's up
heat has joined #dri-devel
heat_ has quit [Read error: Connection reset by peer]
<karolherbst>
I get this when I enabled rusticl later :'(
<karolherbst>
and yeah..
<karolherbst>
I need to meson yet another time get 2021
<karolherbst>
*meson configure
<cmarcelo>
still unsure what's up with rust_std not appearing for me if I do setup annd then configure
<cmarcelo>
it seems it does show to you but as 'none'
<karolherbst>
do you enable rusticl when running setup?
<cmarcelo>
I was enabling it after: meson setup build; cd build; meson configure -D...
<karolherbst>
if you enable it later via configure, you have to run configure a second time
<karolherbst>
and I think reconfigure has to run between them
illwieckz has quit [Ping timeout: 480 seconds]
<cmarcelo>
karolherbst: got it. (still checking with the good meson setup here.)
<cmarcelo>
it works
<karolherbst>
last time I spoke with dcbaker about it, the issue appeared to be non trivial and a pita to fix
illwieckz has joined #dri-devel
mvlad has quit [Remote host closed the connection]
_DOOM_ has joined #dri-devel
_DOOM_ has quit []
An0num0us has quit [Ping timeout: 480 seconds]
frankbinns has quit [Remote host closed the connection]
<cmarcelo>
dcbaker: (or eric_engestrom): do I need to explicitly include the generated headers in the declare_dependency { sources: ... } for my new compiler dependency? I'd expect no, but alpine run seems still grumpy.
heat has quit [Remote host closed the connection]
<cmarcelo>
the compiler dependency already depends on the compiler library (which depends on the generated headers to be built), so I was assuming it was not necessary.
kts has quit [Ping timeout: 480 seconds]
kts has joined #dri-devel
tertl8 has quit [Quit: Connection closed for inactivity]
<tarceri_>
mareko: i don't think it is set before linking. It's still set in the GLSL IR linker not the NIR linker like spirv.
<dcbaker>
cmarcelo: If the consumers of that dependency need to be ordered after the headers are generated then yes
<cmarcelo>
but aren't they already ordered after the library (compiler)?
<cmarcelo>
dcbaker: ^
<cmarcelo>
(trying out the CI with that added)
<dcbaker>
cmarcelo: if you have two librarys, A and B, and B has a dependency on generated header H, then the object files for A can be compiled before the Header is generated, but A cannot be linked until B is linked
<dcbaker>
Which means if a generated header is private to B, then by not putting it in A you can parallelized the build better
<mareko>
tarceri_: I see
shashanks__ has joined #dri-devel
kts_ has joined #dri-devel
shashanks_ has quit [Ping timeout: 480 seconds]
kts has quit [Read error: Connection reset by peer]
mbrost_ has joined #dri-devel
vliaskov has quit [Remote host closed the connection]
aswar002 has quit [Remote host closed the connection]
aswar002 has joined #dri-devel
pcercuei has quit [Quit: dodo]
mbrost has quit [Ping timeout: 480 seconds]
Guest554 has quit []
Danct12 has joined #dri-devel
oneforall2 has quit [Remote host closed the connection]