tzimmermann has quit [Remote host closed the connection]
tzimmermann has joined #dri-devel
Duke`` has quit [Ping timeout: 480 seconds]
fab has joined #dri-devel
YuGiOhJCJ has joined #dri-devel
kzd has quit [Ping timeout: 480 seconds]
kem has quit [Ping timeout: 480 seconds]
sgruszka has joined #dri-devel
pekkari has joined #dri-devel
kem has joined #dri-devel
Peuc has quit [Remote host closed the connection]
Peuc has joined #dri-devel
habernir has joined #dri-devel
kem has quit [Ping timeout: 480 seconds]
itoral has joined #dri-devel
kem has joined #dri-devel
mvlad has joined #dri-devel
crabbedhaloablut has joined #dri-devel
<javierm>
tzimmermann: I was on holidays yesterday, I'll take a look to the patch-set today
An0num0us has joined #dri-devel
rasterman has joined #dri-devel
<soreau>
daniels: When I force push my branch to update i.e. https://gitlab.freedesktop.org/mesa/kmscube/-/merge_requests/47 it sends a ci-fail message to my inbox because I lack permissions to run it. Is there anything that can be done so it runs the ci successfully when I force push?
<soreau>
robclark: eric_engestrom: who should I ping about this MR to have it reviewed? ^^
pekkari has quit [Quit: Konversation terminated!]
<tzimmermann>
javierm, thank you
rgallaispou has joined #dri-devel
habernir has quit [Quit: Leaving]
Dark-Show_Pi4 has joined #dri-devel
sghuge has quit [Remote host closed the connection]
sgruszka has quit [Ping timeout: 480 seconds]
sghuge has joined #dri-devel
Dark-Show_Pi4 has quit [Quit: Leaving]
tursulin has joined #dri-devel
Company has joined #dri-devel
pochu has joined #dri-devel
lemonzest has quit [Quit: WeeChat 4.0.4]
Kayden has quit [Quit: Leaving]
vyivel has quit [Read error: Connection reset by peer]
vyivel has joined #dri-devel
Kayden has joined #dri-devel
mripard has joined #dri-devel
lemonzest has joined #dri-devel
Dark-Show_Pi4 has joined #dri-devel
pekkari has joined #dri-devel
pcercuei has joined #dri-devel
vliaskov has joined #dri-devel
lynxeye has joined #dri-devel
bbrezillon has joined #dri-devel
bbrezillon has quit []
bbrezillon_ has joined #dri-devel
lynxeye has quit [Ping timeout: 480 seconds]
kos_tom has joined #dri-devel
pekkari has quit [Quit: Konversation terminated!]
junaid has joined #dri-devel
lynxeye has joined #dri-devel
ascent12 has quit [Quit: ZNC 1.7.2+deb3 - https://znc.in]
ascent12 has joined #dri-devel
junaid has quit [Remote host closed the connection]
co1umbarius has quit [Ping timeout: 480 seconds]
sarahwalker has joined #dri-devel
co1umbarius has joined #dri-devel
junaid has joined #dri-devel
junaid has quit [Remote host closed the connection]
oneforall2 has quit [Remote host closed the connection]
<soreau>
zmike: got xwayland working with zink and no modifiers using a hacky 3 liner patch (see the issue)
oneforall2 has joined #dri-devel
<kode54>
soreau: you are cool
Company has quit [Remote host closed the connection]
<soreau>
kode54: well, not yet.. that was only in nested wayland backend
cmichael has joined #dri-devel
<kode54>
Oh
<kode54>
Well, get it to where you can dogfood it
<kode54>
Iām maining your track-wlroots branch at least
DodoGTA has quit [Remote host closed the connection]
YuGiOhJCJ has quit [Quit: YuGiOhJCJ]
vyivel has quit [Ping timeout: 480 seconds]
vyivel has joined #dri-devel
Dark-Show_Pi4 has quit [Quit: Leaving]
heat has joined #dri-devel
Haaninjo has joined #dri-devel
novaisc has joined #dri-devel
tonyk has joined #dri-devel
pekkari has joined #dri-devel
<MrCooper>
can commit_tail get called from atomic context?
DodoGTA has joined #dri-devel
<MrCooper>
err, make that drm_atomic_helper_commit with nonblock=false
DavidHeidelberg has quit [Remote host closed the connection]
okias has joined #dri-devel
okias has quit [Remote host closed the connection]
DavidHeidelberg has joined #dri-devel
DavidHeidelberg has quit [Remote host closed the connection]
DavidHeidelberg[m]_ has joined #dri-devel
DavidHeidelberg[m]_ has quit [Remote host closed the connection]
DavidHeidelberg has joined #dri-devel
pekkari has quit [Quit: Konversation terminated!]
heat has quit [Ping timeout: 480 seconds]
mairacanal has joined #dri-devel
Danct12 has quit [Ping timeout: 480 seconds]
yyds has quit [Quit: Lost terminal]
yyds has joined #dri-devel
antoniospg has joined #dri-devel
vliaskov has quit [Remote host closed the connection]
<arnd>
tzimmermann: I actually wanted to get back to this today, and something else came up. I had been travelling most of the time in the last six weeks, so I did not get to it earlier
itoral has quit [Quit: Leaving]
Danct12 has joined #dri-devel
yyds has quit [Remote host closed the connection]
atipls has joined #dri-devel
An0num0us has quit [Ping timeout: 480 seconds]
<karolherbst>
zmike: question.. if I call launch_grid, then memory_barrier(PIPE_BARRIER_ALL) then resource_map a buffer used in launch_grid, should I expect the content behind the map pointer to be synced?
An0num0us has joined #dri-devel
<karolherbst>
maybe some zink_batch_reference_resource_rw are missing for the global buffers..
<karolherbst>
ehh
<karolherbst>
buffer_map I mean
<zmike>
karolherbst: no
<zmike>
you'd need to map the buffer persistently
Dark-Show_Pi4 has joined #dri-devel
<karolherbst>
mhhh.... kinda annoying, because it's not necessarily a buffer not being created with PIPE_RESOURCE_FLAG_MAP_PERSISTENT
<karolherbst>
s/not/
<karolherbst>
also, I just wnat to copy the buffers content to host memory
<zmike>
then you could also manually sync it
<karolherbst>
yeah, that would be fine
<zmike>
I think that's a transfer_map_flush thing but I'll have to get down to my office and check
<zmike>
alternatively resource_copy_region ?
<karolherbst>
that only works between two resources.. but I guess I could create a temporary one
<karolherbst>
but that kinda sounds a bit wasteful to do
<karolherbst>
right.. there is transfer_flush_region
<karolherbst>
yeah, let me look into that
<karolherbst>
ehh.. looks like that's only for writes into the mapped area
An0num0us has quit [Ping timeout: 480 seconds]
<tzimmermann>
arnd, ah ok. what a coincidence
<zmike>
karolherbst: I'm not sure there's a gallium api for this
<karolherbst>
yeah.. me neither
<zmike>
I'd suggest using a persistent+coherent staging resource
<karolherbst>
mhhh
<zmike>
zink does slab allocation anyway so it's basically free if you tack it on to the end of your cmdbuf right before a flush
<karolherbst>
I think I'd rather change the gallium API, because zink is the only driver where it doesn't work
<zmike>
what are you doing for other drivers that makes it work?
<karolherbst>
nothing
<zmike>
š¤
<karolherbst>
other drivers seem to synchronize things, or rather.. do things in a way, that I can use buffer_map in my use case
<karolherbst>
I didn't check though
<zmike>
maybe describe your case a bit better
<karolherbst>
I just want to map a buffer after launch_grid and see the writes to it from that compute shader
<zmike>
that should work?
<karolherbst>
I think that's unknown, all I can say is that I don't have that issue with other drivers
<zmike>
give me a branch and a test case
<karolherbst>
my rusticl/zink branch + test_conformance/basic/test_basic if
<karolherbst>
have to set "CL_DEVICE_TYPE=CL_DEVICE_TYPE_GPU RUSTICL_ENABLE=zink"
<karolherbst>
zmike: mhhh...
<karolherbst>
there might be a different fix for me
<karolherbst>
atm I flush/finish the context after doing the map + copy.. maybe I should flush first, then copy the buffer..
<karolherbst>
that seems to fix it for zink at least
rasterman has quit [Quit: Gettin' stinky!]
<karolherbst>
there is a "blocking_read/blocking_write" argument to some of the CL operations and I should probably finish the context before doing those operations...
<karolherbst>
let me toy around with that first
<zmike>
map should automatically be doing the sync as long as you aren't trying to map it asynchronously
<karolherbst>
yeah... that's what I assumed
<karolherbst>
but `zink_buffer_map` doesn't seem to sync anything before `zink_copy_buffer`
<zmike>
hmmm
<zmike>
what is this buffer used for?
<zmike>
ssbo?
<karolherbst>
yeah, CL global memory
<zmike>
you need a memory barrier between launch_grid and copy
<karolherbst>
I tried to add calls to zink_batch_reference_resource_rw for each buffer inside ctx->di.global_bindings but that didn't seem to help
<karolherbst>
yeah..
<karolherbst>
I have one :)
<karolherbst>
though currently I'm using PIPE_BARRIER_GLOBAL_BUFFER
<karolherbst>
but BARRIER_ALL also didn't help
<karolherbst>
but maybe zink has to add some barrier handling for global_bindings
<zmike>
I'll look in a few, gotta actually afk a bit now
<karolherbst>
yeah, no worries, I'll dig into it a bit
<karolherbst>
or is the stuff done in zink_update_descriptor_refs enough?
<zmike>
yeah don't do that
<karolherbst>
okay
<mareko>
tarceri: do you know if disk_cache has a mechanism that detects file corruption and rejects corrupted shaders?
<pekkari>
Hi guys, how is the best way to wait a crtc commit to be finished in the kernel side? I tried to use drm_crtc_commit_wait, but I got no big luck
<karolherbst>
zmike: you want to submit an MR or should I just add a commit in our name to the rusticl/zink one?
macromorgan has joined #dri-devel
<soreau>
daniels: thanks
<soreau>
robclark: Thanks for the review, I've been trying to clean it up. Can you say if recreating the fb on each frame is ok or should I be able to do it once upfront and just rebind on each frame?
<zmike>
karolherbst: just amend it into the other global binding one
<karolherbst>
ohhh.. yeah.. I thought it already landed...
<mareko>
dschuermann: would you be OK with adding a hash check into cached RADV shaders to detect file system corruption? or is this something disk_cache should do instead?
<karolherbst>
done
<pendingchaos>
it looks like disk_cache_os.c's parse_and_validate_cache_item() does a CRC32 check
mauld has quit []
mauld has joined #dri-devel
<karolherbst>
zmike: anyway, this was the last blocker, so if that's fine now I kinda want to merge it
<zmike>
you tell me if it's fine, I'm not running cts
<karolherbst>
yeah.. I'll run it here also with radv and see if anything else is super broken or if it's fine now..
<karolherbst>
but it looks better now
Duke`` has quit [Ping timeout: 480 seconds]
Duke`` has joined #dri-devel
sgruszka has quit [Ping timeout: 480 seconds]
<zmike>
I'll await your feedback
<karolherbst>
"Pass 2418 Fails 35 Crashes 1"
<karolherbst>
CL_ADDRESS_CLAMP being like 15 of those...
<karolherbst>
but yeah.. nothing serious enough to block on merging in
<karolherbst>
let's see what radv and lvp say
<karolherbst>
this will take a while, but I think once everything is reviewed it can land
<robclark>
soreau: recreating each frame is probably not the end of the world on most hw.. but kmsro stuff that needs contiguous scanout buffer might appreciate you not doing that
heat_ has quit [Read error: Connection reset by peer]
heat_ has joined #dri-devel
<eric_engestrom>
soreau: next time you rebase your kmscube MR, the pipeline will run properly :)
<soreau>
robclark: I did try simply rebinding the fb, db and textures, but this 'didnt work'. What more do I need to do, set min/mag filters?
<soreau>
eric_engestrom: thank you!
<robclark>
oh, I guess you are talking about the fbo you render the gears to, not the one that is scanned out? I think that shouldn't be a problem to recreate
<soreau>
I still would at least not to glGen/glDelete on each frame but I don't know how much overhead that would save
<robclark>
I'd probably not worry too much
<soreau>
ok, thanks
<soreau>
robclark: renamed the shaders and reformatted to whitespace
<pekkari>
is it the right place to ask questions about drm_atomic? or is there any other channel for that?
<MrCooper>
pekkari: this is it
<soreau>
daniels: the link is wrong on the wiki 'signup page'
bbrezillon has joined #dri-devel
<pekkari>
oh, alright, thanks MrCooper, I asked it a few lines up about how would be the right way to make drm_atomic wait on a crtc commit to be finished
sarahwalker has quit [Remote host closed the connection]
* pekkari
looking, thanks!
<pekkari>
though I'm looking into the kernel space, not sure if the user space use case will actually help my day
tobiasjakobi has joined #dri-devel
tobiasjakobi has quit [Remote host closed the connection]
pekkari has quit [Quit: Konversation terminated!]
gouchi has joined #dri-devel
lynxeye has quit [Quit: Leaving.]
<zmike>
karolherbst: anything else I need to do at this point
<karolherbst>
nope
<zmike>
k
glennk has joined #dri-devel
<karolherbst>
I'll probably run into more bugs once I test more with nvidia's vulkan driver and stuff
tzimmermann has quit [Quit: Leaving]
tales-aparecida has joined #dri-devel
rasterman has joined #dri-devel
bbrezillon_ has quit []
macromorgan has quit [Read error: Connection reset by peer]
praneeth_ has joined #dri-devel
macromorgan has joined #dri-devel
macromorgan has quit [Read error: Connection reset by peer]
macromorgan has joined #dri-devel
An0num0us has quit [Ping timeout: 480 seconds]
kts has quit [Ping timeout: 480 seconds]
ngcortes has joined #dri-devel
<karolherbst>
uhh.. my new way of loading zink doesn't work on lvp... shouldn't be hard to fix though
ngcortes_ has joined #dri-devel
<karolherbst>
mhhh.. works with LIBGL_ALWAYS_SOFTWARE=1
<karolherbst>
whatever
<zmike>
shipit
<karolherbst>
it's just a mess for the script I use to run the CTS on all the drivers and hardware and everything
<karolherbst>
but I can make that work
<soreau>
zmike: do you have any idea or comment on why drm backend hard locks the machine with my zink patch?
<soreau>
my eyes aren't as good as yours
<karolherbst>
I have to add special handling for nvidia anwyay
<zmike>
soreau: at a glance I'd say because you're trying to do complicated stuff like run xserver with glamor disabled and modifiers hacked out and hitting codepaths that aren't intended to be hit
<soreau>
zmike: no, it's glamor enabled
<soreau>
I got that working with wayland backend at least
<zmike>
but your device doesn't support modifiers
ngcortes has quit [Ping timeout: 480 seconds]
<soreau>
well, it works with wayland backend, that's what I know
<soreau>
but it's clear it's hitting paths that aren't intended for this case, I was just wondering if you had a hunch as to where or what
<zmike>
I do not
<soreau>
ok, thanks š
<zmike>
good luck
<soreau>
btw, when hard locks happen, what's a good way to debug? serial?
<karolherbst>
I hope version 261 will be new enough
<zmike>
that's kinda old
<zmike>
I think even ci has newer than 261
<karolherbst>
newest is like 264, no?
<zmike>
yea
<karolherbst>
265 actually
<karolherbst>
let's hope it's enough because atm it's the easiest thing to install/build, otehrwise I will have to build into a local prefix and that's going to be more pain
<karolherbst>
but I have currently 238....
sukrutb has joined #dri-devel
halfline has joined #dri-devel
atipls has quit []
<halfline>
did anyone on dri-devel mailing list get this mail I sent a couple of hours ago? https://paste.centos.org/view/d5ff0b7c I'm not seeing it in the archives. wondering if it got caught in a spam trap or something
<karolherbst>
zmike: yeah... no idea what's going on there. This db_template stuff is quite confusing. The test running into this is `test_basic image_r8`
<zmike>
checking
<halfline>
javierm: looks like it's in patchwork now. thanks for the link
<zmike>
oh
<zmike>
how did this work at all
<karolherbst>
ehhh
<karolherbst>
anv be like: case VK_DESCRIPTOR_TYPE_SAMPLER: /* There is no real limit on samplers */ break;
<karolherbst>
ehh
<karolherbst>
maybe different API
<karolherbst>
but anv takes a different path anyway
<karolherbst>
anyway.. "ZINK_DESCRIPTORS=lazy" works with lvp as well
<zmike>
fixed
<zmike>
pick HEAD off zmike/test
<karolherbst>
uhhh
<karolherbst>
looks better
<karolherbst>
now it's Pass 2374 Fails 40 Crashes 40
<karolherbst>
will look into the other things tomorrow
ngcortes has quit [Ping timeout: 480 seconds]
ngcortes has joined #dri-devel
ngcortes has quit [Remote host closed the connection]
ngcortes has joined #dri-devel
<karolherbst>
radv: Pass 2400 Fails 44 Crashes 10
fab has quit [Quit: fab]
tursulin has quit [Ping timeout: 480 seconds]
heat_ has quit [Remote host closed the connection]
heat has joined #dri-devel
Haaninjo has quit [Quit: Ex-Chat]
halfline has quit [Quit: Page closed]
ngcortes has quit [Ping timeout: 480 seconds]
heat_ has joined #dri-devel
heat has quit [Read error: No route to host]
gouchi has quit [Remote host closed the connection]
<soreau>
or else glxgears stride is wrong, or otherwise the image is corrupted
<soreau>
would it not work in the case where there are modifiers supported?
<soreau>
because IIUC, I think tiling would get set to VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT in that case because EXT_image_drm_format_modifier && modifiers_count
<soreau>
zmike: if you would prefer, I could make an MR where we can discuss it further on gl
<zmike>
I'm at the pub so probably that'd be more productive