00:01 <i509vcb> I don't see any layer id enum variant in gl_system_value

01:01 <i509vcb> Something about LAYER not having a sysval value feels weird

14:07 <alyssa> :\

14:22 <i509vcb> one thing I did notice is that layer has a gl_varying_slot, wouldn't that imply it's already a varying or is the common infrastructure not capable of expressing layer as a sysval currently

14:23 <i509vcb> I guess I could do tree wide changes but then I have to figure out what other drivers expect...

15:31 <alyssa> a

15:31 <alyssa> hmm

15:32 <alyssa> i509vcb: ahhh

15:32 <alyssa> I see the problem now

15:34 <alyssa> vk_meta is hardcoding a load_layer_id intrinsic inappropriately

15:34 <alyssa> rather than conditionally doing so only if the driver wants layer IDs as sysvals

15:35 <alyssa> see for contrast nir_lower_input_attachments which has a load_layer_id helper that takes driver nir options to generate a varying LAYER load instead of a sysval load if applicable

15:36 <alyssa> I think you want to take the helper in that pass, move it to nir_builder with the appropriate rename, and then convert vk_meta to use it to ensure agxv never sees load_layer_id intrinsics

15:37 <alyssa> Notably, spirv_to_nir does not generate these sysvals for layers, neither does the glsl compiler. this is just a case of the vk_meta abstraction being a bit leaky and inadvertently hardcoding NVK specific details in common code

15:38 <alyssa> shouldn't be too hard to generalize/fix vk_meta to do the right thing

15:38 <alyssa> and then no special handling will be needed in agxv, i think

15:40 <i509vcb> Fixing vk_meta there sounds reasonable, I imagine a few nvk specific details will be there anyways